Hash :
427071ea
Author :
Date :
2018-03-19T09:21:37
ES31: Add link validation on geometry shader interface block limits This patch adds link validation on the maximum number of active uniform blocks and shader storage blocks defined in the geometry shader. BUG=angleproject:1941 TEST=angle_end2end_tests Change-Id: Ieffc234981a3f32a569392786e8fa1c6623a7a23 Reviewed-on: https://chromium-review.googlesource.com/966491 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Jiajia Qin <jiajia.qin@intel.com> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448
//
// Copyright 2017 The ANGLE Project Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
// GeometryShaderTest.cpp : Tests of the implementation of geometry shader
#include "test_utils/ANGLETest.h"
using namespace angle;
namespace
{
class GeometryShaderTest : public ANGLETest
{
protected:
static std::string CreateEmptyGeometryShader(const std::string &inputPrimitive,
const std::string &outputPrimitive,
int invocations,
int maxVertices)
{
std::ostringstream ostream;
ostream << "#version 310 es\n"
"#extension GL_EXT_geometry_shader : require\n";
if (!inputPrimitive.empty())
{
ostream << "layout (" << inputPrimitive << ") in;\n";
}
if (!outputPrimitive.empty())
{
ostream << "layout (" << outputPrimitive << ") out;\n";
}
if (invocations > 0)
{
ostream << "layout (invocations = " << invocations << ") in;\n";
}
if (maxVertices >= 0)
{
ostream << "layout (max_vertices = " << maxVertices << ") out;\n";
}
ostream << "void main()\n"
"{\n"
"}";
return ostream.str();
}
const std::string kDefaultVertexShader =
R"(#version 310 es
void main()
{
gl_Position = vec4(1.0, 0.0, 0.0, 1.0);
})";
const std::string kDefaultFragmentShader =
R"(#version 310 es
precision mediump float;
layout (location = 0) out vec4 frag_out;
void main()
{
frag_out = vec4(1.0, 0.0, 0.0, 1.0);
})";
};
class GeometryShaderTestES3 : public ANGLETest
{
};
// Verify that Geometry Shader cannot be created in an OpenGL ES 3.0 context.
TEST_P(GeometryShaderTestES3, CreateGeometryShaderInES3)
{
EXPECT_TRUE(!extensionEnabled("GL_EXT_geometry_shader"));
GLuint geometryShader = glCreateShader(GL_GEOMETRY_SHADER_EXT);
EXPECT_EQ(0u, geometryShader);
EXPECT_GL_ERROR(GL_INVALID_ENUM);
}
// Verify that Geometry Shader can be created and attached to a program.
TEST_P(GeometryShaderTest, CreateAndAttachGeometryShader)
{
ANGLE_SKIP_TEST_IF(!extensionEnabled("GL_EXT_geometry_shader"));
const std::string &geometryShaderSource =
R"(#version 310 es
#extension GL_EXT_geometry_shader : require
layout (invocations = 3, triangles) in;
layout (triangle_strip, max_vertices = 3) out;
in vec4 texcoord[];
out vec4 o_texcoord;
void main()
{
int n;
for (n = 0; n < gl_in.length(); n++)
{
gl_Position = gl_in[n].gl_Position;
gl_Layer = gl_InvocationID;
o_texcoord = texcoord[n];
EmitVertex();
}
EndPrimitive();
})";
GLuint geometryShader = CompileShader(GL_GEOMETRY_SHADER_EXT, geometryShaderSource);
EXPECT_NE(0u, geometryShader);
GLuint programID = glCreateProgram();
glAttachShader(programID, geometryShader);
glDetachShader(programID, geometryShader);
glDeleteShader(geometryShader);
glDeleteProgram(programID);
EXPECT_GL_NO_ERROR();
}
// Verify that all the implementation dependent geometry shader related resource limits meet the
// requirement of GL_EXT_geometry_shader SPEC.
TEST_P(GeometryShaderTest, GeometryShaderImplementationDependentLimits)
{
ANGLE_SKIP_TEST_IF(!extensionEnabled("GL_EXT_geometry_shader"));
const std::map<GLenum, int> limits = {{GL_MAX_FRAMEBUFFER_LAYERS_EXT, 256},
{GL_MAX_GEOMETRY_UNIFORM_COMPONENTS_EXT, 1024},
{GL_MAX_GEOMETRY_UNIFORM_BLOCKS_EXT, 12},
{GL_MAX_GEOMETRY_INPUT_COMPONENTS_EXT, 64},
{GL_MAX_GEOMETRY_OUTPUT_COMPONENTS_EXT, 64},
{GL_MAX_GEOMETRY_OUTPUT_VERTICES_EXT, 256},
{GL_MAX_GEOMETRY_TOTAL_OUTPUT_COMPONENTS_EXT, 1024},
{GL_MAX_GEOMETRY_TEXTURE_IMAGE_UNITS_EXT, 16},
{GL_MAX_GEOMETRY_ATOMIC_COUNTER_BUFFERS_EXT, 0},
{GL_MAX_GEOMETRY_ATOMIC_COUNTERS_EXT, 0},
{GL_MAX_GEOMETRY_SHADER_STORAGE_BLOCKS_EXT, 0},
{GL_MAX_GEOMETRY_IMAGE_UNIFORMS_EXT, 0},
{GL_MAX_GEOMETRY_SHADER_INVOCATIONS_EXT, 32}};
GLint value;
for (const auto &limit : limits)
{
value = 0;
glGetIntegerv(limit.first, &value);
EXPECT_GL_NO_ERROR();
EXPECT_GE(value, limit.second);
}
value = 0;
glGetIntegerv(GL_LAYER_PROVOKING_VERTEX_EXT, &value);
EXPECT_GL_NO_ERROR();
EXPECT_TRUE(value == GL_FIRST_VERTEX_CONVENTION_EXT || value == GL_LAST_VERTEX_CONVENTION_EXT ||
value == GL_UNDEFINED_VERTEX_EXT);
}
// Verify that all the combined resource limits meet the requirement of GL_EXT_geometry_shader SPEC.
TEST_P(GeometryShaderTest, CombinedResourceLimits)
{
ANGLE_SKIP_TEST_IF(!extensionEnabled("GL_EXT_geometry_shader"));
// See http://anglebug.com/2261.
ANGLE_SKIP_TEST_IF(IsAndroid());
const std::map<GLenum, int> limits = {{GL_MAX_UNIFORM_BUFFER_BINDINGS, 48},
{GL_MAX_COMBINED_UNIFORM_BLOCKS, 36},
{GL_MAX_COMBINED_TEXTURE_IMAGE_UNITS, 64}};
GLint value;
for (const auto &limit : limits)
{
value = 0;
glGetIntegerv(limit.first, &value);
EXPECT_GL_NO_ERROR();
EXPECT_GE(value, limit.second);
}
}
// Verify that linking a program with an uncompiled geometry shader causes a link failure.
TEST_P(GeometryShaderTest, LinkWithUncompiledGeoemtryShader)
{
ANGLE_SKIP_TEST_IF(!extensionEnabled("GL_EXT_geometry_shader"));
GLuint vertexShader = CompileShader(GL_VERTEX_SHADER, kDefaultVertexShader);
GLuint fragmentShader = CompileShader(GL_FRAGMENT_SHADER, kDefaultFragmentShader);
ASSERT_NE(0u, vertexShader);
ASSERT_NE(0u, fragmentShader);
GLuint geometryShader = glCreateShader(GL_GEOMETRY_SHADER_EXT);
GLuint program = glCreateProgram();
glAttachShader(program, vertexShader);
glAttachShader(program, fragmentShader);
glAttachShader(program, geometryShader);
glDeleteShader(vertexShader);
glDeleteShader(fragmentShader);
glDeleteShader(geometryShader);
glLinkProgram(program);
GLint linkStatus;
glGetProgramiv(program, GL_LINK_STATUS, &linkStatus);
EXPECT_EQ(0, linkStatus);
glDeleteProgram(program);
ASSERT_GL_NO_ERROR();
}
// Verify that linking a program with geometry shader whose version is different from other shaders
// in this program causes a link error.
TEST_P(GeometryShaderTest, LinkWhenShaderVersionMismatch)
{
ANGLE_SKIP_TEST_IF(!extensionEnabled("GL_EXT_geometry_shader"));
const std::string &kDefaultVertexShaderVersion300 =
R"(#version 300 es
void main()
{
gl_Position = vec4(1.0, 0.0, 0.0, 1.0);
})";
const std::string kDefaultFragmentShaderVersion300 =
R"(#version 300 es
precision mediump float;
layout (location = 0) out vec4 frag_out;
void main()
{
frag_out = vec4(1.0, 0.0, 0.0, 1.0);
})";
const std::string &emptyGeometryShader = CreateEmptyGeometryShader("points", "points", 2, 1);
GLuint program = CompileProgramWithGS(kDefaultVertexShaderVersion300, emptyGeometryShader,
kDefaultFragmentShaderVersion300);
EXPECT_EQ(0u, program);
}
// Verify that linking a program with geometry shader that lacks input primitive,
// output primitive, or declaration on 'max_vertices' causes a link failure.
TEST_P(GeometryShaderTest, LinkValidationOnGeometryShaderLayouts)
{
ANGLE_SKIP_TEST_IF(!extensionEnabled("GL_EXT_geometry_shader"));
const std::string &gsWithoutInputPrimitive = CreateEmptyGeometryShader("", "points", 2, 1);
const std::string &gsWithoutOutputPrimitive = CreateEmptyGeometryShader("points", "", 2, 1);
const std::string &gsWithoutInvocations = CreateEmptyGeometryShader("points", "points", -1, 1);
const std::string &gsWithoutMaxVertices = CreateEmptyGeometryShader("points", "points", 2, -1);
// Linking a program with a geometry shader that only lacks 'invocations' should not cause a
// link failure.
GLuint program =
CompileProgramWithGS(kDefaultVertexShader, gsWithoutInvocations, kDefaultFragmentShader);
EXPECT_NE(0u, program);
glDeleteProgram(program);
// Linking a program with a geometry shader that lacks input primitive, output primitive or
// 'max_vertices' causes a link failure.
program =
CompileProgramWithGS(kDefaultVertexShader, gsWithoutInputPrimitive, kDefaultFragmentShader);
EXPECT_EQ(0u, program);
program = CompileProgramWithGS(kDefaultVertexShader, gsWithoutOutputPrimitive,
kDefaultFragmentShader);
EXPECT_EQ(0u, program);
program =
CompileProgramWithGS(kDefaultVertexShader, gsWithoutMaxVertices, kDefaultFragmentShader);
EXPECT_EQ(0u, program);
ASSERT_GL_NO_ERROR();
}
// Verify that an link error occurs when the vertex shader has an array output and there is a
// geometry shader in the program.
TEST_P(GeometryShaderTest, VertexShaderArrayOutput)
{
ANGLE_SKIP_TEST_IF(!extensionEnabled("GL_EXT_geometry_shader"));
const std::string &vertexShader =
R"(#version 310 es
in vec4 vertex_in;
out vec4 vertex_out[3];
void main()
{
gl_Position = vertex_in;
vertex_out[0] = vec4(1.0, 0.0, 0.0, 1.0);
vertex_out[1] = vec4(0.0, 1.0, 0.0, 1.0);
vertex_out[2] = vec4(0.0, 0.0, 1.0, 1.0);
})";
const std::string &geometryShader =
R"(#version 310 es
#extension GL_EXT_geometry_shader : require
layout (invocations = 3, triangles) in;
layout (points, max_vertices = 3) out;
in vec4 vertex_out[];
out vec4 geometry_color;
void main()
{
gl_Position = gl_in[0].gl_Position;
geometry_color = vertex_out[0];
EmitVertex();
})";
const std::string &fragmentShader =
R"(#version 310 es
precision mediump float;
in vec4 geometry_color;
layout (location = 0) out vec4 output_color;
void main()
{
output_color = geometry_color;
})";
GLuint program = CompileProgramWithGS(vertexShader, geometryShader, fragmentShader);
EXPECT_EQ(0u, program);
EXPECT_GL_NO_ERROR();
}
// Verify that an link error occurs when the definition of a unform in fragment shader is different
// from those in a geometry shader.
TEST_P(GeometryShaderTest, UniformMismatchBetweenGeometryAndFragmentShader)
{
ANGLE_SKIP_TEST_IF(!extensionEnabled("GL_EXT_geometry_shader"));
const std::string &vertexShader =
R"(#version 310 es
uniform highp vec4 uniform_value_vert;
in vec4 vertex_in;
out vec4 vertex_out;
void main()
{
gl_Position = vertex_in;
vertex_out = uniform_value_vert;
})";
const std::string &geometryShader =
R"(#version 310 es
#extension GL_EXT_geometry_shader : require
uniform vec4 uniform_value;
layout (invocations = 3, triangles) in;
layout (points, max_vertices = 3) out;
in vec4 vertex_out[];
out vec4 geometry_color;
void main()
{
gl_Position = gl_in[0].gl_Position;
geometry_color = vertex_out[0] + uniform_value;
EmitVertex();
})";
const std::string &fragmentShader =
R"(#version 310 es
precision highp float;
uniform float uniform_value;
in vec4 geometry_color;
layout (location = 0) out vec4 output_color;
void main()
{
output_color = vec4(geometry_color.rgb, uniform_value);
})";
GLuint program = CompileProgramWithGS(vertexShader, geometryShader, fragmentShader);
EXPECT_EQ(0u, program);
EXPECT_GL_NO_ERROR();
}
// Verify that an link error occurs when the number of uniform blocks in a geometry shader exceeds
// MAX_GEOMETRY_UNIFORM_BLOCKS_EXT.
TEST_P(GeometryShaderTest, TooManyUniformBlocks)
{
ANGLE_SKIP_TEST_IF(!extensionEnabled("GL_EXT_geometry_shader"));
GLint maxGeometryUniformBlocks = 0;
glGetIntegerv(GL_MAX_GEOMETRY_UNIFORM_BLOCKS_EXT, &maxGeometryUniformBlocks);
GLint numUniformBlocks = maxGeometryUniformBlocks + 1;
std::ostringstream stream;
stream << "#version 310 es\n"
"#extension GL_EXT_geometry_shader : require\n"
"uniform ubo\n"
"{\n"
" vec4 value1;\n"
"} block0["
<< numUniformBlocks
<< "];\n"
"layout (triangles) in;\n"
"layout (points, max_vertices = 1) out;\n"
"void main()\n"
"{\n"
" gl_Position = gl_in[0].gl_Position;\n";
for (GLint i = 0; i < numUniformBlocks; ++i)
{
stream << " gl_Position += block0[" << i << "].value1;\n";
}
stream << " EmitVertex();\n"
"}\n";
GLuint program =
CompileProgramWithGS(kDefaultVertexShader, stream.str(), kDefaultFragmentShader);
EXPECT_EQ(0u, program);
EXPECT_GL_NO_ERROR();
}
// Verify that an link error occurs when the number of shader storage blocks in a geometry shader
// exceeds MAX_GEOMETRY_SHADER_STORAGE_BLOCKS_EXT.
TEST_P(GeometryShaderTest, TooManyShaderStorageBlocks)
{
ANGLE_SKIP_TEST_IF(!extensionEnabled("GL_EXT_geometry_shader"));
GLint maxGeometryShaderStorageBlocks = 0;
glGetIntegerv(GL_MAX_GEOMETRY_SHADER_STORAGE_BLOCKS_EXT, &maxGeometryShaderStorageBlocks);
GLint numSSBOs = maxGeometryShaderStorageBlocks + 1;
std::ostringstream stream;
stream << "#version 310 es\n"
"#extension GL_EXT_geometry_shader : require\n"
"buffer ssbo\n"
"{\n"
" vec4 value1;\n"
"} block0["
<< numSSBOs
<< "];\n"
"layout (triangles) in;\n"
"layout (points, max_vertices = 1) out;\n"
"void main()\n"
"{\n"
" gl_Position = gl_in[0].gl_Position;\n";
for (GLint i = 0; i < numSSBOs; ++i)
{
stream << " gl_Position += block0[" << i << "].value1;\n";
}
stream << " EmitVertex();\n"
"}\n";
GLuint program =
CompileProgramWithGS(kDefaultVertexShader, stream.str(), kDefaultFragmentShader);
EXPECT_EQ(0u, program);
EXPECT_GL_NO_ERROR();
}
ANGLE_INSTANTIATE_TEST(GeometryShaderTestES3, ES3_OPENGL(), ES3_OPENGLES(), ES3_D3D11());
ANGLE_INSTANTIATE_TEST(GeometryShaderTest, ES31_OPENGL(), ES31_OPENGLES(), ES31_D3D11());
}