kc3-lang/angle/src/compiler/translator/ConstantUnion.h

Branch : - branch - main - tag -

• Show log

  Commit

• Author : Olli Etuaho
  Date : 2017-07-10 14:16:33
  Hash : 56229f1b
  Message : Remove TIntermediate::addConstantUnion This includes asserts in TConstantUnion to reveal incorrect usage of union - reading a different field of an union that has last been set is undefined behavior in C++. Existing issues with accessing incorrect fields of constant unions are fixed. BUG=angleproject:1490 TEST=angle_unittests Change-Id: Idd6b7a871d73e2928f117a9348c92043612fab82

• src/compiler/translator/ConstantUnion.h

• //
  // Copyright (c) 2002-2014 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  
  #ifndef COMPILER_TRANSLATOR_CONSTANTUNION_H_
  #define COMPILER_TRANSLATOR_CONSTANTUNION_H_
  
  #include <assert.h>
  
  #include "compiler/translator/Common.h"
  #include "compiler/translator/BaseTypes.h"
  
  namespace sh
  {
  
  class TDiagnostics;
  
  class TConstantUnion
  {
    public:
      POOL_ALLOCATOR_NEW_DELETE();
      TConstantUnion();
  
      bool cast(TBasicType newType, const TConstantUnion &constant);
  
      void setIConst(int i)
      {
          iConst = i;
          type   = EbtInt;
      }
      void setUConst(unsigned int u)
      {
          uConst = u;
          type   = EbtUInt;
      }
      void setFConst(float f)
      {
          fConst = f;
          type   = EbtFloat;
      }
      void setBConst(bool b)
      {
          bConst = b;
          type   = EbtBool;
      }
  
      void setYuvCscStandardEXTConst(TYuvCscStandardEXT s)
      {
          yuvCscStandardEXTConst = s;
          type                   = EbtYuvCscStandardEXT;
      }
  
      int getIConst() const;
      unsigned int getUConst() const;
      float getFConst() const;
      bool getBConst() const;
      TYuvCscStandardEXT getYuvCscStandardEXTConst() const;
  
      bool operator==(const int i) const;
      bool operator==(const unsigned int u) const;
      bool operator==(const float f) const;
      bool operator==(const bool b) const;
      bool operator==(const TYuvCscStandardEXT s) const;
      bool operator==(const TConstantUnion &constant) const;
      bool operator!=(const int i) const;
      bool operator!=(const unsigned int u) const;
      bool operator!=(const float f) const;
      bool operator!=(const bool b) const;
      bool operator!=(const TYuvCscStandardEXT s) const;
      bool operator!=(const TConstantUnion &constant) const;
      bool operator>(const TConstantUnion &constant) const;
      bool operator<(const TConstantUnion &constant) const;
      static TConstantUnion add(const TConstantUnion &lhs,
                                const TConstantUnion &rhs,
                                TDiagnostics *diag,
                                const TSourceLoc &line);
      static TConstantUnion sub(const TConstantUnion &lhs,
                                const TConstantUnion &rhs,
                                TDiagnostics *diag,
                                const TSourceLoc &line);
      static TConstantUnion mul(const TConstantUnion &lhs,
                                const TConstantUnion &rhs,
                                TDiagnostics *diag,
                                const TSourceLoc &line);
      TConstantUnion operator%(const TConstantUnion &constant) const;
      static TConstantUnion rshift(const TConstantUnion &lhs,
                                   const TConstantUnion &rhs,
                                   TDiagnostics *diag,
                                   const TSourceLoc &line);
      static TConstantUnion lshift(const TConstantUnion &lhs,
                                   const TConstantUnion &rhs,
                                   TDiagnostics *diag,
                                   const TSourceLoc &line);
      TConstantUnion operator&(const TConstantUnion &constant) const;
      TConstantUnion operator|(const TConstantUnion &constant) const;
      TConstantUnion operator^(const TConstantUnion &constant) const;
      TConstantUnion operator&&(const TConstantUnion &constant) const;
      TConstantUnion operator||(const TConstantUnion &constant) const;
  
      TBasicType getType() const { return type; }
    private:
      union {
          int iConst;           // used for ivec, scalar ints
          unsigned int uConst;  // used for uvec, scalar uints
          bool bConst;          // used for bvec, scalar bools
          float fConst;         // used for vec, mat, scalar floats
          TYuvCscStandardEXT yuvCscStandardEXTConst;
      };
  
      TBasicType type;
  };
  
  }  // namespace sh
  
  #endif  // COMPILER_TRANSLATOR_CONSTANTUNION_H_