-
Show log
Commit
-
Hash : 346ba328
Author :
Date : 2024-07-30T11:42:12
Vulkan: Simplify pulling samplers out of structs The RewriteStructSampler transformation moves samplers out of structs, for example turning this struct: struct Original { sampler2D s1; vec4 f1; sampler2D s2; sampler2D s3; vec4 f2; }; into: struct Modified { vec4 f1; vec4 f2; }; This required modifying the struct-field selection nodes to remap the field indices, causing some complication. Instead, this change makes the struct definition reorder the fields as such right during parse: struct Original { vec4 f1; vec4 f2; sampler2D s1; sampler2D s2; sampler2D s3; }; As a result, the field-selection indices for non-sampler fields don't get changed when the struct is replaced with `Modified`. Bug: angleproject:42262842 Bug: angleproject:349994211 Change-Id: I76986eab780689e9887b094e3c70b87887a8ec92 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5748789 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
-
Files
- ClampFragDepth.cpp
- ClampFragDepth.h
- ClampIndirectIndices.cpp
- ClampIndirectIndices.h
- ClampPointSize.cpp
- ClampPointSize.h
- DeclareAndInitBuiltinsForInstancedMultiview.cpp
- DeclareAndInitBuiltinsForInstancedMultiview.h
- DeclarePerVertexBlocks.cpp
- DeclarePerVertexBlocks.h
- DeferGlobalInitializers.cpp
- DeferGlobalInitializers.h
- EmulateGLFragColorBroadcast.cpp
- EmulateGLFragColorBroadcast.h
- EmulateMultiDrawShaderBuiltins.cpp
- EmulateMultiDrawShaderBuiltins.h
- FoldExpressions.cpp
- FoldExpressions.h
- ForcePrecisionQualifier.cpp
- ForcePrecisionQualifier.h
- InitializeVariables.cpp
- InitializeVariables.h
- MonomorphizeUnsupportedFunctions.cpp
- MonomorphizeUnsupportedFunctions.h
- PreTransformTextureCubeGradDerivatives.cpp
- PreTransformTextureCubeGradDerivatives.h
- PruneEmptyCases.cpp
- PruneEmptyCases.h
- PruneInfiniteLoops.cpp
- PruneInfiniteLoops.h
- PruneNoOps.cpp
- PruneNoOps.h
- RecordConstantPrecision.cpp
- RecordConstantPrecision.h
- RemoveArrayLengthMethod.cpp
- RemoveArrayLengthMethod.h
- RemoveAtomicCounterBuiltins.cpp
- RemoveAtomicCounterBuiltins.h
- RemoveDynamicIndexing.cpp
- RemoveDynamicIndexing.h
- RemoveInactiveInterfaceVariables.cpp
- RemoveInactiveInterfaceVariables.h
- RemoveInvariantDeclaration.cpp
- RemoveInvariantDeclaration.h
- RemoveUnreferencedVariables.cpp
- RemoveUnreferencedVariables.h
- RescopeGlobalVariables.cpp
- RescopeGlobalVariables.h
- RewriteArrayOfArrayOfOpaqueUniforms.cpp
- RewriteArrayOfArrayOfOpaqueUniforms.h
- RewriteAtomicCounters.cpp
- RewriteAtomicCounters.h
- RewriteDfdy.cpp
- RewriteDfdy.h
- RewritePixelLocalStorage.cpp
- RewritePixelLocalStorage.h
- RewriteStructSamplers.cpp
- RewriteStructSamplers.h
- RewriteTexelFetchOffset.cpp
- RewriteTexelFetchOffset.h
- SeparateDeclarations.cpp
- SeparateDeclarations.h
- SeparateStructFromFunctionDeclarations.cpp
- SeparateStructFromFunctionDeclarations.h
- SeparateStructFromUniformDeclarations.cpp
- SeparateStructFromUniformDeclarations.h
- SimplifyLoopConditions.cpp
- SimplifyLoopConditions.h
- SplitSequenceOperator.cpp
- SplitSequenceOperator.h
- glsl/
- hlsl/
- msl/
- spirv/
