kc3-lang/angle/src/compiler/translator/RewriteTexelFetchOffset.cpp

• Show log

  Commit

• Hash : fe48632f
  Author :
  Date : 2017-03-21T09:30:54
  

  Prefer identifying functions by using symbol ids
  
  The shader translator code is now structured in a way that ensures
  that all function definition, function prototype and function call
  nodes store the integer symbol id for the function. This is guaranteed
  regardless of whether the function node is added while parsing or as a
  result of an AST transformation. TIntermAggregate nodes, which include
  function calls and constructors can now only be created by calling one
  of the TIntermAggregate::Create*() functions to ensure they have all
  the necessary properties.
  
  This makes it possible to keep track of functions using integer ids
  instead of their mangled name strings when generating the call graph
  and when using TLValueTrackingTraverser.
  
  This commit includes a few other small cleanups to the CallDAG class
  as well.
  
  BUG=angleproject:1490
  TEST=angle_unittests, angle_end2end_tests
  
  Change-Id: Idd1013506cbe4c3380e20d90524a9cd09b890259
  Reviewed-on: https://chromium-review.googlesource.com/459603
  Reviewed-by: Corentin Wallez <cwallez@chromium.org>
  Reviewed-by: Geoff Lang <geofflang@chromium.org>
  Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
  

Download

• src/compiler/translator/RewriteTexelFetchOffset.cpp

• //
  // Copyright (c) 2016 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  // Implementation of texelFetchOffset translation issue workaround.
  // See header for more info.
  
  #include "compiler/translator/RewriteTexelFetchOffset.h"
  
  #include "common/angleutils.h"
  #include "compiler/translator/IntermNode.h"
  #include "compiler/translator/SymbolTable.h"
  
  namespace sh
  {
  
  namespace
  {
  
  class Traverser : public TIntermTraverser
  {
    public:
      static void Apply(TIntermNode *root, const TSymbolTable &symbolTable, int shaderVersion);
  
    private:
      Traverser(const TSymbolTable &symbolTable, int shaderVersion);
      bool visitAggregate(Visit visit, TIntermAggregate *node) override;
      void nextIteration();
  
      const TSymbolTable *symbolTable;
      const int shaderVersion;
      bool mFound = false;
  };
  
  Traverser::Traverser(const TSymbolTable &symbolTable, int shaderVersion)
      : TIntermTraverser(true, false, false), symbolTable(&symbolTable), shaderVersion(shaderVersion)
  {
  }
  
  // static
  void Traverser::Apply(TIntermNode *root, const TSymbolTable &symbolTable, int shaderVersion)
  {
      Traverser traverser(symbolTable, shaderVersion);
      do
      {
          traverser.nextIteration();
          root->traverse(&traverser);
          if (traverser.mFound)
          {
              traverser.updateTree();
          }
      } while (traverser.mFound);
  }
  
  void Traverser::nextIteration()
  {
      mFound = false;
  }
  
  bool Traverser::visitAggregate(Visit visit, TIntermAggregate *node)
  {
      if (mFound)
      {
          return false;
      }
  
      // Decide if the node represents the call of texelFetchOffset.
      if (node->getOp() != EOpCallBuiltInFunction)
      {
          return true;
      }
  
      if (node->getFunctionSymbolInfo()->getName().compare(0, 16, "texelFetchOffset") != 0)
      {
          return true;
      }
  
      // Potential problem case detected, apply workaround.
      const TIntermSequence *sequence = node->getSequence();
      ASSERT(sequence->size() == 4u);
  
      // Decide if there is a 2DArray sampler.
      bool is2DArray = node->getFunctionSymbolInfo()->getName().find("s2a1") != TString::npos;
  
      // Create new argument list from node->getName().
      // e.g. Get "(is2a1;vi3;i1;" from "texelFetchOffset(is2a1;vi3;i1;vi2;"
      TString newArgs = node->getFunctionSymbolInfo()->getName().substr(
          16, node->getFunctionSymbolInfo()->getName().length() - 20);
      TString newName           = "texelFetch" + newArgs;
      TSymbol *texelFetchSymbol = symbolTable->findBuiltIn(newName, shaderVersion);
      ASSERT(texelFetchSymbol && texelFetchSymbol->isFunction());
  
      // Create new node that represents the call of function texelFetch.
      // Its argument list will be: texelFetch(sampler, Position+offset, lod).
  
      TIntermSequence *texelFetchArguments = new TIntermSequence();
  
      // sampler
      texelFetchArguments->push_back(sequence->at(0));
  
      // Position
      TIntermTyped *texCoordNode = sequence->at(1)->getAsTyped();
      ASSERT(texCoordNode);
  
      // offset
      TIntermTyped *offsetNode = nullptr;
      ASSERT(sequence->at(3)->getAsTyped());
      if (is2DArray)
      {
          // For 2DArray samplers, Position is ivec3 and offset is ivec2;
          // So offset must be converted into an ivec3 before being added to Position.
          TIntermSequence *constructOffsetIvecArguments = new TIntermSequence();
          constructOffsetIvecArguments->push_back(sequence->at(3)->getAsTyped());
  
          TIntermTyped *zeroNode = TIntermTyped::CreateZero(TType(EbtInt));
          constructOffsetIvecArguments->push_back(zeroNode);
  
          offsetNode = TIntermAggregate::CreateConstructor(texCoordNode->getType(), EOpConstructIVec3,
                                                           constructOffsetIvecArguments);
          offsetNode->setLine(texCoordNode->getLine());
      }
      else
      {
          offsetNode = sequence->at(3)->getAsTyped();
      }
  
      // Position+offset
      TIntermBinary *add = new TIntermBinary(EOpAdd, texCoordNode, offsetNode);
      add->setLine(texCoordNode->getLine());
      texelFetchArguments->push_back(add);
  
      // lod
      texelFetchArguments->push_back(sequence->at(2));
  
      ASSERT(texelFetchArguments->size() == 3u);
  
      TIntermAggregate *texelFetchNode = TIntermAggregate::CreateBuiltInFunctionCall(
          *static_cast<const TFunction *>(texelFetchSymbol), texelFetchArguments);
      texelFetchNode->setLine(node->getLine());
  
      // Replace the old node by this new node.
      queueReplacement(node, texelFetchNode, OriginalNode::IS_DROPPED);
      mFound = true;
      return false;
  }
  
  }  // anonymous namespace
  
  void RewriteTexelFetchOffset(TIntermNode *root, const TSymbolTable &symbolTable, int shaderVersion)
  {
      // texelFetchOffset is only valid in GLSL 3.0 and later.
      if (shaderVersion < 300)
          return;
  
      Traverser::Apply(root, symbolTable, shaderVersion);
  }
  
  }  // namespace sh

Download