kc3-lang/angle/src/tests/compiler_tests/WEBGL_multiview_test.cpp
-
Show log
Commit
-
Hash : 1d9dcc24
Author :
Date : 2017-01-19T11:25:32
Make AST path always include the current node being traversed AST traversers tend to sometimes call traverse() functions manually during PreVisit. Change TIntermTraverser so that even if this happens, all the nodes are automatically added to the traversal path, instead of having to add them manually in each individual AST traverser. This also makes calling getParentNode() return the correct node during InVisit. This does cause the same node being added to the traversal path twice in some cases, where nodes are repeatedly traversed, like in OutputHLSL, but this should not have adverse side effects. The more common case is that the traverse() function is called on the children of the node being currently traversed. This fixes a bug in OVR_multiview validation, which did not previously call incrementDepth and decrementDepth when it should have. BUG=angleproject:1725 TEST=angle_unittests, angle_end2end_tests Change-Id: I6ae762eef760509ebe853eefa37dac28c16e7a9b Reviewed-on: https://chromium-review.googlesource.com/430732 Commit-Queue: Olli Etuaho <oetuaho@nvidia.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
-
src/tests/compiler_tests/WEBGL_multiview_test.cpp
-
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399
// // Copyright (c) 2016 The ANGLE Project Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. // // WEBGL_multiview_test.cpp: // Test that shaders with gl_ViewID_OVR are validated correctly. // #include "angle_gl.h" #include "gtest/gtest.h" #include "GLSLANG/ShaderLang.h" #include "tests/test_utils/ShaderCompileTreeTest.h" using namespace sh; class WEBGLMultiviewVertexShaderTest : public ShaderCompileTreeTest { public: WEBGLMultiviewVertexShaderTest() {} protected: ::GLenum getShaderType() const override { return GL_VERTEX_SHADER; } ShShaderSpec getShaderSpec() const override { return SH_WEBGL3_SPEC; } void initResources(ShBuiltInResources *resources) override { resources->OVR_multiview = 1; resources->MaxViewsOVR = 4; } }; class WEBGLMultiviewFragmentShaderTest : public ShaderCompileTreeTest { public: WEBGLMultiviewFragmentShaderTest() {} protected: ::GLenum getShaderType() const override { return GL_FRAGMENT_SHADER; } ShShaderSpec getShaderSpec() const override { return SH_WEBGL3_SPEC; } void initResources(ShBuiltInResources *resources) override { resources->OVR_multiview = 1; resources->MaxViewsOVR = 4; } }; // Invalid combination of extensions (restricted in the WEBGL_multiview spec). TEST_F(WEBGLMultiviewVertexShaderTest, InvalidBothMultiviewAndMultiview2) { const std::string &shaderString = "#version 300 es\n" "#extension GL_OVR_multiview : require\n" "#extension GL_OVR_multiview2 : enable\n" "layout(num_views = 2) in;\n" "void main()\n" "{\n" " gl_Position.x = (gl_ViewID_OVR == 0u) ? 1.0 : 0.0;\n" " gl_Position.yzw = vec3(0, 0, 1);\n" "}\n"; if (compile(shaderString)) { FAIL() << "Shader compilation succeeded, expecting failure:\n" << mInfoLog; } } // Invalid combination of non-matching num_views declarations. TEST_F(WEBGLMultiviewVertexShaderTest, InvalidNumViewsMismatch) { const std::string &shaderString = "#version 300 es\n" "#extension GL_OVR_multiview2 : require\n" "layout(num_views = 2) in;\n" "layout(num_views = 1) in;\n" "void main()\n" "{\n" " gl_Position.x = (gl_ViewID_OVR == 0u) ? 1.0 : 0.0;\n" " gl_Position.yzw = vec3(0, 0, 1);\n" "}\n"; if (compile(shaderString)) { FAIL() << "Shader compilation succeeded, expecting failure:\n" << mInfoLog; } } // Invalid value zero for num_views. TEST_F(WEBGLMultiviewVertexShaderTest, InvalidNumViewsZero) { const std::string &shaderString = "#version 300 es\n" "#extension GL_OVR_multiview2 : require\n" "layout(num_views = 0) in;\n" "void main()\n" "{\n" " gl_Position.x = (gl_ViewID_OVR == 0u) ? 1.0 : 0.0;\n" " gl_Position.yzw = vec3(0, 0, 1);\n" "}\n"; if (compile(shaderString)) { FAIL() << "Shader compilation succeeded, expecting failure:\n" << mInfoLog; } } // Too large value for num_views. TEST_F(WEBGLMultiviewVertexShaderTest, InvalidNumViewsGreaterThanMax) { const std::string &shaderString = "#version 300 es\n" "#extension GL_OVR_multiview2 : require\n" "layout(num_views = 5) in;\n" "void main()\n" "{\n" " gl_Position.x = (gl_ViewID_OVR == 0u) ? 1.0 : 0.0;\n" " gl_Position.yzw = vec3(0, 0, 1);\n" "}\n"; if (compile(shaderString)) { FAIL() << "Shader compilation succeeded, expecting failure:\n" << mInfoLog; } } // Valid use of gl_ViewID_OVR in a ternary operator. TEST_F(WEBGLMultiviewVertexShaderTest, ValidViewIDInTernary) { const std::string &shaderString = "#version 300 es\n" "#extension GL_OVR_multiview : require\n" "layout(num_views = 2) in;\n" "layout(num_views = 2) in; // Duplicated on purpose\n" "void main()\n" "{\n" " gl_Position.x = (gl_ViewID_OVR == 0u) ? 1.0 : 0.0;\n" " gl_Position.yzw = vec3(0, 0, 1);\n" "}\n"; if (!compile(shaderString)) { FAIL() << "Shader compilation failed, expecting success:\n" << mInfoLog; } } // Valid use of gl_ViewID_OVR in an if statement. TEST_F(WEBGLMultiviewVertexShaderTest, ValidViewIDInIf) { const std::string &shaderString = "#version 300 es\n" "#extension GL_OVR_multiview : require\n" "layout(num_views = 2) in;\n" "void main()\n" "{\n" " if (gl_ViewID_OVR == 0u)\n" " {\n" " gl_Position.x = 1.0;\n" " }\n" " else\n" " {\n" " gl_Position.x = 1.0;\n" " }\n" " gl_Position.yzw = vec3(0, 0, 1);\n" "}\n"; if (!compile(shaderString)) { FAIL() << "Shader compilation failed, expecting success:\n" << mInfoLog; } } // Valid normal write of gl_Position in addition to the write that's dependent on gl_ViewID_OVR. TEST_F(WEBGLMultiviewVertexShaderTest, ValidWriteOfGlPosition) { const std::string &shaderString = "#version 300 es\n" "#extension GL_OVR_multiview : require\n" "layout(num_views = 2) in;\n" "void main()\n" "{\n" " if (0u == gl_ViewID_OVR)\n" " {\n" " gl_Position.x = 1.0;\n" " }\n" " else\n" " {\n" " gl_Position.x = 1.0;\n" " }\n" " gl_Position = vec4(1, 1, 1, 1);\n" "}\n"; if (!compile(shaderString)) { FAIL() << "Shader compilation failed, expecting success:\n" << mInfoLog; } } // Invalid assignment to gl_Position.y inside if dependent on gl_ViewID_OVR. TEST_F(WEBGLMultiviewVertexShaderTest, InvalidGlPositionAssignmentInIf) { const std::string &shaderString = "#version 300 es\n" "#extension GL_OVR_multiview : require\n" "layout(num_views = 2) in;\n" "void main()\n" "{\n" " if (gl_ViewID_OVR == 0u)\n" " {\n" " gl_Position.y = 1.0;\n" " }\n" " else\n" " {\n" " gl_Position.y = 1.0;\n" " }\n" " gl_Position.xzw = vec3(0, 0, 1);\n" "}\n"; if (compile(shaderString)) { FAIL() << "Shader compilation succeeded, expecting failure:\n" << mInfoLog; } } // Invalid multiple assignments inside if dependent on gl_ViewID_OVR. TEST_F(WEBGLMultiviewVertexShaderTest, InvalidMultipleGlPositionXAssignmentsInIf) { const std::string &shaderString = "#version 300 es\n" "#extension GL_OVR_multiview : require\n" "layout(num_views = 2) in;\n" "void main()\n" "{\n" " if (gl_ViewID_OVR == 0u)\n" " {\n" " gl_Position.x = 1.0;\n" " gl_Position.x = 2.0;\n" " }\n" " else\n" " {\n" " gl_Position.x = 1.0;\n" " }\n" " gl_Position.yzw = vec3(0, 0, 1);\n" "}\n"; if (compile(shaderString)) { FAIL() << "Shader compilation succeeded, expecting failure:\n" << mInfoLog; } } // Invalid read of gl_Position TEST_F(WEBGLMultiviewVertexShaderTest, InvalidReadOfGlPosition) { const std::string &shaderString = "#version 300 es\n" "#extension GL_OVR_multiview : require\n" "layout(num_views = 2) in;\n" "void main()\n" "{\n" " if (gl_ViewID_OVR == 0u) {\n" " gl_Position.x = 1.0;\n" " } else {\n" " gl_Position.x = 1.0;\n" " }\n" " gl_Position.yzw = vec3(0, 0, 1);\n" " float f = gl_Position.y;\n" "}\n"; if (compile(shaderString)) { FAIL() << "Shader compilation succeeded, expecting failure:\n" << mInfoLog; } } // Read gl_Position when the shader does not refer to gl_ViewID_OVR. TEST_F(WEBGLMultiviewVertexShaderTest, ValidReadOfGlPosition) { const std::string &shaderString = "#version 300 es\n" "#extension GL_OVR_multiview : require\n" "layout(num_views = 2) in;\n" "uniform float u;\n" "void main()\n" "{\n" " gl_Position = vec4(0, 0, 0, 1);\n" " gl_Position.y = gl_Position.x * u;\n" "}\n"; if (!compile(shaderString)) { FAIL() << "Shader compilation failed, expecting success:\n" << mInfoLog; } } // Read gl_FragCoord in a OVR_multiview fragment shader. TEST_F(WEBGLMultiviewFragmentShaderTest, InvalidReadOfFragCoord) { const std::string &shaderString = "#version 300 es\n" "#extension GL_OVR_multiview : require\n" "precision highp float;\n" "out vec4 outColor;\n" "void main()\n" "{\n" " outColor = vec4(gl_FragCoord.xy, 0, 1);\n" "}\n"; if (compile(shaderString)) { FAIL() << "Shader compilation succeeded, expecting failure:\n" << mInfoLog; } } // Read gl_ViewID_OVR in an OVR_multiview fragment shader. TEST_F(WEBGLMultiviewFragmentShaderTest, InvalidReadOfViewID) { const std::string &shaderString = "#version 300 es\n" "#extension GL_OVR_multiview : require\n" "precision highp float;\n" "out vec4 outColor;\n" "void main()\n" "{\n" " outColor = vec4(gl_ViewID_OVR, 0, 0, 1);\n" "}\n"; if (compile(shaderString)) { FAIL() << "Shader compilation succeeded, expecting failure:\n" << mInfoLog; } } // Tricky invalid read of view ID. TEST_F(WEBGLMultiviewVertexShaderTest, InvalidConsumingExpressionForAssignGLPositionX) { const std::string &shaderString = "#version 300 es\n" "#extension GL_OVR_multiview : require\n" "layout(num_views = 2) in;\n" "void main()\n" "{\n" " float f = (gl_Position.x = (gl_ViewID_OVR == 0u) ? 1.0 : 0.0);\n" " gl_Position.yzw = vec3(f, f, f);\n" "}\n"; if (compile(shaderString)) { FAIL() << "Shader compilation succeeded, expecting failure:\n" << mInfoLog; } } // Using the OVR_multiview2 extension directive lifts restrictions of OVR_multiview. TEST_F(WEBGLMultiviewVertexShaderTest, RestrictionsLiftedMultiview2) { const std::string &shaderString = "#version 300 es\n" "#extension GL_OVR_multiview2 : require\n" "layout(num_views = 2) in;\n" "out float out_f;\n" "void main()\n" "{\n" " if (gl_ViewID_OVR == 0u)\n" " {\n" " gl_Position.x = 1.0;\n" " gl_Position.x = 2.0;\n" " }\n" " else\n" " {\n" " gl_Position.x = 1.0;\n" " }\n" " gl_Position.yzw = vec3(0, 0, 1);\n" " gl_Position += vec4(1, 0, 0, 1);\n" " out_f = float(gl_ViewID_OVR * 2u);\n" "}\n"; if (!compile(shaderString)) { FAIL() << "Shader compilation failed, expecting success:\n" << mInfoLog; } } // Correct use of GL_OVR_multiview macros. TEST_F(WEBGLMultiviewVertexShaderTest, ValidUseOfExtensionMacros) { const std::string &shaderString = "#version 300 es\n" "#ifdef GL_OVR_multiview\n" "#ifdef GL_OVR_multiview2\n" "#if (GL_OVR_multiview == 1) && (GL_OVR_multiview2 == 1)\n" "void main()\n" "{\n" " gl_Position = vec4(0.0, 0.0, 0.0, 1.0);\n" "}\n" "#endif\n" "#endif\n" "#endif\n"; if (!compile(shaderString)) { FAIL() << "Shader compilation failed, expecting success:\n" << mInfoLog; } } // Test that the parent node is tracked correctly when validating assignment to gl_Position. TEST_F(WEBGLMultiviewVertexShaderTest, AssignmentWithViewIDInsideAssignment) { const std::string &shaderString = "#version 300 es\n" "#extension GL_OVR_multiview : require\n" "void main()\n" "{\n" " gl_Position.y = (gl_Position.x = (gl_ViewID_OVR == 0u) ? 1.0 : 0.0);\n" "}\n"; if (compile(shaderString)) { FAIL() << "Shader compilation succeeded, expecting failure:\n" << mInfoLog; } }