Hash :
3772d47e
Author :
Date :
2024-12-11T00:25:37
CL/Vulkan: Allocate descriptor sets under lock The descriptor pool must be externally synchronized as per the vulkan spec, as such acquire a lock when allocating descriptor sets from it. Bug: angleproject:383999367 Change-Id: I98448770681ad39dae0dc7e413e28ec7dfa89f87 Signed-off-by: Gowtham Tammana <g.tammana@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6099129 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159
//
// Copyright 2021 The ANGLE Project Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
// CLContextVk.h: Defines the class interface for CLContextVk, implementing CLContextImpl.
#ifndef LIBANGLE_RENDERER_VULKAN_CLCONTEXTVK_H_
#define LIBANGLE_RENDERER_VULKAN_CLCONTEXTVK_H_
#include "common/PackedEnums.h"
#include "common/SimpleMutex.h"
#include "libANGLE/renderer/vulkan/CLPlatformVk.h"
#include "libANGLE/renderer/vulkan/cl_types.h"
#include "libANGLE/renderer/vulkan/vk_cache_utils.h"
#include "libANGLE/renderer/vulkan/vk_helpers.h"
#include "libANGLE/renderer/vulkan/vk_utils.h"
#include "libANGLE/renderer/CLContextImpl.h"
#include <libANGLE/CLContext.h>
#include "libANGLE/CLDevice.h"
namespace rx
{
class CLKernelVk;
class CLContextVk : public CLContextImpl, public vk::Context
{
public:
CLContextVk(const cl::Context &context, const cl::DevicePtrs devicePtrs);
~CLContextVk() override;
void handleError(VkResult errorCode,
const char *file,
const char *function,
unsigned int line) override;
bool hasMemory(cl_mem memory) const;
angle::Result getDevices(cl::DevicePtrs *devicePtrsOut) const override;
angle::Result createCommandQueue(const cl::CommandQueue &commandQueue,
CLCommandQueueImpl::Ptr *commandQueueOut) override;
angle::Result createBuffer(const cl::Buffer &buffer,
void *hostPtr,
CLMemoryImpl::Ptr *bufferOut) override;
angle::Result createImage(const cl::Image &image,
void *hostPtr,
CLMemoryImpl::Ptr *imageOut) override;
angle::Result getSupportedImageFormats(cl::MemFlags flags,
cl::MemObjectType imageType,
cl_uint numEntries,
cl_image_format *imageFormats,
cl_uint *numImageFormats) override;
angle::Result createSampler(const cl::Sampler &sampler,
CLSamplerImpl::Ptr *samplerOut) override;
angle::Result createProgramWithSource(const cl::Program &program,
const std::string &source,
CLProgramImpl::Ptr *programOut) override;
angle::Result createProgramWithIL(const cl::Program &program,
const void *il,
size_t length,
CLProgramImpl::Ptr *programOut) override;
angle::Result createProgramWithBinary(const cl::Program &program,
const size_t *lengths,
const unsigned char **binaries,
cl_int *binaryStatus,
CLProgramImpl::Ptr *programOut) override;
angle::Result createProgramWithBuiltInKernels(const cl::Program &program,
const char *kernel_names,
CLProgramImpl::Ptr *programOut) override;
angle::Result linkProgram(const cl::Program &program,
const cl::DevicePtrs &devices,
const char *options,
const cl::ProgramPtrs &inputPrograms,
cl::Program *notify,
CLProgramImpl::Ptr *programOut) override;
angle::Result createUserEvent(const cl::Event &event, CLEventImpl::Ptr *eventOut) override;
angle::Result waitForEvents(const cl::EventPtrs &events) override;
CLPlatformVk *getPlatform() { return &mContext.getPlatform().getImpl<CLPlatformVk>(); }
cl::Context &getFrontendObject() { return const_cast<cl::Context &>(mContext); }
DescriptorSetLayoutCache *getDescriptorSetLayoutCache() { return &mDescriptorSetLayoutCache; }
PipelineLayoutCache *getPipelineLayoutCache() { return &mPipelineLayoutCache; }
vk::MetaDescriptorPool &getMetaDescriptorPool() { return mMetaDescriptorPool; }
angle::Result allocateDescriptorSet(
CLKernelVk *kernelVk,
DescriptorSetIndex index,
angle::EnumIterator<DescriptorSetIndex> layoutIndex,
vk::OutsideRenderPassCommandBufferHelper *computePassCommands);
private:
void handleDeviceLost() const;
VkFormat getVkFormatFromCL(cl_image_format format);
// mutex to synchronize the descriptor set allocations
angle::SimpleMutex mDescriptorSetMutex;
// Caches for DescriptorSetLayout and PipelineLayout
DescriptorSetLayoutCache mDescriptorSetLayoutCache;
PipelineLayoutCache mPipelineLayoutCache;
vk::MetaDescriptorPool mMetaDescriptorPool;
// Have the CL Context keep tabs on associated CL objects
struct Mutable
{
std::unordered_set<const _cl_mem *> mMemories;
};
using MutableData = angle::SynchronizedValue<Mutable>;
MutableData mAssociatedObjects;
const cl::DevicePtrs mAssociatedDevices;
// Table of minimum required image formats for OpenCL
static constexpr cl_image_format kMinSupportedFormatsReadOrWrite[11] = {
{CL_RGBA, CL_UNORM_INT8}, {CL_RGBA, CL_UNSIGNED_INT8}, {CL_RGBA, CL_SIGNED_INT8},
{CL_RGBA, CL_UNORM_INT16}, {CL_RGBA, CL_UNSIGNED_INT16}, {CL_RGBA, CL_SIGNED_INT16},
{CL_RGBA, CL_HALF_FLOAT}, {CL_RGBA, CL_UNSIGNED_INT32}, {CL_RGBA, CL_SIGNED_INT32},
{CL_RGBA, CL_FLOAT}, {CL_BGRA, CL_UNORM_INT8}};
static constexpr cl_image_format kMinSupportedFormatsReadAndWrite[18] = {
{CL_R, CL_UNORM_INT8}, {CL_R, CL_UNSIGNED_INT8}, {CL_R, CL_SIGNED_INT8},
{CL_R, CL_UNSIGNED_INT16}, {CL_R, CL_SIGNED_INT16}, {CL_R, CL_HALF_FLOAT},
{CL_R, CL_UNSIGNED_INT32}, {CL_R, CL_SIGNED_INT32}, {CL_R, CL_FLOAT},
{CL_RGBA, CL_UNORM_INT8}, {CL_RGBA, CL_UNSIGNED_INT8}, {CL_RGBA, CL_SIGNED_INT8},
{CL_RGBA, CL_UNSIGNED_INT16}, {CL_RGBA, CL_SIGNED_INT16}, {CL_RGBA, CL_HALF_FLOAT},
{CL_RGBA, CL_UNSIGNED_INT32}, {CL_RGBA, CL_SIGNED_INT32}, {CL_RGBA, CL_FLOAT}};
friend class CLMemoryVk;
};
inline bool CLContextVk::hasMemory(cl_mem memory) const
{
const auto data = mAssociatedObjects.synchronize();
return data->mMemories.find(memory) != data->mMemories.cend();
}
} // namespace rx
#endif // LIBANGLE_RENDERER_VULKAN_CLCONTEXTVK_H_