kc3-lang/angle/src/compiler/translator/tree_ops/RewriteInterpolateAtOffset.h

• Show log

  Commit

• Hash : 995493cc
  Author :
  Date : 2020-11-18T20:33:33
  

  Revert "Vulkan: Remove rotation related data from driver uniform"
  
  This reverts commit fd97c3343e9ff23677124b7528ec945bca65796a.
  
  Reason for revert: The specialization constant for rotation causes
  performance regression with older qualcomm driver. We need to keep the
  driver uniform code path for the older driver.
  
  Original change's description:
  > Vulkan: Remove rotation related data from driver uniform
  >
  > Rotation is now handled in the shader compiler with specialization
  > constant, it should be removed from driver uniforms. Since Metal is
  > using the flipXY, flipXY/negFlipXY are still kept in the shader side
  > implementation, but have moved to TranslatorMetal in this CL.
  >
  > Bug: b/171750979
  > Change-Id: Ie8d15ef227cb52a6e19e4319ecc9f09bda42e667
  > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2519863
  > Reviewed-by: Ian Elliott <ianelliott@google.com>
  > Reviewed-by: Tim Van Patten <timvp@google.com>
  > Reviewed-by: Jamie Madill <jmadill@chromium.org>
  > Commit-Queue: Charlie Lao <cclao@google.com>
  
  TBR=ianelliott@google.com,timvp@google.com,jmadill@chromium.org,cclao@google.com
  
  Bug: b/171750979
  Change-Id: Iff9cffb28851ade1d9c5cd23fde73910a19867ce
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2547808
  Reviewed-by: Ian Elliott <ianelliott@google.com>
  Reviewed-by: Jamie Madill <jmadill@chromium.org>
  Reviewed-by: Charlie Lao <cclao@google.com>
  Commit-Queue: Charlie Lao <cclao@google.com>
  

Download

• src/compiler/translator/tree_ops/RewriteInterpolateAtOffset.h

• //
  // Copyright 2020 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  // This mutating tree traversal flips the 2nd argument of interpolateAtOffset() to account for
  // Y-coordinate flipping
  //
  // From: interpolateAtOffset(float interpolant, vec2 offset);
  // To: interpolateAtOffset(float interpolant, vec2(offset * (pre-rotation * viewportYScale)));
  //
  // See http://anglebug.com/3589
  
  #ifndef COMPILER_TRANSLATOR_TREEOPS_FLIP_INTERPOLATEATOFFSET_H_
  #define COMPILER_TRANSLATOR_TREEOPS_FLIP_INTERPOLATEATOFFSET_H_
  
  #include "common/angleutils.h"
  
  namespace sh
  {
  
  class TCompiler;
  class TIntermNode;
  class TIntermBinary;
  class TIntermTyped;
  class TSymbolTable;
  
  // If fragRotation = nullptr, no rotation will be applied.
  ANGLE_NO_DISCARD bool RewriteInterpolateAtOffset(TCompiler *compiler,
                                                   ShCompileOptions compileOptions,
                                                   TIntermNode *root,
                                                   const TSymbolTable &symbolTable,
                                                   int shaderVersion,
                                                   FlipRotateSpecConst *rotationSpecConst,
                                                   const DriverUniform *driverUniforms);
  
  }  // namespace sh
  
  #endif  // COMPILER_TRANSLATOR_TREEOPS_FLIP_INTERPOLATEATOFFSET_H_
  

Download