kc3-lang/angle/src/libANGLE/renderer/vulkan/TransformFeedbackVk.h

• Show log

  Commit

• Hash : 5d3a4ca4
  Author :
  Date : 2020-08-21T13:09:56
  

  Vulkan: Fix dirty state in XFB emulation on EndXFB.
  
  This regressed in "Vulkan: Preserve RPs on XFB changes when possible."
  
  The bug manifested as incorrect fire rendering in Manhattan. The fix is
  to ensure we dirty the correct buffer state when we call endXFB. Also
  adds a regression test.
  
  Bug: b/161744596
  Bug: angleproject:4622
  Change-Id: If16cc22b149526950f300e74c0cc82c0fefae5bc
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2368016
  Reviewed-by: Tim Van Patten <timvp@google.com>
  Reviewed-by: Tobin Ehlis <tobine@google.com>
  Reviewed-by: Charlie Lao <cclao@google.com>
  Commit-Queue: Jamie Madill <jmadill@chromium.org>
  

Download

• src/libANGLE/renderer/vulkan/TransformFeedbackVk.h

• //
  // Copyright 2016 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  // TransformFeedbackVk.h:
  //    Defines the class interface for TransformFeedbackVk, implementing TransformFeedbackImpl.
  //
  
  #ifndef LIBANGLE_RENDERER_VULKAN_TRANSFORMFEEDBACKVK_H_
  #define LIBANGLE_RENDERER_VULKAN_TRANSFORMFEEDBACKVK_H_
  
  #include "libANGLE/renderer/TransformFeedbackImpl.h"
  
  #include "libANGLE/renderer/glslang_wrapper_utils.h"
  #include "libANGLE/renderer/vulkan/vk_helpers.h"
  
  namespace gl
  {
  class ProgramState;
  }  // namespace gl
  
  namespace rx
  {
  namespace vk
  {
  class DescriptorSetLayoutDesc;
  }
  
  class TransformFeedbackVk : public TransformFeedbackImpl
  {
    public:
      TransformFeedbackVk(const gl::TransformFeedbackState &state);
      ~TransformFeedbackVk() override;
      void onDestroy(const gl::Context *context) override;
  
      angle::Result begin(const gl::Context *context, gl::PrimitiveMode primitiveMode) override;
      angle::Result end(const gl::Context *context) override;
      angle::Result pause(const gl::Context *context) override;
      angle::Result resume(const gl::Context *context) override;
  
      angle::Result bindIndexedBuffer(const gl::Context *context,
                                      size_t index,
                                      const gl::OffsetBindingPointer<gl::Buffer> &binding) override;
  
      void updateDescriptorSetLayout(ContextVk *contextVk,
                                     ShaderInterfaceVariableInfoMap &vsVariableInfoMap,
                                     size_t xfbBufferCount,
                                     vk::DescriptorSetLayoutDesc *descSetLayoutOut) const;
      void initDescriptorSet(ContextVk *contextVk,
                             size_t xfbBufferCount,
                             VkDescriptorSet descSet) const;
      void updateDescriptorSet(ContextVk *contextVk,
                               const gl::ProgramState &programState,
                               VkDescriptorSet descSet) const;
      void getBufferOffsets(ContextVk *contextVk,
                            GLint drawCallFirstVertex,
                            int32_t *offsetsOut,
                            size_t offsetsSize) const;
  
      bool getAndResetBufferRebindState()
      {
          bool retVal                    = mRebindTransformFeedbackBuffer;
          mRebindTransformFeedbackBuffer = false;
          return retVal;
      }
  
      const gl::TransformFeedbackBuffersArray<vk::BufferHelper *> &getBufferHelpers() const
      {
          return mBufferHelpers;
      }
  
      const gl::TransformFeedbackBuffersArray<VkBuffer> &getBufferHandles() const
      {
          return mBufferHandles;
      }
  
      const gl::TransformFeedbackBuffersArray<VkDeviceSize> &getBufferOffsets() const
      {
          return mBufferOffsets;
      }
  
      const gl::TransformFeedbackBuffersArray<VkDeviceSize> &getBufferSizes() const
      {
          return mBufferSizes;
      }
  
      const gl::TransformFeedbackBuffersArray<VkBuffer> &getCounterBufferHandles() const
      {
          return mCounterBufferHandles;
      }
  
      vk::UniformsAndXfbDesc &getTransformFeedbackDesc() { return mXFBBuffersDesc; }
  
    private:
      void writeDescriptorSet(ContextVk *contextVk,
                              size_t xfbBufferCount,
                              VkDescriptorBufferInfo *pBufferInfo,
                              VkDescriptorSet descSet) const;
  
      void initializeXFBBuffersDesc(ContextVk *contextVk, size_t xfbBufferCount);
  
      // This member variable is set when glBindTransformFeedbackBuffers/glBeginTransformFeedback
      // is called and unset in dirty bit handler for transform feedback state change. If this
      // value is true, vertex shader will record transform feedback varyings from the beginning
      // of the buffer.
      bool mRebindTransformFeedbackBuffer;
  
      gl::TransformFeedbackBuffersArray<vk::BufferHelper *> mBufferHelpers;
      gl::TransformFeedbackBuffersArray<VkBuffer> mBufferHandles;
      gl::TransformFeedbackBuffersArray<VkDeviceSize> mBufferOffsets;
      gl::TransformFeedbackBuffersArray<VkDeviceSize> mBufferSizes;
  
      // Aligned offset for emulation. Could be smaller than offset.
      gl::TransformFeedbackBuffersArray<VkDeviceSize> mAlignedBufferOffsets;
  
      // Counter buffer used for pause and resume.
      gl::TransformFeedbackBuffersArray<vk::BufferHelper> mCounterBufferHelpers;
      gl::TransformFeedbackBuffersArray<VkBuffer> mCounterBufferHandles;
  
      // Keys to look up in the descriptor set cache
      vk::UniformsAndXfbDesc mXFBBuffersDesc;
  };
  
  }  // namespace rx
  
  #endif  // LIBANGLE_RENDERER_VULKAN_TRANSFORMFEEDBACKVK_H_
  

Download