kc3-lang/angle/src/libANGLE/Renderbuffer.cpp

• Show log

  Commit

• Hash : 6b120b9f
  Author :
  Date : 2015-11-24T13:00:07
  

  Add checks for FBO attachment layer.
  
  We would allow the app to attach layers that were out-of-bounds. Fix
  this by checking against the underlying resource dimensions. Also
  rework the code a bit to clean up the texture size query, which is
  available from the ImageDesc.
  
  BUG=angleproject:869
  
  Change-Id: I984f1db16daea6ca650d795884d8ec2cb8f05ebb
  Reviewed-on: https://chromium-review.googlesource.com/313991
  Tryjob-Request: Jamie Madill <jmadill@chromium.org>
  Reviewed-by: Geoff Lang <geofflang@chromium.org>
  Reviewed-by: Corentin Wallez <cwallez@chromium.org>
  Tested-by: Jamie Madill <jmadill@chromium.org>
  

Download

• src/libANGLE/Renderbuffer.cpp

• //
  // Copyright (c) 2002-2012 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  
  // Renderbuffer.cpp: Implements the renderer-agnostic gl::Renderbuffer class,
  // GL renderbuffer objects and related functionality.
  // [OpenGL ES 2.0.24] section 4.4.3 page 108.
  
  #include "libANGLE/Renderbuffer.h"
  
  #include "common/utilities.h"
  #include "libANGLE/FramebufferAttachment.h"
  #include "libANGLE/Image.h"
  #include "libANGLE/Texture.h"
  #include "libANGLE/formatutils.h"
  #include "libANGLE/renderer/d3d/RenderTargetD3D.h"
  
  namespace gl
  {
  Renderbuffer::Renderbuffer(rx::RenderbufferImpl *impl, GLuint id)
      : egl::ImageSibling(id),
        mRenderbuffer(impl),
        mWidth(0),
        mHeight(0),
        mInternalFormat(GL_RGBA4),
        mSamples(0)
  {
  }
  
  Renderbuffer::~Renderbuffer()
  {
      SafeDelete(mRenderbuffer);
  }
  
  Error Renderbuffer::setStorage(GLenum internalformat, size_t width, size_t height)
  {
      orphanImages();
  
      Error error = mRenderbuffer->setStorage(internalformat, width, height);
      if (error.isError())
      {
          return error;
      }
  
      mWidth          = static_cast<GLsizei>(width);
      mHeight         = static_cast<GLsizei>(height);
      mInternalFormat = internalformat;
      mSamples = 0;
  
      return Error(GL_NO_ERROR);
  }
  
  Error Renderbuffer::setStorageMultisample(size_t samples, GLenum internalformat, size_t width, size_t height)
  {
      orphanImages();
  
      Error error = mRenderbuffer->setStorageMultisample(samples, internalformat, width, height);
      if (error.isError())
      {
          return error;
      }
  
      mWidth          = static_cast<GLsizei>(width);
      mHeight         = static_cast<GLsizei>(height);
      mInternalFormat = internalformat;
      mSamples        = static_cast<GLsizei>(samples);
  
      return Error(GL_NO_ERROR);
  }
  
  Error Renderbuffer::setStorageEGLImageTarget(egl::Image *image)
  {
      orphanImages();
  
      Error error = mRenderbuffer->setStorageEGLImageTarget(image);
      if (error.isError())
      {
          return error;
      }
  
      setTargetImage(image);
  
      mWidth          = static_cast<GLsizei>(image->getWidth());
      mHeight         = static_cast<GLsizei>(image->getHeight());
      mInternalFormat = image->getInternalFormat();
      mSamples        = 0;
  
      return Error(GL_NO_ERROR);
  }
  
  rx::RenderbufferImpl *Renderbuffer::getImplementation()
  {
      ASSERT(mRenderbuffer);
      return mRenderbuffer;
  }
  
  const rx::RenderbufferImpl *Renderbuffer::getImplementation() const
  {
      return mRenderbuffer;
  }
  
  GLsizei Renderbuffer::getWidth() const
  {
      return mWidth;
  }
  
  GLsizei Renderbuffer::getHeight() const
  {
      return mHeight;
  }
  
  GLenum Renderbuffer::getInternalFormat() const
  {
      return mInternalFormat;
  }
  
  GLsizei Renderbuffer::getSamples() const
  {
      return mSamples;
  }
  
  GLuint Renderbuffer::getRedSize() const
  {
      return GetInternalFormatInfo(mInternalFormat).redBits;
  }
  
  GLuint Renderbuffer::getGreenSize() const
  {
      return GetInternalFormatInfo(mInternalFormat).greenBits;
  }
  
  GLuint Renderbuffer::getBlueSize() const
  {
      return GetInternalFormatInfo(mInternalFormat).blueBits;
  }
  
  GLuint Renderbuffer::getAlphaSize() const
  {
      return GetInternalFormatInfo(mInternalFormat).alphaBits;
  }
  
  GLuint Renderbuffer::getDepthSize() const
  {
      return GetInternalFormatInfo(mInternalFormat).depthBits;
  }
  
  GLuint Renderbuffer::getStencilSize() const
  {
      return GetInternalFormatInfo(mInternalFormat).stencilBits;
  }
  
  void Renderbuffer::onAttach()
  {
      addRef();
  }
  
  void Renderbuffer::onDetach()
  {
      release();
  }
  
  GLuint Renderbuffer::getId() const
  {
      return id();
  }
  
  Extents Renderbuffer::getAttachmentSize(const FramebufferAttachment::Target & /*target*/) const
  {
      return Extents(mWidth, mHeight, 1);
  }
  }
  

Download