Hash :
8b9bd182
Author :
Date :
2023-02-08T16:17:10
Vulkan: Refactoring to use ProtectionType enum instead of bool
This is a second stage of refactoring that was started here:
Vulkan: Minor CommandQueue implementation refactoring.
0210b46d35b51ea04bddafb48ba406a87c39e58e
Enumeration renamed: CommandContent -> ProtectionType.
Currently interfaces of ContextVk/RendererVk/CommandQueue use
"hasProtectedContent" boolean. Internally CommandQueue uses
"vk::ProtectionType" enumeration to separate states related to
Unprotected/Protected commands. This CL replaces boolean with
enumeration for consistency.
Bug: angleproject:7995
Change-Id: Ibb98cce661358d464be7c6a8367a1297d7093b1c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4232114
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Igor Nazarov <i.nazarov@samsung.com>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54
//
// Copyright 2021 The ANGLE Project Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
// vk_command_buffer_utils:
// Helpers for secondary command buffer implementations.
//
#ifndef LIBANGLE_RENDERER_VULKAN_VK_COMMAND_BUFFER_UTILS_H_
#define LIBANGLE_RENDERER_VULKAN_VK_COMMAND_BUFFER_UTILS_H_
#include "common/angleutils.h"
namespace rx
{
namespace vk
{
enum class ProtectionType
{
Unprotected = 0,
Protected = 1,
InvalidEnum = 2,
EnumCount = 2,
};
ANGLE_INLINE ProtectionType ConvertProtectionBoolToType(bool isProtected)
{
return (isProtected ? ProtectionType::Protected : ProtectionType::Unprotected);
}
// A helper class to track commands recorded to a command buffer.
class CommandBufferCommandTracker
{
public:
void onDraw() { ++mRenderPassWriteCommandCount; }
void onClearAttachments() { ++mRenderPassWriteCommandCount; }
uint32_t getRenderPassWriteCommandCount() const { return mRenderPassWriteCommandCount; }
void reset() { *this = CommandBufferCommandTracker{}; }
private:
// The number of commands recorded that can modify a render pass attachment, i.e.
// vkCmdClearAttachment and vkCmdDraw*. Used to know if a command might have written to an
// attachment after it was invalidated.
uint32_t mRenderPassWriteCommandCount = 0;
};
} // namespace vk
} // namespace rx
#endif // LIBANGLE_RENDERER_VULKAN_VK_COMMAND_BUFFER_UTILS_H_