kc3-lang/angle/src/compiler/translator/msl/IdGen.cpp

Branch - branch -main

• Show log

  Commit

• Hash : 25390156
  Author :
  Date : 2025-08-21T00:13:19
  

  Suppress unsafe buffers on a file-by-file basis in src/ [1 of N]
  
  In this CL, we suppress many files but stop short of actually
  enabling the warning by not removing the line from the
  unsafe_buffers_paths.txt file. That will happen in a follow-on
  CL, along with resolving any stragglers missed here.
  
  This is mostly a manual change so as to familiarize myself with
  the kinds of issues faced by the Angle codebase when applying buffer
  safety warnings.
  
  -- Re-generate affected hashes.
  -- Clang-format applied to all changed files.
  -- Add a few missing .reserve() calls to vectors as noticed.
  -- Fix some mismatches between file names and header comments.
  -- Be more consistent with header comment format (blank lines and
     trailing //-only lines when a filename comment adjoins license
     boilerplate).
  
  Bug: b/436880895
  Change-Id: I3bde5cc2059acbe8345057289214f1a26f1c34aa
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6869022
  Reviewed-by: Geoff Lang <geofflang@chromium.org>
  Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
  Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
  

Download

• src/compiler/translator/msl/IdGen.cpp

• //
  // Copyright 2020 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  
  #ifdef UNSAFE_BUFFERS_BUILD
  #    pragma allow_unsafe_buffers
  #endif
  
  #include <cctype>
  #include <cstring>
  #include <limits>
  #include <unordered_map>
  #include <unordered_set>
  
  #include "compiler/translator/msl/IdGen.h"
  
  using namespace sh;
  
  ////////////////////////////////////////////////////////////////////////////////
  
  IdGen::IdGen() {}
  
  template <typename String, typename StringToImmutable>
  Name IdGen::createNewName(size_t count,
                            const String *baseNames,
                            const StringToImmutable &toImmutable)
  {
      const unsigned id = mNext++;
      char idBuffer[std::numeric_limits<unsigned>::digits10 + 1];
      snprintf(idBuffer, sizeof(idBuffer), "%u", id);
  
      mNewNameBuffer.clear();
      mNewNameBuffer += '_';
      mNewNameBuffer += idBuffer;
  
      for (size_t i = 0; i < count; ++i)
      {
          const ImmutableString baseName = toImmutable(baseNames[i]);
          if (!baseName.empty())
          {
              const char *base = baseName.data();
              if (baseName.beginsWith(kAngleInternalPrefix))
              {
                  // skip 'ANGLE' or 'ANGLE_' prefix
                  base += sizeof(kAngleInternalPrefix) - 1;
                  if (*base == '_')
                  {
                      ++base;
                  }
              }
  
              mNewNameBuffer += '_';
              mNewNameBuffer += base;
          }
      }
  
      return Name(ImmutableString(mNewNameBuffer), SymbolType::AngleInternal);
  }
  
  Name IdGen::createNewName(const ImmutableString &baseName)
  {
      return createNewName({baseName});
  }
  
  Name IdGen::createNewName(const Name &baseName)
  {
      return createNewName(baseName.rawName());
  }
  
  Name IdGen::createNewName(const char *baseName)
  {
      return createNewName(ImmutableString(baseName));
  }
  
  Name IdGen::createNewName(std::initializer_list<ImmutableString> baseNames)
  {
      return createNewName(baseNames.size(), baseNames.begin(),
                           [](const ImmutableString &s) { return s; });
  }
  
  Name IdGen::createNewName(std::initializer_list<Name> baseNames)
  {
      return createNewName(baseNames.size(), baseNames.begin(),
                           [](const Name &s) { return s.rawName(); });
  }
  
  Name IdGen::createNewName(std::initializer_list<const char *> baseNames)
  {
      return createNewName(baseNames.size(), baseNames.begin(),
                           [](const char *s) { return ImmutableString(s); });
  }
  
  Name IdGen::createNewName()
  {
      // TODO(anglebug.com/40096755): refactor this later.
      return createNewName<int>(0, nullptr, [](int) { return kEmptyImmutableString; });
  }
  

Download