kc3-lang/angle/src/libANGLE/renderer/cl/cl_util.cpp

Branch - branch -main

• Show log

  Commit

• Hash : 25390156
  Author :
  Date : 2025-08-21T00:13:19
  

  Suppress unsafe buffers on a file-by-file basis in src/ [1 of N]
  
  In this CL, we suppress many files but stop short of actually
  enabling the warning by not removing the line from the
  unsafe_buffers_paths.txt file. That will happen in a follow-on
  CL, along with resolving any stragglers missed here.
  
  This is mostly a manual change so as to familiarize myself with
  the kinds of issues faced by the Angle codebase when applying buffer
  safety warnings.
  
  -- Re-generate affected hashes.
  -- Clang-format applied to all changed files.
  -- Add a few missing .reserve() calls to vectors as noticed.
  -- Fix some mismatches between file names and header comments.
  -- Be more consistent with header comment format (blank lines and
     trailing //-only lines when a filename comment adjoins license
     boilerplate).
  
  Bug: b/436880895
  Change-Id: I3bde5cc2059acbe8345057289214f1a26f1c34aa
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6869022
  Reviewed-by: Geoff Lang <geofflang@chromium.org>
  Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
  Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
  

Download

• src/libANGLE/renderer/cl/cl_util.cpp

• //
  // Copyright 2021 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  // cl_utils.cpp: Helper functions for the CL back end
  //
  
  #ifdef UNSAFE_BUFFERS_BUILD
  #    pragma allow_unsafe_buffers
  #endif
  
  #include "libANGLE/renderer/cl/cl_util.h"
  
  #include "libANGLE/Debug.h"
  
  #include <cstdlib>
  
  namespace rx
  {
  
  cl_version ExtractCLVersion(const std::string &version)
  {
      const std::string::size_type spacePos = version.find(' ');
      const std::string::size_type dotPos   = version.find('.');
      if (spacePos == std::string::npos || dotPos == std::string::npos)
      {
          ERR() << "Failed to extract version from OpenCL version string: " << version;
          return 0u;
      }
  
      const long major = std::strtol(&version[spacePos + 1u], nullptr, 10);
      const long minor = std::strtol(&version[dotPos + 1u], nullptr, 10);
      if (major < 1 || major > 9 || minor < 0 || minor > 9)
      {
          ERR() << "Failed to extract version from OpenCL version string: " << version;
          return 0u;
      }
      return CL_MAKE_VERSION(static_cast<cl_uint>(major), static_cast<cl_uint>(minor), 0);
  }
  
  void RemoveUnsupportedCLExtensions(std::string &extensions)
  {
      if (extensions.empty())
      {
          return;
      }
      using SizeT    = std::string::size_type;
      SizeT extStart = 0u;
      SizeT spacePos = extensions.find(' ');
  
      // Remove all unsupported extensions which are terminated by a space
      while (spacePos != std::string::npos)
      {
          const SizeT length = spacePos - extStart;
          if (IsCLExtensionSupported(extensions.substr(extStart, length)))
          {
              extStart = spacePos + 1u;
          }
          else
          {
              extensions.erase(extStart, length + 1u);
          }
          spacePos = extensions.find(' ', extStart);
      }
  
      // Remove last extension in string, if exists and unsupported
      if (extStart < extensions.length())
      {
          const SizeT length = extensions.length() - extStart;
          if (!IsCLExtensionSupported(extensions.substr(extStart, length)))
          {
              extensions.erase(extStart, length);
          }
      }
  
      // Remove trailing spaces
      while (!extensions.empty() && extensions.back() == ' ')
      {
          extensions.pop_back();
      }
  }
  
  void RemoveUnsupportedCLExtensions(NameVersionVector &extensions)
  {
      auto extIt = extensions.cbegin();
      while (extIt != extensions.cend())
      {
          if (IsCLExtensionSupported(extIt->name))
          {
              ++extIt;
          }
          else
          {
              extIt = extensions.erase(extIt);
          }
      }
  }
  
  }  // namespace rx
  

Download