Branch
Hash :
25390156
Author :
Date :
2025-08-21T00:13:19
Suppress unsafe buffers on a file-by-file basis in src/ [1 of N] In this CL, we suppress many files but stop short of actually enabling the warning by not removing the line from the unsafe_buffers_paths.txt file. That will happen in a follow-on CL, along with resolving any stragglers missed here. This is mostly a manual change so as to familiarize myself with the kinds of issues faced by the Angle codebase when applying buffer safety warnings. -- Re-generate affected hashes. -- Clang-format applied to all changed files. -- Add a few missing .reserve() calls to vectors as noticed. -- Fix some mismatches between file names and header comments. -- Be more consistent with header comment format (blank lines and trailing //-only lines when a filename comment adjoins license boilerplate). Bug: b/436880895 Change-Id: I3bde5cc2059acbe8345057289214f1a26f1c34aa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6869022 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71
//
// Copyright 2012 The ANGLE Project Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
// ShaderExecutable.cpp: Implements a class to contain D3D shader executable
// implementation details.
#ifdef UNSAFE_BUFFERS_BUILD
# pragma allow_unsafe_buffers
#endif
#include "libANGLE/renderer/d3d/ShaderExecutableD3D.h"
#include "common/angleutils.h"
namespace rx
{
ShaderExecutableD3D::ShaderExecutableD3D(const void *function, size_t length)
: mFunctionBuffer(length)
{
memcpy(mFunctionBuffer.data(), function, length);
}
ShaderExecutableD3D::~ShaderExecutableD3D() {}
const uint8_t *ShaderExecutableD3D::getFunction() const
{
return mFunctionBuffer.data();
}
size_t ShaderExecutableD3D::getLength() const
{
return mFunctionBuffer.size();
}
const std::string &ShaderExecutableD3D::getDebugInfo() const
{
return mDebugInfo;
}
void ShaderExecutableD3D::appendDebugInfo(const std::string &info)
{
mDebugInfo += info;
}
UniformStorageD3D::UniformStorageD3D(size_t initialSize) : mUniformData()
{
bool result = mUniformData.resize(initialSize);
ASSERT(result);
// Uniform data is zero-initialized by default.
mUniformData.fill(0);
}
UniformStorageD3D::~UniformStorageD3D() {}
size_t UniformStorageD3D::size() const
{
return mUniformData.size();
}
uint8_t *UniformStorageD3D::getDataPointer(unsigned int registerIndex, unsigned int registerElement)
{
size_t offset = ((registerIndex * 4 + registerElement) * sizeof(float));
return mUniformData.data() + offset;
}
} // namespace rx