Branch
Hash :
ad18dc93
Author :
Date :
2025-04-02T16:23:50
D3D11: Remove the message from Buffer11 to gl::Buffer This CL removes the D3D back end's usage of Subject/Observer from Buffer11 to gl::Buffer. BufferFeedback argument has been added to various functions and directly applied to gl::Buffer object (which will propagate to VertexArray and texture/XFB if needed). gl::Buffer::mImplObserver is removed in this CL, and no longer a Observer. Bug: angleproject:400711938 Change-Id: Idf4d423904d057ab3a1e52acf8e2496df606cb89 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6514288 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133
//
// Copyright 2014 The ANGLE Project Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
// TransformFeedbackD3D.cpp is a no-op implementation for both the D3D9 and D3D11 renderers.
#include "libANGLE/renderer/d3d/d3d11/TransformFeedback11.h"
#include "libANGLE/Buffer.h"
#include "libANGLE/renderer/d3d/d3d11/Buffer11.h"
#include "libANGLE/renderer/d3d/d3d11/Renderer11.h"
namespace rx
{
TransformFeedback11::TransformFeedback11(const gl::TransformFeedbackState &state,
Renderer11 *renderer)
: TransformFeedbackImpl(state),
mRenderer(renderer),
mIsDirty(true),
mBuffers(state.getIndexedBuffers().size(), nullptr),
mBufferOffsets(state.getIndexedBuffers().size(), 0),
mSerial(mRenderer->generateSerial())
{}
TransformFeedback11::~TransformFeedback11() {}
angle::Result TransformFeedback11::begin(const gl::Context *context,
gl::PrimitiveMode primitiveMode)
{
// Reset all the cached offsets to the binding offsets
mIsDirty = true;
for (size_t bindingIdx = 0; bindingIdx < mBuffers.size(); bindingIdx++)
{
const auto &binding = mState.getIndexedBuffer(bindingIdx);
if (binding.get() != nullptr)
{
mBufferOffsets[bindingIdx] = static_cast<UINT>(binding.getOffset());
}
else
{
mBufferOffsets[bindingIdx] = 0;
}
}
mRenderer->getStateManager()->invalidateTransformFeedback();
return angle::Result::Continue;
}
angle::Result TransformFeedback11::end(const gl::Context *context)
{
mRenderer->getStateManager()->invalidateTransformFeedback();
if (mRenderer->getFeatures().flushAfterEndingTransformFeedback.enabled)
{
mRenderer->getDeviceContext()->Flush();
}
return angle::Result::Continue;
}
angle::Result TransformFeedback11::pause(const gl::Context *context)
{
mRenderer->getStateManager()->invalidateTransformFeedback();
return angle::Result::Continue;
}
angle::Result TransformFeedback11::resume(const gl::Context *context)
{
mRenderer->getStateManager()->invalidateTransformFeedback();
return angle::Result::Continue;
}
angle::Result TransformFeedback11::bindIndexedBuffer(
const gl::Context *context,
size_t index,
const gl::OffsetBindingPointer<gl::Buffer> &binding)
{
mIsDirty = true;
mBufferOffsets[index] = static_cast<UINT>(binding.getOffset());
mRenderer->getStateManager()->invalidateTransformFeedback();
return angle::Result::Continue;
}
void TransformFeedback11::onApply()
{
mIsDirty = false;
// Change all buffer offsets to -1 so that if any of them need to be re-applied, the are set to
// append
std::fill(mBufferOffsets.begin(), mBufferOffsets.end(), -1);
}
bool TransformFeedback11::isDirty() const
{
return mIsDirty;
}
UINT TransformFeedback11::getNumSOBuffers() const
{
return static_cast<UINT>(mBuffers.size());
}
angle::Result TransformFeedback11::getSOBuffers(const gl::Context *context,
const std::vector<ID3D11Buffer *> **buffersOut)
{
for (size_t bindingIdx = 0; bindingIdx < mBuffers.size(); bindingIdx++)
{
const auto &binding = mState.getIndexedBuffer(bindingIdx);
if (binding.get() != nullptr)
{
Buffer11 *storage = GetImplAs<Buffer11>(binding.get());
BufferFeedback feedback;
ANGLE_TRY(storage->getBuffer(context, BUFFER_USAGE_VERTEX_OR_TRANSFORM_FEEDBACK,
&mBuffers[bindingIdx], &feedback));
binding.get()->applyImplFeedback(context, feedback);
}
}
*buffersOut = &mBuffers;
return angle::Result::Continue;
}
const std::vector<UINT> &TransformFeedback11::getSOBufferOffsets() const
{
return mBufferOffsets;
}
UniqueSerial TransformFeedback11::getSerial() const
{
return mSerial;
}
} // namespace rx