kc3-lang/angle/src/libANGLE/renderer/d3d/d3d11/VertexArray11.h

Branch - branch -main

• Show log

  Commit

• Hash : b4d84458
  Author :
  Date : 2025-05-23T18:08:19
  

  Move Buffer from VertexBinding to VertexArray
  
  In later CL we will not taking shared context lock for certain
  VertexArray API calls. VertexArray itself is per context, so this sounds
  reasonable to do. The main challenge here is a lot of VertexArray
  function end up accessing gl::Buffer object, which could be modified by
  other shared contexts. In order to safely not taking the shared context
  lock, we need to separate out Buffer object out of VertexArray itself so
  that these lockless APIs will take VertexArray that does not have access
  to buffer.
  
  In this CL, VertexArray is split into two classes: VertexArrayPrivate is
  everything in VertexArray except buffers. VertexArray is a subclass of
  VertexArrayPrivate and owns all the buffers. Buffer is removed from
  gl::VertexBinding class. In order to let back end access to buffers,
  VertexArrayImpl holds a weak reference to
  VertexArray::mVertexArrayBuffers (which is a vector of buffers).
  Further, VertexArrayBufferBindingMask mBufferBindingMask is moved from
  VertexArrayState into VertexArray class well, since it tracks which
  index has a non-null buffer. The bulk of change are due to the
  VertexARrayImpl constructor change, since it now takes
  vertexArrayBuffers argument. Other bulk of changes are due to
  VertexBinding no long has the buffer, but you need to get it directly
  from VertexArray or VertexArrayImpl.
  
  This CL also reverts some of the change in crrev.com/c/6758215 that
  mVertexBindings no longer contains kElementArrayBufferIndex.
  
  BYPASS_LARGE_CHANGE_WARNING
  
  Bug: b/433331119
  Change-Id: I15f4576f7c5c8d8f4d9c9c07d38a60ce539bfeea
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6774702
  Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
  Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
  Commit-Queue: Charlie Lao <cclao@google.com>
  

Download

• src/libANGLE/renderer/d3d/d3d11/VertexArray11.h

• //
  // Copyright 2014 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  
  // VertexArray11.h: Defines the rx::VertexArray11 class which implements rx::VertexArrayImpl.
  
  #ifndef LIBANGLE_RENDERER_D3D_D3D11_VERTEXARRAY11_H_
  #define LIBANGLE_RENDERER_D3D_D3D11_VERTEXARRAY11_H_
  
  #include "libANGLE/Framebuffer.h"
  #include "libANGLE/renderer/VertexArrayImpl.h"
  #include "libANGLE/renderer/d3d/d3d11/Renderer11.h"
  #include "libANGLE/renderer/d3d/d3d11/renderer11_utils.h"
  
  namespace rx
  {
  class Renderer11;
  
  class VertexArray11 : public VertexArrayImpl
  {
    public:
      VertexArray11(const gl::VertexArrayState &data,
                    const gl::VertexArrayBuffers &vertexArrayBuffers);
      ~VertexArray11() override;
      void destroy(const gl::Context *context) override;
  
      // Does not apply any state updates - these are done in syncStateForDraw which as access to
      // the draw call parameters.
      angle::Result syncState(const gl::Context *context,
                              const gl::VertexArray::DirtyBits &dirtyBits,
                              gl::VertexArray::DirtyAttribBitsArray *attribBits,
                              gl::VertexArray::DirtyBindingBitsArray *bindingBits) override;
  
      // Applied buffer pointers are updated here.
      angle::Result syncStateForDraw(const gl::Context *context,
                                     GLint firstVertex,
                                     GLsizei vertexOrIndexCount,
                                     gl::DrawElementsType indexTypeOrInvalid,
                                     const void *indices,
                                     GLsizei instances,
                                     GLint baseVertex,
                                     GLuint baseInstance,
                                     bool promoteDynamic);
  
      // This will check the dynamic attribs mask.
      bool hasActiveDynamicAttrib(const gl::Context *context);
  
      const std::vector<TranslatedAttribute> &getTranslatedAttribs() const;
  
      UniqueSerial getCurrentStateSerial() const { return mCurrentStateSerial; }
  
      // In case of a multi-view program change, we have to update all attributes so that the divisor
      // is adjusted.
      void markAllAttributeDivisorsForAdjustment(int numViews);
  
      const TranslatedIndexData &getCachedIndexInfo() const;
      void updateCachedIndexInfo(const TranslatedIndexData &indexInfo);
      bool isCachedIndexInfoValid() const;
  
      gl::DrawElementsType getCachedDestinationIndexType() const;
  
    private:
      void updateVertexAttribStorage(const gl::Context *context,
                                     StateManager11 *stateManager,
                                     size_t attribIndex);
      angle::Result updateDirtyAttribs(const gl::Context *context,
                                       const gl::AttributesMask &activeDirtyAttribs);
      angle::Result updateDynamicAttribs(const gl::Context *context,
                                         VertexDataManager *vertexDataManager,
                                         GLint firstVertex,
                                         GLsizei vertexOrIndexCount,
                                         gl::DrawElementsType indexTypeOrInvalid,
                                         const void *indices,
                                         GLsizei instances,
                                         GLint baseVertex,
                                         GLuint baseInstance,
                                         bool promoteDynamic,
                                         const gl::AttributesMask &activeDynamicAttribs);
  
      angle::Result updateElementArrayStorage(const gl::Context *context,
                                              GLsizei indexCount,
                                              gl::DrawElementsType indexType,
                                              const void *indices,
                                              bool restartEnabled);
  
      std::vector<VertexStorageType> mAttributeStorageTypes;
      std::vector<TranslatedAttribute> mTranslatedAttribs;
  
      // The mask of attributes marked as dynamic.
      gl::AttributesMask mDynamicAttribsMask;
  
      // A set of attributes we know are dirty, and need to be re-translated.
      gl::AttributesMask mAttribsToTranslate;
  
      UniqueSerial mCurrentStateSerial;
  
      // The numViews value used to adjust the divisor.
      int mAppliedNumViewsToDivisor;
  
      // If the index buffer needs re-streaming.
      Optional<gl::DrawElementsType> mLastDrawElementsType;
      Optional<const void *> mLastDrawElementsIndices;
      Optional<bool> mLastPrimitiveRestartEnabled;
      IndexStorageType mCurrentElementArrayStorage;
      Optional<TranslatedIndexData> mCachedIndexInfo;
      gl::DrawElementsType mCachedDestinationIndexType;
  };
  
  }  // namespace rx
  
  #endif  // LIBANGLE_RENDERER_D3D_D3D11_VERTEXARRAY11_H_
  

Download