kc3-lang/angle/src/libANGLE/renderer/gl/cgl/PbufferSurfaceCGL.cpp

Branch - branch -main

• Show log

  Commit

• Hash : 5fd368aa
  Author :
  Date : 2025-07-30T14:45:55
  

  Replace Surface::getWidth/Height() with getSize()
  
  Most places in the code use both `getWidth/Height()` methods at the same
  time. On some back-ends it is more optimal to have single method.
  For example, `WindowSurfaceWGL` first uses `GetClientRect()` Win32 API
  inside each method to then calculate width and hight in each method,
  causing repeated `GetClientRect()` call.
  
  The only place where only one of the methods may be used is from
  `SurfaceImpl::getUserSize()` when one of the parameters is `nullptr`,
  which is only possible from `QuerySurfaceAttrib()` function. This
  method is rewritten to use new `getSize()` method and then use whatever
  dimensions is requested by the caller. This may cause
  `QuerySurfaceAttrib()` inefficiency on some back-ends that get width and
  height of the surface differently (`SurfaceEGL` for example). In such
  cases `getUserSize()` is overridden to avoid returning a dimension
  which is not required.
  
  After this change all places in the code that previously used both
  `getWidth/Height()` methods (like `Surface::getAttachmentSize()`) will
  be more efficient. The `QuerySurfaceAttrib()`, on the other hand, will
  have slightly more overhead on back-ends where base
  `SurfaceImpl::getUserSize()` method is used, which only happens on
  back-ends with trivial `getSize()` implementation.
  
  Bug: angleproject:397848903
  Change-Id: I4a22701a1e62ee4e7d07e77cac5b388050d98e4d
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6802440
  Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
  Commit-Queue: Igor Nazarov <i.nazarov@samsung.com>
  

Download

• src/libANGLE/renderer/gl/cgl/PbufferSurfaceCGL.cpp

• //
  // Copyright 2015 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  
  // PBufferSurfaceCGL.cpp: an implementation of egl::Surface for PBuffers for the CLG backend,
  //                      currently implemented using renderbuffers
  
  #include "libANGLE/renderer/gl/cgl/PbufferSurfaceCGL.h"
  
  #include "common/debug.h"
  #include "libANGLE/renderer/gl/FramebufferGL.h"
  #include "libANGLE/renderer/gl/FunctionsGL.h"
  #include "libANGLE/renderer/gl/RendererGL.h"
  #include "libANGLE/renderer/gl/StateManagerGL.h"
  
  namespace rx
  {
  
  PbufferSurfaceCGL::PbufferSurfaceCGL(const egl::SurfaceState &state,
                                       RendererGL *renderer,
                                       EGLint width,
                                       EGLint height)
      : SurfaceGL(state),
        mWidth(width),
        mHeight(height),
        mFunctions(renderer->getFunctions()),
        mStateManager(renderer->getStateManager()),
        mFramebuffer(0),
        mColorRenderbuffer(0),
        mDSRenderbuffer(0)
  {}
  
  PbufferSurfaceCGL::~PbufferSurfaceCGL()
  {
      if (mFramebuffer != 0)
      {
          mStateManager->deleteFramebuffer(mFramebuffer);
          mFramebuffer = 0;
      }
  
      if (mColorRenderbuffer != 0)
      {
          mStateManager->deleteRenderbuffer(mColorRenderbuffer);
          mColorRenderbuffer = 0;
      }
      if (mDSRenderbuffer != 0)
      {
          mStateManager->deleteRenderbuffer(mDSRenderbuffer);
          mDSRenderbuffer = 0;
      }
  }
  
  egl::Error PbufferSurfaceCGL::initialize(const egl::Display *display)
  {
      mFunctions->genRenderbuffers(1, &mColorRenderbuffer);
      mStateManager->bindRenderbuffer(GL_RENDERBUFFER, mColorRenderbuffer);
      mFunctions->renderbufferStorage(GL_RENDERBUFFER, GL_RGBA8, mWidth, mHeight);
  
      mFunctions->genRenderbuffers(1, &mDSRenderbuffer);
      mStateManager->bindRenderbuffer(GL_RENDERBUFFER, mDSRenderbuffer);
      mFunctions->renderbufferStorage(GL_RENDERBUFFER, GL_DEPTH24_STENCIL8, mWidth, mHeight);
  
      return egl::NoError();
  }
  
  egl::Error PbufferSurfaceCGL::makeCurrent(const gl::Context *context)
  {
      return egl::NoError();
  }
  
  egl::Error PbufferSurfaceCGL::swap(const gl::Context *context, SurfaceSwapFeedback *feedback)
  {
      return egl::NoError();
  }
  
  egl::Error PbufferSurfaceCGL::postSubBuffer(const gl::Context *context,
                                              EGLint x,
                                              EGLint y,
                                              EGLint width,
                                              EGLint height)
  {
      return egl::NoError();
  }
  
  egl::Error PbufferSurfaceCGL::querySurfacePointerANGLE(EGLint attribute, void **value)
  {
      UNIMPLEMENTED();
      return egl::NoError();
  }
  
  egl::Error PbufferSurfaceCGL::bindTexImage(const gl::Context *context,
                                             gl::Texture *texture,
                                             EGLint buffer)
  {
      UNIMPLEMENTED();
      return egl::NoError();
  }
  
  egl::Error PbufferSurfaceCGL::releaseTexImage(const gl::Context *context, EGLint buffer)
  {
      UNIMPLEMENTED();
      return egl::NoError();
  }
  
  void PbufferSurfaceCGL::setSwapInterval(const egl::Display *display, EGLint interval) {}
  
  gl::Extents PbufferSurfaceCGL::getSize() const
  {
      return gl::Extents(mWidth, mHeight, 1);
  }
  
  
  EGLint PbufferSurfaceCGL::isPostSubBufferSupported() const
  {
      UNIMPLEMENTED();
      return EGL_FALSE;
  }
  
  EGLint PbufferSurfaceCGL::getSwapBehavior() const
  {
      return EGL_BUFFER_PRESERVED;
  }
  
  egl::Error PbufferSurfaceCGL::attachToFramebuffer(const gl::Context *context,
                                                    gl::Framebuffer *framebuffer)
  {
      FramebufferGL *framebufferGL = GetImplAs<FramebufferGL>(framebuffer);
      ASSERT(framebufferGL->getFramebufferID() == 0);
  
      if (mFramebuffer == 0)
      {
          GLuint framebufferID = 0;
          mFunctions->genFramebuffers(1, &framebufferID);
          mStateManager->bindFramebuffer(GL_FRAMEBUFFER, framebufferID);
          mFunctions->framebufferRenderbuffer(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_RENDERBUFFER,
                                              mColorRenderbuffer);
          mFunctions->framebufferRenderbuffer(GL_FRAMEBUFFER, GL_DEPTH_STENCIL_ATTACHMENT,
                                              GL_RENDERBUFFER, mDSRenderbuffer);
          mFramebuffer = framebufferID;
      }
      framebufferGL->setFramebufferID(mFramebuffer);
      return egl::NoError();
  }
  
  egl::Error PbufferSurfaceCGL::detachFromFramebuffer(const gl::Context *context,
                                                      gl::Framebuffer *framebuffer)
  {
      FramebufferGL *framebufferGL = GetImplAs<FramebufferGL>(framebuffer);
      ASSERT(framebufferGL->getFramebufferID() == mFramebuffer);
      framebufferGL->setFramebufferID(0);
      return egl::NoError();
  }
  
  }  // namespace rx
  

Download