kc3-lang/angle/src/libANGLE/renderer/gl/glx/PbufferSurfaceGLX.cpp

Branch - branch -main

• Show log

  Commit

• Hash : 5fd368aa
  Author :
  Date : 2025-07-30T14:45:55
  

  Replace Surface::getWidth/Height() with getSize()
  
  Most places in the code use both `getWidth/Height()` methods at the same
  time. On some back-ends it is more optimal to have single method.
  For example, `WindowSurfaceWGL` first uses `GetClientRect()` Win32 API
  inside each method to then calculate width and hight in each method,
  causing repeated `GetClientRect()` call.
  
  The only place where only one of the methods may be used is from
  `SurfaceImpl::getUserSize()` when one of the parameters is `nullptr`,
  which is only possible from `QuerySurfaceAttrib()` function. This
  method is rewritten to use new `getSize()` method and then use whatever
  dimensions is requested by the caller. This may cause
  `QuerySurfaceAttrib()` inefficiency on some back-ends that get width and
  height of the surface differently (`SurfaceEGL` for example). In such
  cases `getUserSize()` is overridden to avoid returning a dimension
  which is not required.
  
  After this change all places in the code that previously used both
  `getWidth/Height()` methods (like `Surface::getAttachmentSize()`) will
  be more efficient. The `QuerySurfaceAttrib()`, on the other hand, will
  have slightly more overhead on back-ends where base
  `SurfaceImpl::getUserSize()` method is used, which only happens on
  back-ends with trivial `getSize()` implementation.
  
  Bug: angleproject:397848903
  Change-Id: I4a22701a1e62ee4e7d07e77cac5b388050d98e4d
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6802440
  Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
  Commit-Queue: Igor Nazarov <i.nazarov@samsung.com>
  

Download

• src/libANGLE/renderer/gl/glx/PbufferSurfaceGLX.cpp

• //
  // Copyright 2015 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  
  // PbufferSurfaceGLX.cpp: GLX implementation of egl::Surface for PBuffers
  
  #include "common/debug.h"
  #include "libANGLE/renderer/gl/glx/DisplayGLX.h"
  
  #include "libANGLE/renderer/gl/glx/FunctionsGLX.h"
  #include "libANGLE/renderer/gl/glx/PbufferSurfaceGLX.h"
  
  namespace rx
  {
  
  PbufferSurfaceGLX::PbufferSurfaceGLX(const egl::SurfaceState &state,
                                       EGLint width,
                                       EGLint height,
                                       bool largest,
                                       const FunctionsGLX &glx,
                                       glx::FBConfig fbConfig)
      : SurfaceGLX(state),
        mWidth(width),
        mHeight(height),
        mLargest(largest),
        mGLX(glx),
        mFBConfig(fbConfig),
        mPbuffer(0)
  {}
  
  PbufferSurfaceGLX::~PbufferSurfaceGLX()
  {
      if (mPbuffer)
      {
          mGLX.destroyPbuffer(mPbuffer);
      }
  }
  
  egl::Error PbufferSurfaceGLX::initialize(const egl::Display *display)
  {
      // Avoid creating 0-sized PBuffers as it fails on the Intel Mesa driver
      // as commented on https://bugs.freedesktop.org/show_bug.cgi?id=38869 so we
      // use (w, 1) or (1, h) instead.
      int width  = std::max(1, static_cast<int>(mWidth));
      int height = std::max(1, static_cast<int>(mHeight));
  
      const int attribs[] = {
          GLX_PBUFFER_WIDTH, width, GLX_PBUFFER_HEIGHT, height, GLX_LARGEST_PBUFFER, mLargest, None};
  
      mPbuffer = mGLX.createPbuffer(mFBConfig, attribs);
      if (!mPbuffer)
      {
          return egl::Error(EGL_BAD_ALLOC, "Failed to create a native GLX pbuffer.");
      }
  
      if (mLargest)
      {
          mGLX.queryDrawable(mPbuffer, GLX_WIDTH, &mWidth);
          mGLX.queryDrawable(mPbuffer, GLX_HEIGHT, &mHeight);
      }
  
      return egl::NoError();
  }
  
  egl::Error PbufferSurfaceGLX::makeCurrent(const gl::Context *context)
  {
      return egl::NoError();
  }
  
  egl::Error PbufferSurfaceGLX::swap(const gl::Context *context, SurfaceSwapFeedback *feedback)
  {
      return egl::NoError();
  }
  
  egl::Error PbufferSurfaceGLX::postSubBuffer(const gl::Context *context,
                                              EGLint x,
                                              EGLint y,
                                              EGLint width,
                                              EGLint height)
  {
      return egl::NoError();
  }
  
  egl::Error PbufferSurfaceGLX::querySurfacePointerANGLE(EGLint attribute, void **value)
  {
      UNIMPLEMENTED();
      return egl::NoError();
  }
  
  egl::Error PbufferSurfaceGLX::bindTexImage(const gl::Context *context,
                                             gl::Texture *texture,
                                             EGLint buffer)
  {
      UNIMPLEMENTED();
      return egl::NoError();
  }
  
  egl::Error PbufferSurfaceGLX::releaseTexImage(const gl::Context *context, EGLint buffer)
  {
      UNIMPLEMENTED();
      return egl::NoError();
  }
  
  void PbufferSurfaceGLX::setSwapInterval(const egl::Display *display, EGLint interval) {}
  
  gl::Extents PbufferSurfaceGLX::getSize() const
  {
      return gl::Extents(mWidth, mHeight, 1);
  }
  
  EGLint PbufferSurfaceGLX::isPostSubBufferSupported() const
  {
      UNIMPLEMENTED();
      return EGL_FALSE;
  }
  
  EGLint PbufferSurfaceGLX::getSwapBehavior() const
  {
      return EGL_BUFFER_PRESERVED;
  }
  
  egl::Error PbufferSurfaceGLX::checkForResize()
  {
      // The size of pbuffers never change
      return egl::NoError();
  }
  
  glx::Drawable PbufferSurfaceGLX::getDrawable() const
  {
      return mPbuffer;
  }
  
  }  // namespace rx
  

Download