kc3-lang/angle/src/libANGLE/renderer/gl/wgl/WindowSurfaceWGL.cpp

Branch - branch -main

• Show log

  Commit

• Hash : 5fd368aa
  Author :
  Date : 2025-07-30T14:45:55
  

  Replace Surface::getWidth/Height() with getSize()
  
  Most places in the code use both `getWidth/Height()` methods at the same
  time. On some back-ends it is more optimal to have single method.
  For example, `WindowSurfaceWGL` first uses `GetClientRect()` Win32 API
  inside each method to then calculate width and hight in each method,
  causing repeated `GetClientRect()` call.
  
  The only place where only one of the methods may be used is from
  `SurfaceImpl::getUserSize()` when one of the parameters is `nullptr`,
  which is only possible from `QuerySurfaceAttrib()` function. This
  method is rewritten to use new `getSize()` method and then use whatever
  dimensions is requested by the caller. This may cause
  `QuerySurfaceAttrib()` inefficiency on some back-ends that get width and
  height of the surface differently (`SurfaceEGL` for example). In such
  cases `getUserSize()` is overridden to avoid returning a dimension
  which is not required.
  
  After this change all places in the code that previously used both
  `getWidth/Height()` methods (like `Surface::getAttachmentSize()`) will
  be more efficient. The `QuerySurfaceAttrib()`, on the other hand, will
  have slightly more overhead on back-ends where base
  `SurfaceImpl::getUserSize()` method is used, which only happens on
  back-ends with trivial `getSize()` implementation.
  
  Bug: angleproject:397848903
  Change-Id: I4a22701a1e62ee4e7d07e77cac5b388050d98e4d
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6802440
  Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
  Commit-Queue: Igor Nazarov <i.nazarov@samsung.com>
  

Download

• src/libANGLE/renderer/gl/wgl/WindowSurfaceWGL.cpp

• //
  // Copyright 2015 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  
  // WindowSurfaceWGL.cpp: WGL implementation of egl::Surface for windows
  
  #include "libANGLE/renderer/gl/wgl/WindowSurfaceWGL.h"
  
  #include "common/debug.h"
  #include "libANGLE/renderer/gl/RendererGL.h"
  #include "libANGLE/renderer/gl/wgl/FunctionsWGL.h"
  #include "libANGLE/renderer/gl/wgl/wgl_utils.h"
  
  namespace rx
  {
  
  WindowSurfaceWGL::WindowSurfaceWGL(const egl::SurfaceState &state,
                                     EGLNativeWindowType window,
                                     int pixelFormat,
                                     const FunctionsWGL *functions,
                                     EGLint orientation)
      : SurfaceWGL(state),
        mPixelFormat(pixelFormat),
        mWindow(window),
        mDeviceContext(nullptr),
        mFunctionsWGL(functions),
        mSwapBehavior(0)
  {
      // EGL_ANGLE_surface_orientation is not supported for regular WGL window surfaces
      ASSERT(orientation == 0);
  }
  
  WindowSurfaceWGL::~WindowSurfaceWGL()
  {
      ReleaseDC(mWindow, mDeviceContext);
      mDeviceContext = nullptr;
  }
  
  egl::Error WindowSurfaceWGL::initialize(const egl::Display *display)
  {
      mDeviceContext = GetDC(mWindow);
      if (!mDeviceContext)
      {
          std::ostringstream err;
          err << "Failed to get the device context from the native window, "
              << gl::FmtErr(GetLastError());
          return egl::Error(EGL_BAD_NATIVE_WINDOW, err.str());
      }
  
      // Require that the pixel format for this window has not been set yet or is equal to the
      // Display's pixel format.
      int windowPixelFormat = GetPixelFormat(mDeviceContext);
      if (windowPixelFormat == 0)
      {
          PIXELFORMATDESCRIPTOR pixelFormatDescriptor = {};
          if (!DescribePixelFormat(mDeviceContext, mPixelFormat, sizeof(pixelFormatDescriptor),
                                   &pixelFormatDescriptor))
          {
              std::ostringstream err;
              err << "Failed to DescribePixelFormat, " << gl::FmtErr(GetLastError());
              return egl::Error(EGL_BAD_NATIVE_WINDOW, err.str());
          }
  
          if (!SetPixelFormat(mDeviceContext, mPixelFormat, &pixelFormatDescriptor))
          {
              std::ostringstream err;
              err << "Failed to set the pixel format on the device context, "
                  << gl::FmtErr(GetLastError());
              return egl::Error(EGL_NOT_INITIALIZED, err.str());
          }
      }
      else if (windowPixelFormat != mPixelFormat)
      {
          return egl::Error(EGL_NOT_INITIALIZED,
                            "Pixel format of the NativeWindow and NativeDisplayType must match.");
      }
  
      // Check for the swap behavior of this pixel format
      switch (
          wgl::QueryWGLFormatAttrib(mDeviceContext, mPixelFormat, WGL_SWAP_METHOD_ARB, mFunctionsWGL))
      {
          case WGL_SWAP_COPY_ARB:
              mSwapBehavior = EGL_BUFFER_PRESERVED;
              break;
  
          case WGL_SWAP_EXCHANGE_ARB:
          case WGL_SWAP_UNDEFINED_ARB:
          default:
              mSwapBehavior = EGL_BUFFER_DESTROYED;
              break;
      }
  
      return egl::NoError();
  }
  
  egl::Error WindowSurfaceWGL::makeCurrent(const gl::Context *context)
  {
      return egl::NoError();
  }
  
  egl::Error WindowSurfaceWGL::swap(const gl::Context *context, SurfaceSwapFeedback *feedback)
  {
      if (!mFunctionsWGL->swapBuffers(mDeviceContext))
      {
          // TODO: What error type here?
          return egl::Error(EGL_CONTEXT_LOST, "Failed to swap buffers on the child window.");
      }
  
      return egl::NoError();
  }
  
  egl::Error WindowSurfaceWGL::postSubBuffer(const gl::Context *context,
                                             EGLint x,
                                             EGLint y,
                                             EGLint width,
                                             EGLint height)
  {
      UNIMPLEMENTED();
      return egl::NoError();
  }
  
  egl::Error WindowSurfaceWGL::querySurfacePointerANGLE(EGLint attribute, void **value)
  {
      *value = nullptr;
      return egl::NoError();
  }
  
  egl::Error WindowSurfaceWGL::bindTexImage(const gl::Context *context,
                                            gl::Texture *texture,
                                            EGLint buffer)
  {
      UNIMPLEMENTED();
      return egl::NoError();
  }
  
  egl::Error WindowSurfaceWGL::releaseTexImage(const gl::Context *context, EGLint buffer)
  {
      UNIMPLEMENTED();
      return egl::NoError();
  }
  
  void WindowSurfaceWGL::setSwapInterval(const egl::Display *display, EGLint interval)
  {
      if (mFunctionsWGL->swapIntervalEXT)
      {
          mFunctionsWGL->swapIntervalEXT(interval);
      }
  }
  
  gl::Extents WindowSurfaceWGL::getSize() const
  {
      RECT rect;
      if (!GetClientRect(mWindow, &rect))
      {
          return gl::Extents(0, 0, 1);
      }
      return gl::Extents(rect.right - rect.left, rect.bottom - rect.top, 1);
  }
  
  EGLint WindowSurfaceWGL::isPostSubBufferSupported() const
  {
      // PostSubBuffer extension not exposed on WGL.
      UNIMPLEMENTED();
      return EGL_FALSE;
  }
  
  EGLint WindowSurfaceWGL::getSwapBehavior() const
  {
      return mSwapBehavior;
  }
  
  HDC WindowSurfaceWGL::getDC() const
  {
      return mDeviceContext;
  }
  }  // namespace rx
  

Download