kc3-lang/angle/src/libANGLE/renderer/null/ContextNULL.h

Branch - branch -main

• Show log

  Commit

• Hash : b4d84458
  Author :
  Date : 2025-05-23T18:08:19
  

  Move Buffer from VertexBinding to VertexArray
  
  In later CL we will not taking shared context lock for certain
  VertexArray API calls. VertexArray itself is per context, so this sounds
  reasonable to do. The main challenge here is a lot of VertexArray
  function end up accessing gl::Buffer object, which could be modified by
  other shared contexts. In order to safely not taking the shared context
  lock, we need to separate out Buffer object out of VertexArray itself so
  that these lockless APIs will take VertexArray that does not have access
  to buffer.
  
  In this CL, VertexArray is split into two classes: VertexArrayPrivate is
  everything in VertexArray except buffers. VertexArray is a subclass of
  VertexArrayPrivate and owns all the buffers. Buffer is removed from
  gl::VertexBinding class. In order to let back end access to buffers,
  VertexArrayImpl holds a weak reference to
  VertexArray::mVertexArrayBuffers (which is a vector of buffers).
  Further, VertexArrayBufferBindingMask mBufferBindingMask is moved from
  VertexArrayState into VertexArray class well, since it tracks which
  index has a non-null buffer. The bulk of change are due to the
  VertexARrayImpl constructor change, since it now takes
  vertexArrayBuffers argument. Other bulk of changes are due to
  VertexBinding no long has the buffer, but you need to get it directly
  from VertexArray or VertexArrayImpl.
  
  This CL also reverts some of the change in crrev.com/c/6758215 that
  mVertexBindings no longer contains kElementArrayBufferIndex.
  
  BYPASS_LARGE_CHANGE_WARNING
  
  Bug: b/433331119
  Change-Id: I15f4576f7c5c8d8f4d9c9c07d38a60ce539bfeea
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6774702
  Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
  Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
  Commit-Queue: Charlie Lao <cclao@google.com>
  

Download

• src/libANGLE/renderer/null/ContextNULL.h

• //
  // Copyright 2016 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  // ContextNULL.h:
  //    Defines the class interface for ContextNULL, implementing ContextImpl.
  //
  
  #ifndef LIBANGLE_RENDERER_NULL_CONTEXTNULL_H_
  #define LIBANGLE_RENDERER_NULL_CONTEXTNULL_H_
  
  #include "libANGLE/renderer/ContextImpl.h"
  
  namespace rx
  {
  
  class AllocationTrackerNULL : angle::NonCopyable
  {
    public:
      explicit AllocationTrackerNULL(size_t maxTotalAllocationSize);
      ~AllocationTrackerNULL();
  
      // Check if it is possible to change an allocation from oldSize to newSize.  If it is possible,
      // the allocation is registered and true is returned else false is returned.
      bool updateMemoryAllocation(size_t oldSize, size_t newSize);
  
    private:
      size_t mAllocatedBytes;
      const size_t mMaxBytes;
  };
  
  class ContextNULL : public ContextImpl
  {
    public:
      ContextNULL(const gl::State &state,
                  gl::ErrorSet *errorSet,
                  AllocationTrackerNULL *allocationTracker);
      ~ContextNULL() override;
  
      angle::Result initialize(const angle::ImageLoadContext &imageLoadContext) override;
  
      // Flush and finish.
      angle::Result flush(const gl::Context *context) override;
      angle::Result finish(const gl::Context *context) override;
  
      // Drawing methods.
      angle::Result drawArrays(const gl::Context *context,
                               gl::PrimitiveMode mode,
                               GLint first,
                               GLsizei count) override;
      angle::Result drawArraysInstanced(const gl::Context *context,
                                        gl::PrimitiveMode mode,
                                        GLint first,
                                        GLsizei count,
                                        GLsizei instanceCount) override;
      angle::Result drawArraysInstancedBaseInstance(const gl::Context *context,
                                                    gl::PrimitiveMode mode,
                                                    GLint first,
                                                    GLsizei count,
                                                    GLsizei instanceCount,
                                                    GLuint baseInstance) override;
  
      angle::Result drawElements(const gl::Context *context,
                                 gl::PrimitiveMode mode,
                                 GLsizei count,
                                 gl::DrawElementsType type,
                                 const void *indices) override;
      angle::Result drawElementsBaseVertex(const gl::Context *context,
                                           gl::PrimitiveMode mode,
                                           GLsizei count,
                                           gl::DrawElementsType type,
                                           const void *indices,
                                           GLint baseVertex) override;
      angle::Result drawElementsInstanced(const gl::Context *context,
                                          gl::PrimitiveMode mode,
                                          GLsizei count,
                                          gl::DrawElementsType type,
                                          const void *indices,
                                          GLsizei instances) override;
      angle::Result drawElementsInstancedBaseVertex(const gl::Context *context,
                                                    gl::PrimitiveMode mode,
                                                    GLsizei count,
                                                    gl::DrawElementsType type,
                                                    const void *indices,
                                                    GLsizei instances,
                                                    GLint baseVertex) override;
      angle::Result drawElementsInstancedBaseVertexBaseInstance(const gl::Context *context,
                                                                gl::PrimitiveMode mode,
                                                                GLsizei count,
                                                                gl::DrawElementsType type,
                                                                const void *indices,
                                                                GLsizei instances,
                                                                GLint baseVertex,
                                                                GLuint baseInstance) override;
      angle::Result drawRangeElements(const gl::Context *context,
                                      gl::PrimitiveMode mode,
                                      GLuint start,
                                      GLuint end,
                                      GLsizei count,
                                      gl::DrawElementsType type,
                                      const void *indices) override;
      angle::Result drawRangeElementsBaseVertex(const gl::Context *context,
                                                gl::PrimitiveMode mode,
                                                GLuint start,
                                                GLuint end,
                                                GLsizei count,
                                                gl::DrawElementsType type,
                                                const void *indices,
                                                GLint baseVertex) override;
      angle::Result drawArraysIndirect(const gl::Context *context,
                                       gl::PrimitiveMode mode,
                                       const void *indirect) override;
      angle::Result drawElementsIndirect(const gl::Context *context,
                                         gl::PrimitiveMode mode,
                                         gl::DrawElementsType type,
                                         const void *indirect) override;
  
      angle::Result multiDrawArrays(const gl::Context *context,
                                    gl::PrimitiveMode mode,
                                    const GLint *firsts,
                                    const GLsizei *counts,
                                    GLsizei drawcount) override;
      angle::Result multiDrawArraysInstanced(const gl::Context *context,
                                             gl::PrimitiveMode mode,
                                             const GLint *firsts,
                                             const GLsizei *counts,
                                             const GLsizei *instanceCounts,
                                             GLsizei drawcount) override;
      angle::Result multiDrawArraysIndirect(const gl::Context *context,
                                            gl::PrimitiveMode mode,
                                            const void *indirect,
                                            GLsizei drawcount,
                                            GLsizei stride) override;
      angle::Result multiDrawElements(const gl::Context *context,
                                      gl::PrimitiveMode mode,
                                      const GLsizei *counts,
                                      gl::DrawElementsType type,
                                      const GLvoid *const *indices,
                                      GLsizei drawcount) override;
      angle::Result multiDrawElementsInstanced(const gl::Context *context,
                                               gl::PrimitiveMode mode,
                                               const GLsizei *counts,
                                               gl::DrawElementsType type,
                                               const GLvoid *const *indices,
                                               const GLsizei *instanceCounts,
                                               GLsizei drawcount) override;
      angle::Result multiDrawElementsIndirect(const gl::Context *context,
                                              gl::PrimitiveMode mode,
                                              gl::DrawElementsType type,
                                              const void *indirect,
                                              GLsizei drawcount,
                                              GLsizei stride) override;
      angle::Result multiDrawArraysInstancedBaseInstance(const gl::Context *context,
                                                         gl::PrimitiveMode mode,
                                                         const GLint *firsts,
                                                         const GLsizei *counts,
                                                         const GLsizei *instanceCounts,
                                                         const GLuint *baseInstances,
                                                         GLsizei drawcount) override;
      angle::Result multiDrawElementsInstancedBaseVertexBaseInstance(const gl::Context *context,
                                                                     gl::PrimitiveMode mode,
                                                                     const GLsizei *counts,
                                                                     gl::DrawElementsType type,
                                                                     const GLvoid *const *indices,
                                                                     const GLsizei *instanceCounts,
                                                                     const GLint *baseVertices,
                                                                     const GLuint *baseInstances,
                                                                     GLsizei drawcount) override;
  
      // Device loss
      gl::GraphicsResetStatus getResetStatus() override;
  
      // EXT_debug_marker
      angle::Result insertEventMarker(GLsizei length, const char *marker) override;
      angle::Result pushGroupMarker(GLsizei length, const char *marker) override;
      angle::Result popGroupMarker() override;
  
      // KHR_debug
      angle::Result pushDebugGroup(const gl::Context *context,
                                   GLenum source,
                                   GLuint id,
                                   const std::string &message) override;
      angle::Result popDebugGroup(const gl::Context *context) override;
  
      // State sync with dirty bits.
      angle::Result syncState(const gl::Context *context,
                              const gl::state::DirtyBits dirtyBits,
                              const gl::state::DirtyBits bitMask,
                              const gl::state::ExtendedDirtyBits extendedDirtyBits,
                              const gl::state::ExtendedDirtyBits extendedBitMask,
                              gl::Command command) override;
  
      // Disjoint timer queries
      GLint getGPUDisjoint() override;
      GLint64 getTimestamp() override;
  
      // Context switching
      angle::Result onMakeCurrent(const gl::Context *context) override;
  
      // Native capabilities, unmodified by gl::Context.
      gl::Caps getNativeCaps() const override;
      const gl::TextureCapsMap &getNativeTextureCaps() const override;
      const gl::Extensions &getNativeExtensions() const override;
      const gl::Limitations &getNativeLimitations() const override;
      const ShPixelLocalStorageOptions &getNativePixelLocalStorageOptions() const override;
  
      // Shader creation
      CompilerImpl *createCompiler() override;
      ShaderImpl *createShader(const gl::ShaderState &data) override;
      ProgramImpl *createProgram(const gl::ProgramState &data) override;
      ProgramExecutableImpl *createProgramExecutable(
          const gl::ProgramExecutable *executable) override;
  
      // Framebuffer creation
      FramebufferImpl *createFramebuffer(const gl::FramebufferState &data) override;
  
      // Texture creation
      TextureImpl *createTexture(const gl::TextureState &state) override;
  
      // Renderbuffer creation
      RenderbufferImpl *createRenderbuffer(const gl::RenderbufferState &state) override;
  
      // Buffer creation
      BufferImpl *createBuffer(const gl::BufferState &state) override;
  
      // Vertex Array creation
      VertexArrayImpl *createVertexArray(const gl::VertexArrayState &data,
                                         const gl::VertexArrayBuffers &vertexArrayBuffers) override;
  
      // Query and Fence creation
      QueryImpl *createQuery(gl::QueryType type) override;
      FenceNVImpl *createFenceNV() override;
      SyncImpl *createSync() override;
  
      // Transform Feedback creation
      TransformFeedbackImpl *createTransformFeedback(
          const gl::TransformFeedbackState &state) override;
  
      // Sampler object creation
      SamplerImpl *createSampler(const gl::SamplerState &state) override;
  
      // Program Pipeline object creation
      ProgramPipelineImpl *createProgramPipeline(const gl::ProgramPipelineState &data) override;
  
      // Memory object creation.
      MemoryObjectImpl *createMemoryObject() override;
  
      // Semaphore creation.
      SemaphoreImpl *createSemaphore() override;
  
      // Overlay creation.
      OverlayImpl *createOverlay(const gl::OverlayState &state) override;
  
      angle::Result dispatchCompute(const gl::Context *context,
                                    GLuint numGroupsX,
                                    GLuint numGroupsY,
                                    GLuint numGroupsZ) override;
      angle::Result dispatchComputeIndirect(const gl::Context *context, GLintptr indirect) override;
  
      angle::Result memoryBarrier(const gl::Context *context, GLbitfield barriers) override;
      angle::Result memoryBarrierByRegion(const gl::Context *context, GLbitfield barriers) override;
  
      void handleError(GLenum errorCode,
                       const char *message,
                       const char *file,
                       const char *function,
                       unsigned int line);
  
    private:
      gl::Caps mCaps;
      gl::TextureCapsMap mTextureCaps;
      gl::Extensions mExtensions;
      gl::Limitations mLimitations;
      ShPixelLocalStorageOptions mPLSOptions;
  
      AllocationTrackerNULL *mAllocationTracker;
  };
  
  }  // namespace rx
  
  #endif  // LIBANGLE_RENDERER_NULL_CONTEXTNULL_H_
  

Download