kc3-lang/angle/src/libANGLE/renderer/vulkan/mac/DisplayVkMac.mm

Branch - branch -main

• Show log

  Commit

• Hash : cfb430c8
  Author :
  Date : 2025-02-10T13:19:05
  

  Remove angle::ErrorStream helper
  
  Most uses of the helper either use just the code or a fixed string,
  which compiles to a few instructions. Using this helper adds 200+ bytes
  of assembly to each use, due to the unneeded instantiation of
  ostringstream which allocates a buffer etc. The combined effect of this
  CL on an Android perf build is ~12KB (0.2%) reduction in size.
  
  The cases where the message is actually formatted are converted to an
  explicit use of ostringstream. Removing the helper so that the new code
  is explicit about the intent to use ostringstream, or an alternative way
  to format the message.
  
  Discovered accidentally while looking into size reduction due to
  __builtin_unreachable()
  
  Semi-automated code change, risk of copy-paste mistakes should be
  minimal.
  
  Bug: angleproject:394129077
  Change-Id: I47c2642d750d31416b08a1cfa435d5463c294e35
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6250078
  Commit-Queue: Roman Lavrov <romanl@google.com>
  Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
  Reviewed-by: Charlie Lao <cclao@google.com>
  

Download

• src/libANGLE/renderer/vulkan/mac/DisplayVkMac.mm

• //
  // Copyright 2019 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  // DisplayVkMac.mm:
  //    Implements methods from DisplayVkMac
  //
  
  #include "libANGLE/renderer/vulkan/mac/DisplayVkMac.h"
  
  #include <vulkan/vulkan.h>
  
  #include "libANGLE/renderer/vulkan/mac/IOSurfaceSurfaceVkMac.h"
  #include "libANGLE/renderer/vulkan/mac/WindowSurfaceVkMac.h"
  #include "libANGLE/renderer/vulkan/vk_caps_utils.h"
  #include "libANGLE/renderer/vulkan/vk_renderer.h"
  
  #import <Cocoa/Cocoa.h>
  
  namespace rx
  {
  
  DisplayVkMac::DisplayVkMac(const egl::DisplayState &state) : DisplayVk(state) {}
  
  bool DisplayVkMac::isValidNativeWindow(EGLNativeWindowType window) const
  {
      NSObject *layer = reinterpret_cast<NSObject *>(window);
      return [layer isKindOfClass:[CALayer class]];
  }
  
  SurfaceImpl *DisplayVkMac::createWindowSurfaceVk(const egl::SurfaceState &state,
                                                   EGLNativeWindowType window)
  {
      ASSERT(isValidNativeWindow(window));
      return new WindowSurfaceVkMac(state, window);
  }
  
  SurfaceImpl *DisplayVkMac::createPbufferFromClientBuffer(const egl::SurfaceState &state,
                                                           EGLenum buftype,
                                                           EGLClientBuffer clientBuffer,
                                                           const egl::AttributeMap &attribs)
  {
      ASSERT(buftype == EGL_IOSURFACE_ANGLE);
  
      return new IOSurfaceSurfaceVkMac(state, clientBuffer, attribs, mRenderer);
  }
  
  egl::ConfigSet DisplayVkMac::generateConfigs()
  {
      constexpr GLenum kColorFormats[] = {GL_BGRA8_EXT, GL_BGRX8_ANGLEX};
      return egl_vk::GenerateConfigs(kColorFormats, egl_vk::kConfigDepthStencilFormats, this);
  }
  
  void DisplayVkMac::checkConfigSupport(egl::Config *config)
  {
      // TODO(geofflang): Test for native support and modify the config accordingly.
      // anglebug.com/42261400
  }
  
  const char *DisplayVkMac::getWSIExtension() const
  {
      return VK_EXT_METAL_SURFACE_EXTENSION_NAME;
  }
  
  bool IsVulkanMacDisplayAvailable()
  {
      return true;
  }
  
  DisplayImpl *CreateVulkanMacDisplay(const egl::DisplayState &state)
  {
      return new DisplayVkMac(state);
  }
  
  void DisplayVkMac::generateExtensions(egl::DisplayExtensions *outExtensions) const
  {
      outExtensions->iosurfaceClientBuffer = true;
  
      DisplayVk::generateExtensions(outExtensions);
  }
  
  egl::Error DisplayVkMac::validateClientBuffer(const egl::Config *configuration,
                                                EGLenum buftype,
                                                EGLClientBuffer clientBuffer,
                                                const egl::AttributeMap &attribs) const
  {
      ASSERT(buftype == EGL_IOSURFACE_ANGLE);
  
      if (!IOSurfaceSurfaceVkMac::ValidateAttributes(this, clientBuffer, attribs))
      {
          return egl::Error(EGL_BAD_ATTRIBUTE);
      }
      return egl::NoError();
  }
  
  }  // namespace rx
  

Download