kc3-lang/angle/src/tests/compiler_tests/PruneEmptyCases_test.cpp

Branch - branch -main

• Show log

  Commit

• Hash : 6f80f0f0
  Author :
  Date : 2022-08-06T02:29:19
  

  Translator: Clean up the compile flag passing interface
  
  Historically, compile flags were sent to the translator as a bitmask.
  Recently, we were getting close to running out of bits.  Additionally,
  direct-to-metal work had started to introduce constants to be passed to
  the translator, which were misplaced in ShBuiltInResources and Caps.
  Recent work on Pixel Local Storage adds even more constants, aggravating
  the situation.
  
  In this change, the interface to passing compile flags is reworked.  A
  struct is passed (instead of a bitmask) that has one bit for each flag.
  This can be indefinitely extended.  Additionally, the constants needed
  by metal and PLS are also placed in this struct.  In turn, the backends
  can set these options directly, and don't have to hack them into Caps to
  further get hacked into ShBuiltInResources.
  
  Bug: angleproject:7559
  Change-Id: If93f1e1b8818ad3a0ac708ab04ab93b4b397d114
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3812562
  Reviewed-by: Geoff Lang <geofflang@chromium.org>
  Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
  Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
  Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
  

Download

• src/tests/compiler_tests/PruneEmptyCases_test.cpp

• //
  // Copyright 2018 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  // PruneEmptyCases_test.cpp:
  //   Tests for pruning empty cases and switch statements. This ensures that the translator doesn't
  //   produce switch statements where the last case statement is not followed by anything.
  //
  
  #include "GLSLANG/ShaderLang.h"
  #include "angle_gl.h"
  #include "gtest/gtest.h"
  #include "tests/test_utils/compiler_test.h"
  
  using namespace sh;
  
  namespace
  {
  
  class PruneEmptyCasesTest : public MatchOutputCodeTest
  {
    public:
      PruneEmptyCasesTest() : MatchOutputCodeTest(GL_FRAGMENT_SHADER, SH_GLSL_COMPATIBILITY_OUTPUT) {}
  };
  
  // Test that a switch statement that only contains no-ops is pruned entirely.
  TEST_F(PruneEmptyCasesTest, SwitchStatementWithOnlyNoOps)
  {
      const std::string shaderString =
          R"(#version 300 es
  
          uniform int ui;
  
          void main(void)
          {
              int i = ui;
              switch (i)
              {
                  case 0:
                  case 1:
                      { {} }
                      int j;
                      1;
              }
          })";
      compile(shaderString);
      ASSERT_TRUE(notFoundInCode("switch"));
      ASSERT_TRUE(notFoundInCode("case"));
  }
  
  // Test that a init statement that has a side effect is preserved even if the switch is pruned.
  TEST_F(PruneEmptyCasesTest, SwitchStatementWithOnlyNoOpsAndInitWithSideEffect)
  {
      const std::string shaderString =
          R"(#version 300 es
  
          precision mediump float;
          out vec4 my_FragColor;
  
          uniform int uni_i;
  
          void main(void)
          {
              int i = uni_i;
              switch (++i)
              {
                  case 0:
                  case 1:
                      { {} }
                      int j;
                      1;
              }
              my_FragColor = vec4(i);
          })";
      compile(shaderString);
      ASSERT_TRUE(notFoundInCode("switch"));
      ASSERT_TRUE(notFoundInCode("case"));
      ASSERT_TRUE(foundInCode("++_ui"));
  }
  
  // Test a switch statement where the last case only contains no-ops.
  TEST_F(PruneEmptyCasesTest, SwitchStatementLastCaseOnlyNoOps)
  {
      const std::string shaderString =
          R"(#version 300 es
  
          precision mediump float;
          out vec4 my_FragColor;
  
          uniform int ui;
  
          void main(void)
          {
              int i = ui;
              switch (i)
              {
                  case 0:
                      my_FragColor = vec4(0);
                      break;
                  case 1:
                  case 2:
                      { {} }
                      int j;
                      1;
              }
          })";
      compile(shaderString);
      ASSERT_TRUE(foundInCode("switch"));
      ASSERT_TRUE(foundInCode("case", 1));
  }
  
  }  // namespace
  

Download