kc3-lang/angle/src/tests/gl_tests/gles1/VertexPointerTest.cpp

Branch - branch -main

• Show log

  Commit

• Hash : 25390156
  Author :
  Date : 2025-08-21T00:13:19
  

  Suppress unsafe buffers on a file-by-file basis in src/ [1 of N]
  
  In this CL, we suppress many files but stop short of actually
  enabling the warning by not removing the line from the
  unsafe_buffers_paths.txt file. That will happen in a follow-on
  CL, along with resolving any stragglers missed here.
  
  This is mostly a manual change so as to familiarize myself with
  the kinds of issues faced by the Angle codebase when applying buffer
  safety warnings.
  
  -- Re-generate affected hashes.
  -- Clang-format applied to all changed files.
  -- Add a few missing .reserve() calls to vectors as noticed.
  -- Fix some mismatches between file names and header comments.
  -- Be more consistent with header comment format (blank lines and
     trailing //-only lines when a filename comment adjoins license
     boilerplate).
  
  Bug: b/436880895
  Change-Id: I3bde5cc2059acbe8345057289214f1a26f1c34aa
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6869022
  Reviewed-by: Geoff Lang <geofflang@chromium.org>
  Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
  Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
  

Download

• src/tests/gl_tests/gles1/VertexPointerTest.cpp

• //
  // Copyright 2018 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  
  // VertexPointerTest.cpp: Tests basic usage of built-in vertex attributes of GLES1.
  
  #ifdef UNSAFE_BUFFERS_BUILD
  #    pragma allow_unsafe_buffers
  #endif
  
  #include "test_utils/ANGLETest.h"
  #include "test_utils/gl_raii.h"
  
  using namespace angle;
  
  class VertexPointerTest : public ANGLETest<>
  {
    protected:
      VertexPointerTest()
      {
          setWindowWidth(32);
          setWindowHeight(32);
          setConfigRedBits(8);
          setConfigGreenBits(8);
          setConfigBlueBits(8);
          setConfigAlphaBits(8);
          setConfigDepthBits(24);
      }
  };
  
  // Checks that we can assign to client side vertex arrays
  TEST_P(VertexPointerTest, AssignRetrieve)
  {
      std::vector<float> testVertexAttribute = {
          1.0f, 1.0f, 1.0f, 1.0f, 1.0f, 1.0f, 1.0f, 1.0f, 1.0f, 1.0f,
          1.0f, 1.0f, 1.0f, 1.0f, 1.0f, 1.0f, 1.0f, 1.0f, 1.0f, 1.0f,
      };
  
      glVertexPointer(4, GL_FLOAT, 0, testVertexAttribute.data());
      EXPECT_GL_NO_ERROR();
  
      void *ptr = nullptr;
      glGetPointerv(GL_VERTEX_ARRAY_POINTER, &ptr);
      EXPECT_EQ(testVertexAttribute.data(), ptr);
  
      glColorPointer(4, GL_FLOAT, 0, testVertexAttribute.data() + 4);
      glGetPointerv(GL_COLOR_ARRAY_POINTER, &ptr);
      EXPECT_EQ(testVertexAttribute.data() + 4, ptr);
  
      glNormalPointer(GL_FLOAT, 0, testVertexAttribute.data() + 8);
      glGetPointerv(GL_NORMAL_ARRAY_POINTER, &ptr);
      EXPECT_EQ(testVertexAttribute.data() + 8, ptr);
  
      glPointSizePointerOES(GL_FLOAT, 0, testVertexAttribute.data() + 8);
      glGetPointerv(GL_POINT_SIZE_ARRAY_POINTER_OES, &ptr);
      EXPECT_EQ(testVertexAttribute.data() + 8, ptr);
  
      GLint maxTextureUnits;
      glGetIntegerv(GL_MAX_TEXTURE_UNITS, &maxTextureUnits);
      for (int i = 0; i < maxTextureUnits; i++)
      {
          glClientActiveTexture(GL_TEXTURE0 + i);
          glTexCoordPointer(4, GL_FLOAT, 0, testVertexAttribute.data() + i * 4);
          glGetPointerv(GL_TEXTURE_COORD_ARRAY_POINTER, &ptr);
          EXPECT_EQ(testVertexAttribute.data() + i * 4, ptr);
      }
  }
  
  // Checks that we can assign to client side vertex arrays with color vertex attributes of type
  // GLubyte
  TEST_P(VertexPointerTest, AssignRetrieveColorUnsignedByte)
  {
      std::vector<float> testVertexAttribute = {
          1.0f,
          1.0f,
          1.0f,
          1.0f,
      };
  
      std::vector<GLubyte> testColorAttribute = {
          1,
          1,
          1,
          1,
      };
  
      glVertexPointer(4, GL_FLOAT, 0, testVertexAttribute.data());
      EXPECT_GL_NO_ERROR();
  
      void *ptr = nullptr;
      glGetPointerv(GL_VERTEX_ARRAY_POINTER, &ptr);
      EXPECT_EQ(testVertexAttribute.data(), ptr);
  
      glColorPointer(4, GL_UNSIGNED_BYTE, 0, testColorAttribute.data());
      glGetPointerv(GL_COLOR_ARRAY_POINTER, &ptr);
      EXPECT_EQ(testColorAttribute.data(), ptr);
      ASSERT_GL_NO_ERROR();
  }
  
  ANGLE_INSTANTIATE_TEST_ES1(VertexPointerTest);
  

Download