Branch
Hash :
0d441eda
Author :
Date :
2025-05-29T12:04:46
util: Give all ConfigParameters default values ConfigParameters has a mix of 'bool' and 'Optional<bool>', with some tests setting the Optional<> values to the default value, inadvertently creating a dependency on the associated extension. To reduce the dependency on various extensions and allow more tests to run, update ConfigParameters to only contain raw bools and initialize them to the default values defined by the associated spec. This allows EGLWindow to only require the necessary extension when a non-default value is set by a test. This also requires updates to a handful of tests which were relying on the state of extensions due to non-default values. Bug: b/279980674 Change-Id: I77a7e102559e4393aadcdbf37886ae80cbbb9e29 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6618033 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291
//
// Copyright 2014 The ANGLE Project Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
#ifndef UTIL_EGLWINDOW_H_
#define UTIL_EGLWINDOW_H_
#include <stdint.h>
#include <list>
#include <memory>
#include <string>
#include "common/Optional.h"
#include "common/PackedEnums.h"
#include "common/angleutils.h"
#include "util/EGLPlatformParameters.h"
#include "util/util_export.h"
#include "util/util_gl.h"
class OSWindow;
namespace angle
{
class Library;
struct PlatformMethods;
using GenericProc = void (*)();
} // namespace angle
struct ANGLE_UTIL_EXPORT ConfigParameters
{
ConfigParameters();
~ConfigParameters();
void reset();
// Surface and Context parameters.
int redBits;
int greenBits;
int blueBits;
int alphaBits;
int depthBits;
int stencilBits;
bool webGLCompatibility;
bool robustResourceInit;
// EGLWindow-specific.
EGLenum componentType;
bool multisample;
bool debug;
bool noError;
bool extensionsEnabled;
bool bindGeneratesResource;
bool clientArraysEnabled;
bool robustAccess;
bool mutableRenderBuffer;
EGLint samples;
bool contextProgramCacheEnabled;
EGLenum resetStrategy;
EGLenum colorSpace;
EGLint swapInterval;
};
using GLWindowContext = struct GLWindowHandleContext_T *;
enum class GLWindowResult
{
NoError,
NoColorspaceSupport,
NoMutableRenderBufferSupport,
Error,
};
class ANGLE_UTIL_EXPORT GLWindowBase : angle::NonCopyable
{
public:
static void Delete(GLWindowBase **window);
using Image = void *;
using ClientBuffer = void *;
using Enum = unsigned int;
using Attrib = intptr_t;
using AttribKHR = khronos_int32_t;
using Boolean = unsigned int;
using Surface = void *;
using Sync = void *;
using Display = void *;
// It should also be possible to set multisample and floating point framebuffers.
EGLint getClientMajorVersion() const { return mClientMajorVersion; }
EGLint getClientMinorVersion() const { return mClientMinorVersion; }
virtual bool initializeGL(OSWindow *osWindow,
angle::Library *glWindowingLibrary,
angle::GLESDriverType driverType,
const EGLPlatformParameters &platformParams,
const ConfigParameters &configParams) = 0;
virtual GLWindowResult initializeGLWithResult(OSWindow *osWindow,
angle::Library *glWindowingLibrary,
angle::GLESDriverType driverType,
const EGLPlatformParameters &platformParams,
const ConfigParameters &configParams) = 0;
virtual bool isGLInitialized() const = 0;
virtual void swap() = 0;
virtual void destroyGL() = 0;
virtual bool makeCurrent() = 0;
virtual bool hasError() const = 0;
virtual bool setSwapInterval(EGLint swapInterval) = 0;
virtual angle::GenericProc getProcAddress(const char *name) = 0;
// EGLContext and HGLRC (WGL) are both "handles", which are implemented as pointers.
// Use void* here and let the underlying implementation handle interpreting the type correctly.
virtual GLWindowContext getCurrentContextGeneric() = 0;
virtual GLWindowContext createContextGeneric(GLWindowContext share) = 0;
virtual bool makeCurrentGeneric(GLWindowContext context) = 0;
virtual Image createImage(GLWindowContext context,
Enum target,
ClientBuffer buffer,
const Attrib *attrib_list) = 0;
virtual Image createImageKHR(GLWindowContext context,
Enum target,
ClientBuffer buffer,
const AttribKHR *attrib_list) = 0;
virtual EGLBoolean destroyImage(Image image) = 0;
virtual EGLBoolean destroyImageKHR(Image image) = 0;
virtual Sync createSync(EGLDisplay dpy, EGLenum type, const EGLAttrib *attrib_list) = 0;
virtual Sync createSyncKHR(EGLDisplay dpy, EGLenum type, const EGLint *attrib_list) = 0;
virtual EGLBoolean destroySync(EGLDisplay dpy, Sync sync) = 0;
virtual EGLBoolean destroySyncKHR(EGLDisplay dpy, Sync sync) = 0;
virtual EGLint clientWaitSync(EGLDisplay dpy, Sync sync, EGLint flags, EGLTimeKHR timeout) = 0;
virtual EGLint clientWaitSyncKHR(EGLDisplay dpy,
Sync sync,
EGLint flags,
EGLTimeKHR timeout) = 0;
virtual EGLint getEGLError() = 0;
virtual Display getCurrentDisplay() = 0;
virtual Surface createPbufferSurface(const EGLint *attrib_list) = 0;
virtual EGLBoolean destroySurface(Surface surface) = 0;
virtual EGLBoolean bindTexImage(EGLSurface surface, EGLint buffer) = 0;
virtual EGLBoolean releaseTexImage(EGLSurface surface, EGLint buffer) = 0;
virtual bool makeCurrent(EGLSurface draw, EGLSurface read, EGLContext context) = 0;
bool isMultisample() const { return mConfigParams.multisample; }
bool isDebugEnabled() const { return mConfigParams.debug; }
const angle::PlatformMethods *getPlatformMethods() const { return mPlatform.platformMethods; }
const EGLPlatformParameters &getPlatform() const { return mPlatform; }
const ConfigParameters &getConfigParams() const { return mConfigParams; }
virtual bool isFeatureEnabled(angle::Feature feature) { return false; }
protected:
GLWindowBase(EGLint glesMajorVersion, EGLint glesMinorVersion);
virtual ~GLWindowBase();
EGLint mClientMajorVersion;
EGLint mClientMinorVersion;
EGLPlatformParameters mPlatform;
ConfigParameters mConfigParams;
};
enum class ANGLEFeatureStatus
{
Enabled,
Disabled,
Unknown,
};
using ANGLEFeatureArray = angle::PackedEnumMap<angle::Feature, ANGLEFeatureStatus>;
class ANGLE_UTIL_EXPORT EGLWindow : public GLWindowBase
{
public:
static EGLWindow *New(EGLint glesMajorVersion, EGLint glesMinorVersion);
static void Delete(EGLWindow **window);
static EGLBoolean FindEGLConfig(EGLDisplay dpy, const EGLint *attrib_list, EGLConfig *config);
EGLConfig getConfig() const;
EGLDisplay getDisplay() const;
EGLSurface getSurface() const;
EGLContext getContext() const;
bool isContextVersion(EGLint glesMajorVersion, EGLint glesMinorVersion) const;
// Internally initializes the Display, Surface and Context.
bool initializeGL(OSWindow *osWindow,
angle::Library *glWindowingLibrary,
angle::GLESDriverType driverType,
const EGLPlatformParameters &platformParams,
const ConfigParameters &configParams) override;
GLWindowResult initializeGLWithResult(OSWindow *osWindow,
angle::Library *glWindowingLibrary,
angle::GLESDriverType driverType,
const EGLPlatformParameters &platformParams,
const ConfigParameters &configParams) override;
bool isGLInitialized() const override;
void swap() override;
void destroyGL() override;
bool makeCurrent() override;
bool hasError() const override;
bool setSwapInterval(EGLint swapInterval) override;
angle::GenericProc getProcAddress(const char *name) override;
// Initializes EGL resources.
GLWindowContext getCurrentContextGeneric() override;
GLWindowContext createContextGeneric(GLWindowContext share) override;
bool makeCurrentGeneric(GLWindowContext context) override;
// Only initializes the Display.
bool initializeDisplay(OSWindow *osWindow,
angle::Library *glWindowingLibrary,
angle::GLESDriverType driverType,
const EGLPlatformParameters ¶ms);
// Only initializes the Surface.
GLWindowResult initializeSurface(OSWindow *osWindow,
angle::Library *glWindowingLibrary,
const ConfigParameters ¶ms);
// Create an EGL context with this window's configuration
EGLContext createContext(EGLContext share, EGLint *extraAttributes);
// Make the EGL context current
bool makeCurrent(EGLContext context);
Image createImage(GLWindowContext context,
Enum target,
ClientBuffer buffer,
const Attrib *attrib_list) override;
Image createImageKHR(GLWindowContext context,
Enum target,
ClientBuffer buffer,
const AttribKHR *attrib_list) override;
EGLBoolean destroyImage(Image image) override;
EGLBoolean destroyImageKHR(Image image) override;
Sync createSync(EGLDisplay dpy, EGLenum type, const EGLAttrib *attrib_list) override;
Sync createSyncKHR(EGLDisplay dpy, EGLenum type, const EGLint *attrib_list) override;
EGLBoolean destroySync(EGLDisplay dpy, Sync sync) override;
EGLBoolean destroySyncKHR(EGLDisplay dpy, Sync sync) override;
EGLint clientWaitSync(EGLDisplay dpy, Sync sync, EGLint flags, EGLTimeKHR timeout) override;
EGLint clientWaitSyncKHR(EGLDisplay dpy, Sync sync, EGLint flags, EGLTimeKHR timeout) override;
EGLint getEGLError() override;
Display getCurrentDisplay() override;
Surface createPbufferSurface(const EGLint *attrib_list) override;
EGLBoolean destroySurface(Surface surface) override;
EGLBoolean bindTexImage(EGLSurface surface, EGLint buffer) override;
EGLBoolean releaseTexImage(EGLSurface surface, EGLint buffer) override;
bool makeCurrent(EGLSurface draw, EGLSurface read, EGLContext context) override;
// Only initializes the Context.
bool initializeContext();
void destroySurface();
void destroyContext();
bool isDisplayInitialized() const { return mDisplay != EGL_NO_DISPLAY; }
// Get the status of features and cache them in mFeatures.
void queryFeatures();
// Return whether a feature is enabled. Features that don't exist in the backend have Unknown
// status, and are considered disabled for the purposes of this function.
bool isFeatureEnabled(angle::Feature feature) override;
private:
EGLWindow(EGLint glesMajorVersion, EGLint glesMinorVersion);
~EGLWindow() override;
EGLConfig mConfig;
EGLDisplay mDisplay;
EGLSurface mSurface;
EGLContext mContext;
EGLint mEGLMajorVersion;
EGLint mEGLMinorVersion;
ANGLEFeatureArray mFeatures;
};
#endif // UTIL_EGLWINDOW_H_