Hash :
3562e384
Author :
Date :
2017-09-16T13:03:36
Prefer https: URLs In Gnulib, Emacs, etc. we are changing ftp: and http: URLs to use https:, to discourage man-in-the-middle attacks when downloading software. The attached patch propagates these changes upstream to Automake. This patch does not affect files that Automake is downstream of, which I'll patch separately. Althouth the resources are not secret, plain HTTP is vulnerable to malicious routers that tamper with responses from GNU servers, and this sort of thing is all too common when people in some other countries browse US-based websites. See, for example: Aceto G, Botta A, Pescapé A, Awan MF, Ahmad T, Qaisar S. Analyzing internet censorship in Pakistan. RTSI 2016. https://dx.doi.org/10.1109/RTSI.2016.7740626 HTTPS is not a complete solution here, but it can be a significant help. The GNU project regularly serves up code to users, so we should take some care here.
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60
#! /bin/sh
# Copyright (C) 2013-2017 Free Software Foundation, Inc.
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 2, or (at your option)
# any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <https://www.gnu.org/licenses/>.
# Check that "make distcheck" overrides any --srcdir or --prefix flag
# (mistakenly) defined in $(AM_DISTCHECK_CONFIGURE_FLAGS) or
# $(DISTCHECK_CONFIGURE_FLAGS). See automake bug#14991.
. test-init.sh
echo AC_OUTPUT >> configure.ac
orig_cwd=$(pwd); export orig_cwd
cat > Makefile.am << 'END'
# configure should choke on non-absolute prefix or non-existent
# srcdir. We'll sanity-check that later.
AM_DISTCHECK_CONFIGURE_FLAGS = --srcdir am-src --prefix am-pfx
END
# Same comments as above applies.
DISTCHECK_CONFIGURE_FLAGS='--srcdir user-src --prefix user-pfx'
export DISTCHECK_CONFIGURE_FLAGS
$ACLOCAL
$AUTOMAKE
$AUTOCONF
# Sanity check: configure should choke on non-absolute prefix
# or non-existent srcdir.
./configure --prefix foobar 2>stderr && { cat stderr >&2; exit 99; }
cat stderr >&2
grep "expected an absolute directory name for --prefix" stderr || exit 99
./configure --srcdir foobar 2>stderr && { cat stderr >&2; exit 99; }
cat stderr >&2
grep "cannot find sources.* in foobar" stderr || exit 99
./configure
run_make -E -O distcheck
test ! -s stderr
# Sanity check: the flags have been actually seen.
$PERL -e 'undef $/; $_ = <>; s/ \\\n/ /g; print;' <stdout >t
grep '/configure .* --srcdir am-src' t || exit 99
grep '/configure .* --prefix am-pfx' t || exit 99
grep '/configure .* --srcdir user-src' t || exit 99
grep '/configure .* --prefix user-pfx' t || exit 99
: