Hash :
3562e384
Author :
Date :
2017-09-16T13:03:36
Prefer https: URLs In Gnulib, Emacs, etc. we are changing ftp: and http: URLs to use https:, to discourage man-in-the-middle attacks when downloading software. The attached patch propagates these changes upstream to Automake. This patch does not affect files that Automake is downstream of, which I'll patch separately. Althouth the resources are not secret, plain HTTP is vulnerable to malicious routers that tamper with responses from GNU servers, and this sort of thing is all too common when people in some other countries browse US-based websites. See, for example: Aceto G, Botta A, Pescapé A, Awan MF, Ahmad T, Qaisar S. Analyzing internet censorship in Pakistan. RTSI 2016. https://dx.doi.org/10.1109/RTSI.2016.7740626 HTTPS is not a complete solution here, but it can be a significant help. The GNU project regularly serves up code to users, so we should take some care here.
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103
#! /bin/sh
# Copyright (C) 2012-2017 Free Software Foundation, Inc.
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 2, or (at your option)
# any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <https://www.gnu.org/licenses/>.
# Check that user recursion can be made to work when $(SUBDIRS) are
# not "strictly" nested, as in e.g.:
# SUBDIRS = src external/lib external/tests
# with no Makefile in 'external'.
. test-init.sh
cat >> configure.ac <<'END'
AC_CONFIG_FILES(
sub1/Makefile
sub2/Makefile
dnl There's deliberately no 'sub3/Makefile'.
sub3/subsub/Makefile
sub4/Makefile
sub4/subsub/Makefile
)
AM_EXTRA_RECURSIVE_TARGETS([foo])
AC_OUTPUT
END
mkdir sub1 sub2 sub3 sub4 sub3/subsub sub4/subsub
cat > Makefile.am <<'END'
SUBDIRS = sub1 sub2 sub3/subsub sub4 sub4/subsub
foo-local:
echo _rootdir_ >foo
MOSTLYCLEANFILES = foo
.PHONY: test
test: foo
grep _rootdir_ foo
grep ':sub1:' sub1/foo
grep ',sub1,' sub1/bar
test ! -r sub2/foo
test ! -r sub3/foo
grep '%sub3/subsub%' sub3/subsub/quux
test ! -r sub3/subsub/foo
test ! -r sub4/foo
grep '=sub4/subsub=' sub4/subsub/foo
check-local: test
END
# A 'foo-local' target with dependencies shouldn't cause problems.
cat > sub1/Makefile.am <<'END'
foo-local: bar
sed 's/,/:/g' bar >foo
bar:
echo ',sub1,' >$@
MOSTLYCLEANFILES = foo bar
END
# The lack of a 'foo' target here shouldn't cause any error in
# automake nor in make.
: > sub2/Makefile.am
# The lack of file 'sub3/Makefile.am' shouldn't cause any problem either.
rm -f sub3/Makefile.am
# A 'foo-local' creating a file != 'foo' shouldn't cause any problem.
cat > sub3/subsub/Makefile.am <<'END'
foo-local:
echo '%sub3/subsub%' >quux
MOSTLYCLEANFILES = quux
END
# No 'foo-local' nor 'foo' target here ...
: > sub4/Makefile.am
# ... should not cause errors, nor cause the 'foo-local' target
# here not to be executed.
cat > sub4/subsub/Makefile.am <<'END'
foo-local:
echo '=sub4/subsub=' >foo
MOSTLYCLEANFILES = foo
END
$ACLOCAL
$AUTOCONF
$AUTOMAKE
./configure
$MAKE test
$MAKE distcheck
: