Hash :
3562e384
Author :
Date :
2017-09-16T13:03:36
Prefer https: URLs In Gnulib, Emacs, etc. we are changing ftp: and http: URLs to use https:, to discourage man-in-the-middle attacks when downloading software. The attached patch propagates these changes upstream to Automake. This patch does not affect files that Automake is downstream of, which I'll patch separately. Althouth the resources are not secret, plain HTTP is vulnerable to malicious routers that tamper with responses from GNU servers, and this sort of thing is all too common when people in some other countries browse US-based websites. See, for example: Aceto G, Botta A, Pescapé A, Awan MF, Ahmad T, Qaisar S. Analyzing internet censorship in Pakistan. RTSI 2016. https://dx.doi.org/10.1109/RTSI.2016.7740626 HTTPS is not a complete solution here, but it can be a significant help. The GNU project regularly serves up code to users, so we should take some care here.
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94
#! /bin/sh
# Copyright (C) 2003-2017 Free Software Foundation, Inc.
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 2, or (at your option)
# any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <https://www.gnu.org/licenses/>.
# Check for AM_LDFLAGS = -module
# Report from Kevin P. Fleming.
required=libtool
. test-init.sh
: > README
: > NEWS
: > AUTHORS
: > ChangeLog
: > ltconfig
: > ltmain.sh
: > config.guess
: > config.sub
cat >> configure.ac << 'END'
AC_PROG_CC
AM_PROG_AR
AC_PROG_LIBTOOL
AC_OUTPUT
END
: > Makefile.inc
cat > Makefile.am << 'END'
include Makefile.inc
lib_LTLIBRARIES = nonstandard.la
nonstandard_la_SOURCES = foo.c
FOO = -module
END
$ACLOCAL
AUTOMAKE_fails --add-missing --gnu
grep 'Makefile.am:2:.*nonstandard.la.*standard libtool library name' stderr
grep 'Makefile.am:2:.*libnonstandard.la' stderr
# We will use -Wno-gnu to disable the warning about setting LDFLAGS (below)
# Make sure nonstandard names are diagnosed anyway.
AUTOMAKE_fails --add-missing --gnu -Wno-gnu
grep 'Makefile.am:2:.*nonstandard.la.*standard libtool library name' stderr
grep 'Makefile.am:2:.*libnonstandard.la' stderr
# Make sure nonstandard_la_LDFLAGS is read even if LDFLAGS is used.
cat >Makefile.inc <<'EOF'
LDFLAGS = -lfoo
nonstandard_la_LDFLAGS = $(FOO)
EOF
$AUTOMAKE -Wno-gnu
# Make sure LDFLAGS is read even if nonstandard_la_LDFLAGS is used.
cat >Makefile.inc <<'EOF'
LDFLAGS = $(FOO)
nonstandard_la_LDFLAGS = -lfoo
EOF
$AUTOMAKE -Wno-gnu
# Make sure AM_LDFLAGS is not read if foo_LDFLAGS is used.
cat >Makefile.inc <<'EOF'
nonstandard_la_LDFLAGS = -lfoo
AM_LDFLAGS = -module
EOF
AUTOMAKE_fails
grep 'Makefile.am:2:.*nonstandard.la.*standard libtool library name' stderr
grep 'Makefile.am:2:.*libnonstandard.la' stderr
echo 'AM_LDFLAGS = -module' > Makefile.inc
$AUTOMAKE
# For module, Automake should not suggest the lib prefix.
cat > Makefile.am << 'END'
include Makefile.inc
lib_LTLIBRARIES = nonstandard
nonstandard_SOURCES = foo.c
FOO = -module
END
AUTOMAKE_fails
grep "Makefile.am:2:.*'nonstandard'.*standard libtool module name" stderr
grep 'Makefile.am:2:.*nonstandard.la' stderr