Hash :
5ddf1007
Author :
Date :
2012-10-27T16:41:39
tests: prefer including 'test-init.sh' rather than './defs'
This is a follow-up to today's commit v1.12.4-22-g0610fc8,
"tests: prepare to move ./defs to t/ax/test-init.sh"
* All tests: To run the common setup, use the command:
. test-init.sh
instead of the older, "historical" one:
. ./defs || exit 1
Note that the "|| exit 1" wasn't really useful, since the 'errexit'
shell flag is in effect in both './defs' and 'test-init.sh', and all
the known shells that are good enough to run the automake testsuite
do automatically exit with error when a sourced file cannot be found
(at least, they do so in non-interactive mode, which is the only
mode that concerns us in the testsuite).
* t/ax/tap-summary-aux.sh, t/ax/testsuite-summary-checks.sh: Likewise.
* gen-testsuite-part: Do the same in the generated tests.
Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70
#! /bin/sh
# Copyright (C) 2012 Free Software Foundation, Inc.
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 2, or (at your option)
# any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
# Due to how the handling of $(BUILT_SOURCES) is implemented in Automake-NG,
# a recursive make call in the recipe of any $(BUILT_SOURCES) (or of any of
# its prerequisites) might cause an infinite recursion (complete with fork
# bomb, yuck) if not handled correctly. Verify that this doesn't happen.
# For more background, see:
# <http://lists.gnu.org/archive/html/help-smalltalk/2012-08/msg00027.html>
# <http://lists.gnu.org/archive/html/automake-patches/2012-08/msg00052.html>
# Backported to improve coverage of mainline Automake.
required=GNUmake
. test-init.sh
echo AC_OUTPUT >> configure.ac
cat > Makefile.am << 'END'
BUILT_SOURCES = foo
.PHONY: build-foo
build-foo:
echo OK > foo
foo:
$(MAKE) build-foo
# If the bug is still present, we want this test to fail, not to actually
# go fork bomb and potentially crash the user machine. Take care of that.
is_too_deep := $(shell test $(MAKELEVEL) -lt 10 && echo no)
## Extra indentation here required to avoid confusing Automake.
ifeq ($(is_too_deep),no)
# All is ok.
else
$(error ::OOPS:: Recursion too deep, $(MAKELEVEL) levels)
endif
END
$ACLOCAL
$AUTOMAKE -Wno-portability
$AUTOCONF
./configure
$MAKE -n foo >output 2>&1 || { cat output; exit 1; }
cat output
test ! -f foo
# Guard against possible infinite recursion.
$FGREP '::OOPS::' output && exit 1
$MAKE foo >output 2>&1 || { cat output; exit 1; }
cat output
$MAKE foo
# Guard against possible infinite recursion.
$FGREP '::OOPS::' output && exit 1
: