Hash :
6bd70f6a
Author :
Date :
2012-05-25T18:49:07
[ng] maintcheck: some tweaks and fixlets
* syntax-checks.mk (sc_no_brace_variable_expansions): Do not complain
about ${MAKEVAR} usages in comments: they might be legitimate. This
change is not strictly required for mainline automake, but will help
in the Automake-NG branch.
* sc_tests_here_document_format: Relax a bit, so that usages like
"cout << "string" << endl;" in the test scripts (usages which can be
used in here documents defining C++ sources) are not flagged as uses
of bad delimiters for here documents. This change is not strictly
required for mainline automake, but will help in the Automake-NG
branch, and will anyway be more future proof w.r.t. possible future
testsuite additions.
(sc_tests_Exit_not_exit): Do not whitelist lines containing $PERL
explicitly (that was only required for one test); instead ...
* t/ext2.sh: ... use "exit (1)" instead of "exit 1" in the perl
invocation of the guilty script.
Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66
#!/bin/sh
# Copyright (C) 2002-2012 Free Software Foundation, Inc.
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 2, or (at your option)
# any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
# Regression test for a bug reported by Ladislav Strojil.
# Using different extensions for the same language should not
# output the build rules several times.
. ./defs || Exit 1
cat >>configure.ac <<EOF
AC_PROG_CXX
EOF
cat >Makefile.am <<EOF
bin_PROGRAMS = p q r
p_SOURCES = a.cc b.cpp c.cxx
q_SOURCES = sub/d.cc sub/e.cpp sub/f.cxx
r_SOURCES = g.cc h.cpp i.cxx
r_CXXFLAGS = -DFOO
EOF
$ACLOCAL
$AUTOMAKE
grep '\.o:' Makefile.in > rules
cat rules
# Here is an example of bogus output. The rules are output several
# times.
#| .cc.o:
#| d.o: sub/d.cc
#| e.o: sub/e.cpp
#| f.o: sub/f.cxx
#| r-g.o: g.cc
#| r-h.o: h.cpp
#| r-i.o: i.cxx
#| .cpp.o:
#| d.o: sub/d.cc
#| e.o: sub/e.cpp
#| f.o: sub/f.cxx
#| r-g.o: g.cc
#| r-h.o: h.cpp
#| r-i.o: i.cxx
#| .cxx.o:
#| #d.o: sub/d.cc
#| #e.o: sub/e.cpp
#| #f.o: sub/f.cxx
#| #r-g.o: g.cc
#| #r-h.o: h.cpp
#| #r-i.o: i.cxx
# Bail out if we find a duplicate.
$PERL -ne 'if (exists $a{$_}) { exit (1) } else { $a{$_} = 1 }' < rules