kc3-lang/automake/t/tests-environment-fd-redirect.sh

• Show log

  Commit

• Hash : c7cfa093
  Author :
  Date : 2013-05-21T20:22:17
  

  tests: run_make: options to do command redirection
  
  Let's improve the API of the 'run_make()' helper shell function by
  adding three new options:
  
    -O   Save the standard output from make on disk, in a regular file
         named 'stdout'.
  
    -E   Save the standard error from make on disk, in a regular file
         named 'stderr'.
  
    -M   Save both the standard output and standard error from make on
         disk, in a regular file named 'output'. This option supersedes
         both the '-O' and '-E' options.
  
  This new API has two main advantages.
  
    1. Its use will allow us to get rid of more cumbersome idioms
       like, e.g.,
  
         $MAKE check >stdout && { cat stdout; exit 1; }
         cat stdout
  
       That can now be substituted with a simpler one:
  
         run_make -e FAIL -O check
  
    2. More importantly, using the new API we will prevent any extra output
       from the shell traces of the code in run_make to be redirected along
       with the make stderr (where that was redirected).  This problem was
       present in usages like, e.g.,
  
         run_make TESTS=foo.test check 2>stderr && exit 1
         grep 'expected error message' stderr
  
       Such usages are now to be rewritten as follows:
  
         run_make -e FAIL -E TESTS=foo.test check
         grep 'expected error message' stderr
  
       ensuring that 'stderr' won't end up containing unrelated stuff.
  
  Note that we do not convert in bulk the old idioms and the use of
  redirected 'run_make' invocations with this patch.  We only convert
  some occurrences, to ensure that the new implementation of 'run_make'
  is sound enough.  More sweeping conversions will likely be done in
  follow-up patches.
  
  * t/ax/am-test-lib.sh (run_make): Enhance and implement the extended API.
  * t/tap-xfail-tests.sh: Use the new 'run_make' API.
  * t/test-driver-cond.sh: Likewise.
  * t/tests-environment-fd-redirect.sh: Likewise.
  * t/uninstall-fail.sh: Likewise.
  * t/yacc-dist-nobuild.sh: Likewise.
  
  Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
  

Download

• t/tests-environment-fd-redirect.sh

• #! /bin/sh
  # Copyright (C) 2011-2013 Free Software Foundation, Inc.
  #
  # This program is free software; you can redistribute it and/or modify
  # it under the terms of the GNU General Public License as published by
  # the Free Software Foundation; either version 2, or (at your option)
  # any later version.
  #
  # This program is distributed in the hope that it will be useful,
  # but WITHOUT ANY WARRANTY; without even the implied warranty of
  # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  # GNU General Public License for more details.
  #
  # You should have received a copy of the GNU General Public License
  # along with this program.  If not, see <http://www.gnu.org/licenses/>.
  
  # Test for a behaviour of 'TESTS_ENVIRONMENT' and 'AM_TESTS_ENVIRONMENT'
  # w.r.t. file descriptor redirections which, although undocumented,
  # is nonetheless required by Gnulib's 'tests/init.sh' and by coreutils'
  # testsuite.
  # The checked behaviour is that we can portably do file descriptor
  # redirections by placing them at the end of a {AM_,}TESTS_ENVIRONMENT
  # definition without a following semicolon.  The need to support this
  # is detailedly motivated by coreutils bug#8846:
  #   <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=8846>
  # and the following CC:ed thread on bug-autoconf list:
  #   <http://lists.gnu.org/archive/html/bug-autoconf/2011-06/msg00002.html>
  
  . test-init.sh
  
  cat >> configure.ac << 'END'
  AC_OUTPUT
  END
  
  # Use both a shell script and a perl script as tests,
  # for better coverage.
  
  cat >foo.test <<'END'
  #! /bin/sh
  set -e
  echo " " $0: foofoofoo >&8
  echo " " $0: barbarbar >&9
  END
  
  echo "#! $PERL -w" > bar.test
  cat >>bar.test <<'END'
  use warnings FATAL => 'all';
  use strict;
  open(FD8, ">&=8") or die "$!";
  open(FD9, ">&=9") or die "$!";
  print FD8 "  $0: 8888\n";
  print FD9 "  $0: 9999\n";
  END
  
  chmod a+x foo.test bar.test
  
  $ACLOCAL
  $AUTOCONF
  
  # Korn Shells seem more vulnerable to the issue highlighted in coreutils
  # bug#8846 than other shells are.  In particular, the default Korn Shell
  # on Debian GNU/Linux is affected by the issue.  So let's try to run our
  # test with a system Korn Shell too, if that's available.
  bin_ksh=:
  case $SHELL in
    ksh|*/ksh) ;;
    *) for d in /bin /usr/bin; do
         test -f $d/ksh && { bin_ksh=$d/ksh; break; }
       done;;
  esac
  
  for sh in "$SHELL" "$bin_ksh"; do
    test "$sh" = : && continue
    for pfx in AM_ ''; do
      unindent > Makefile.am <<END
        TESTS = foo.test bar.test
        ## No trailing semicolon here, *deliberately*.
        ${pfx}TESTS_ENVIRONMENT = 8>&1 9>&8
  END
      $AUTOMAKE -a
      CONFIG_SHELL="$sh" $sh ./configure CONFIG_SHELL="$sh"
      run_make -O VERBOSE=y check
      grep '[ /]foo\.test: foofoofoo$' stdout
      grep '[ /]foo\.test: barbarbar$' stdout
      grep '[ /]bar\.test: 8888$' stdout
      grep '[ /]bar\.test: 9999$' stdout
      $EGREP '(foofoofoo|barbarbar|8888|9999)' foo.log && exit 1
      : # For shells with buggy 'set -e'.
    done
  done
  
  :
  

Download