kc3-lang/automake/t/uninstall-fail.sh

• Show log

  Commit

• Hash : c7cfa093
  Author :
  Date : 2013-05-21T20:22:17
  

  tests: run_make: options to do command redirection
  
  Let's improve the API of the 'run_make()' helper shell function by
  adding three new options:
  
    -O   Save the standard output from make on disk, in a regular file
         named 'stdout'.
  
    -E   Save the standard error from make on disk, in a regular file
         named 'stderr'.
  
    -M   Save both the standard output and standard error from make on
         disk, in a regular file named 'output'. This option supersedes
         both the '-O' and '-E' options.
  
  This new API has two main advantages.
  
    1. Its use will allow us to get rid of more cumbersome idioms
       like, e.g.,
  
         $MAKE check >stdout && { cat stdout; exit 1; }
         cat stdout
  
       That can now be substituted with a simpler one:
  
         run_make -e FAIL -O check
  
    2. More importantly, using the new API we will prevent any extra output
       from the shell traces of the code in run_make to be redirected along
       with the make stderr (where that was redirected).  This problem was
       present in usages like, e.g.,
  
         run_make TESTS=foo.test check 2>stderr && exit 1
         grep 'expected error message' stderr
  
       Such usages are now to be rewritten as follows:
  
         run_make -e FAIL -E TESTS=foo.test check
         grep 'expected error message' stderr
  
       ensuring that 'stderr' won't end up containing unrelated stuff.
  
  Note that we do not convert in bulk the old idioms and the use of
  redirected 'run_make' invocations with this patch.  We only convert
  some occurrences, to ensure that the new implementation of 'run_make'
  is sound enough.  More sweeping conversions will likely be done in
  follow-up patches.
  
  * t/ax/am-test-lib.sh (run_make): Enhance and implement the extended API.
  * t/tap-xfail-tests.sh: Use the new 'run_make' API.
  * t/test-driver-cond.sh: Likewise.
  * t/tests-environment-fd-redirect.sh: Likewise.
  * t/uninstall-fail.sh: Likewise.
  * t/yacc-dist-nobuild.sh: Likewise.
  
  Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
  

Download

• t/uninstall-fail.sh

• #! /bin/sh
  # Copyright (C) 2011-2013 Free Software Foundation, Inc.
  #
  # This program is free software; you can redistribute it and/or modify
  # it under the terms of the GNU General Public License as published by
  # the Free Software Foundation; either version 2, or (at your option)
  # any later version.
  #
  # This program is distributed in the hope that it will be useful,
  # but WITHOUT ANY WARRANTY; without even the implied warranty of
  # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  # GNU General Public License for more details.
  #
  # You should have received a copy of the GNU General Public License
  # along with this program.  If not, see <http://www.gnu.org/licenses/>.
  
  # "make uninstall" complains and errors out on failures.
  
  # FIXME: this test only deal with DATA primary; maybe we need sister
  # tests for other primaries too?  E.g., SCRIPTS, PROGRAMS, LISP, PYTHON,
  # etc...
  
  . test-init.sh
  
  mkdir d
  : > d/f
  chmod a-w d || skip "cannot make directories unwritable"
  
  # On Solaris 10, if '/bin/rm' is run with the '-f' option, it doesn't
  # print any error message when failing to remove a file (due to e.g.,
  # "Permission denied").  And it gets weirder.  On OpenIndiana 11, the
  # /bin/sh shell (in many respects a decent POSIX shell) seems to somehow
  # "eat" the error message from 'rm' in some situation, although the 'rm'
  # utility itself correctly prints it when invoked from (say) 'env' or
  # 'bash'.  Yikes.
  # We'll cater to these incompatibilities by relaxing a test below if
  # a faulty shell or 'rm' program is detected.
  st=0; $SHELL -c 'rm -f d/f' 2>stderr || st=$?
  cat stderr >&2
  test $st -gt 0 || skip_ "can delete files from unwritable directories"
  if grep 'rm:' stderr; then
    rm_f_is_silent_on_error=no
  else
    rm_f_is_silent_on_error=yes
  fi
  
  cat >> configure.ac << 'END'
  AC_OUTPUT
  END
  
  cat > Makefile.am << 'END'
  data_DATA = foobar.txt
  END
  
  : > foobar.txt
  
  $ACLOCAL
  $AUTOMAKE
  $AUTOCONF
  
  # Weird name, to make it harder to experience false positives when
  # grepping error messages.
  inst=__inst-dir__
  
  ./configure --prefix="$(pwd)/$inst"
  
  mkdir $inst $inst/share
  : > $inst/share/foobar.txt
  
  chmod a-w $inst/share
  run_make -M -e FAIL uninstall
  if test $rm_f_is_silent_on_error = yes; then
    : "rm -f" is silent on errors, skip the grepping of make output
  else
    grep "rm: .*foobar\.txt" output
  fi
  
  chmod a-rwx $inst/share
  (cd $inst/share) && skip_ "cannot make directories fully unreadable"
  
  run_make -M -e FAIL uninstall
  
  # Some shells, like Solaris 10 /bin/ksh and /usr/xpg4/bin/sh, do not
  # report the name of the 'cd' builtin upon a chdir error:
  #
  #   $ /bin/ksh -c 'cd /none'
  #   /bin/ksh: /none: not found
  #
  # and also print a line number in the error message *if the command
  # contains newlines*:
  #
  #   $ /bin/ksh -c 'cd unreadable'
  #   /bin/ksh: unreadable: permission denied
  #   $ /bin/ksh -c '\
  #   > \
  #   > cd unreadable'
  #   /bin/ksh[3]: unreadable: permission denied
  
  $EGREP "(cd|sh)(\[[0-9]*[0-9]\])?: .*$inst/share" output
  
  :
  

Download