kc3-lang/automake/t/yflags-cmdline-override.sh

• Show log

  Commit

• Hash : ffd4ecc9
  Author :
  Date : 2013-05-20T11:23:01
  

  tests: better idiom to override make macro defs on the cmdline
  
  We now do so with a new wrapper shell function 'run_make()', which
  relies on the use of AM_MAKEFLAGS, avoiding the use of the '-e' make
  option.  The use of that option (that causes the environment variables
  to take precedence over the macro definitions in the Makefile) has
  proved to be quite brittle in the past, causing annoying and sometimes
  problematic spurious failures.  This has worsened in some still
  unpublished work going on in development branches.  It's time to solve
  the issue once and for all.
  
  Note that we do not convert all uses of $MAKE in the testsuite right
  away; we might do so in follow-up changes, with leisure, to avoid a
  "patch bomb" effect (this commit is already too much of a bomb itself).
  What we do in this commit is to get rid of all "$MAKE -e" invocations.
  
  We admit that the implementation and feature-set of 'run_make()' are
  far from perfect, but good enough for our current purposes.  We'll
  improve 'run_make()' if and when the need arises.
  
  * syntax-checks.mk (sc_tests_no_make_e): New syntax check, guard against
  the use of "$MAKE -e".
  (syntax_check_rules): Add it.
  (sc_tests_overriding_macros_on_cmdline): Adjust.
  (lint): New, alias for 'maintainer-check', for lazy typists.  Idea
  backported from the 'maint' branch (Automake 1.13a).
  * t/ax/am-test-lib.sh (run_make): New function.  Run $MAKE with the
  given command-line arguments, handling command-line override of variable
  definitions in a smart way (using AM_MAKEFLAGS if a non-GNU make
  implementation is detected to be in use).
  (useless_vpath_rebuild): Adjust to use 'run_make', to avoid a spurious
  maintainer check failure.
  (yl_distcheck): Use 'run_make' rather than bare '$MAKE'.
  (single_quote, append_single_quoted, is_valid_varname): New auxiliary
  function, used, directly or indirectly, by it.
  * Many tests: Adjust to avoid the use of "$MAKE -e", and prefer the
  use of 'run_make' in few other contexts as well, where it makes sense.
  Other minor fixlets while at it.
  
  Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
  

Download

• t/yflags-cmdline-override.sh

• #! /bin/sh
  # Copyright (C) 2011-2013 Free Software Foundation, Inc.
  #
  # This program is free software; you can redistribute it and/or modify
  # it under the terms of the GNU General Public License as published by
  # the Free Software Foundation; either version 2, or (at your option)
  # any later version.
  #
  # This program is distributed in the hope that it will be useful,
  # but WITHOUT ANY WARRANTY; without even the implied warranty of
  # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  # GNU General Public License for more details.
  #
  # You should have received a copy of the GNU General Public License
  # along with this program.  If not, see <http://www.gnu.org/licenses/>.
  
  # Check that automake can cope with user-redefinition of $(YFLAGS)
  # at configure time and/or at make time.
  
  required='cc yacc'
  . test-init.sh
  
  cat >> configure.ac <<'END'
  AC_PROG_CC
  AC_PROG_YACC
  AC_OUTPUT
  END
  
  cat > Makefile.am <<'END'
  bin_PROGRAMS = foo
  foo_SOURCES = foo.y
  # A minor automake wart: automake doesn't generate code to clean
  # '*.output' files generated by yacc (it's not even clear if that
  # would be useful in general, so it's probably better to be
  # conservative).
  CLEANFILES = foo.output
  # As the '-d' flag won't be given at automake time, automake won't
  # be able to generate code to clean 'foo.h'.  We can't really blame
  # automake for that.
  MAINTAINERCLEANFILES = foo.h
  END
  
  cat > foo.y << 'END'
  %{
  int yylex () { return 0; }
  void yyerror (char *s) { return; }
  int main () { return 0; }
  %}
  %%
  foobar : 'f' 'o' 'o' 'b' 'a' 'r' {};
  END
  
  $ACLOCAL
  $AUTOMAKE -a
  $AUTOCONF
  
  ./configure YFLAGS='-d -v'
  $MAKE
  ls -l
  test -f foo.c
  test -f foo.h
  test -f foo.output
  
  $MAKE maintainer-clean
  ls -l
  
  ./configure YFLAGS='-v'
  $MAKE
  ls -l
  test -f foo.c
  test ! -e foo.h
  test -f foo.output
  
  $MAKE maintainer-clean
  ls -l
  
  ./configure YFLAGS='-v'
  run_make YFLAGS=-d
  ls -l
  test -f foo.c
  test -f foo.h
  test ! -e foo.output
  
  $MAKE maintainer-clean
  ls -l
  
  :
  

Download