Hash :
5b44ce39
Author :
Date :
2012-02-23T13:07:57
tests: quote 'like this', not `like this', as per GCS recommendation This patch converts the automake testsuite and related files, to the use of new quoting format 'like this' or "like this" rather than `like this'. This is done for consistency with the new recommendations in the GNU Coding Standards, and, well, because I've come to actually prefer the '...' and "..." quoting formats over the `...' one. * tests/README: Update quoting format throughout. Remove some "excessive" use of quoting, and throw in minor rewording where appropriate. * tests/Makefile.am: Likewise, for comments. * tests/CheckListOfTests.am: Likewise. * tests/defs-static.in: Likewise. * tests/defs: Likewise. * tests/trivial-test-driver: Likewise. * Many tests/*.tap, tests/*.test and tests/*.sh files: Likewise, and for the diagnostic and informational messages as well. * tests/gen-testsuite-part: Likewise, and for the generated tests as well.
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118
#! /bin/sh
# Copyright (C) 2004-2012 Free Software Foundation, Inc.
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 2, or (at your option)
# any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
# Make sure m4_included files are also scanned for definitions.
# Report from Phil Edwards.
. ./defs || Exit 1
cat >> configure.ac << 'END'
AM_PROG_LIBTOOL
AC_OUTPUT
END
echo 'm4_include([a.m4])' > acinclude.m4
echo 'm4_include([b.m4])' > a.m4
cat >b.m4 <<EOF
m4_include([c.m4])
AC_DEFUN([AM_PROG_LIBTOOL],
[AC_REQUIRE([SOMETHING])dnl
AC_REQUIRE([SOMETHING_ELSE])dnl
])
AC_DEFUN([SOMETHING])
EOF
echo 'm4_include([d.m4])' > c.m4
echo 'AC_DEFUN([SOMETHING_ELSE])' >d.m4
mkdir defs
echo 'AC_DEFUN([SOMETHING_ELSE])' >defs/e.m4
echo 'AC_DEFUN([ANOTHER_MACRO])' >defs/f.m4
cat >>Makefile.am<<\EOF
ACLOCAL_AMFLAGS = -I defs
testdist1: distdir
test -f $(distdir)/acinclude.m4
test -f $(distdir)/a.m4
test -f $(distdir)/b.m4
test -f $(distdir)/c.m4
test -f $(distdir)/d.m4
test ! -d $(distdir)/defs
testdist2: distdir
test -f $(distdir)/acinclude.m4
test -f $(distdir)/a.m4
test -f $(distdir)/b.m4
test -f $(distdir)/c.m4
test -f $(distdir)/d.m4
test ! -f $(distdir)/defs/e.m4
test -f $(distdir)/defs/f.m4
EOF
$ACLOCAL -I defs
$FGREP acinclude.m4 aclocal.m4
# None of the following macro should be included. acinclude.m4
# includes the first four, and the last two are not needed at all.
$FGREP a.m4 aclocal.m4 && Exit 1
$FGREP b.m4 aclocal.m4 && Exit 1
$FGREP c.m4 aclocal.m4 && Exit 1
$FGREP d.m4 aclocal.m4 && Exit 1
$FGREP defs/e.m4 aclocal.m4 && Exit 1
$FGREP defs/f.m4 aclocal.m4 && Exit 1
$AUTOCONF
$AUTOMAKE
./configure
$MAKE testdist1
cp aclocal.m4 stamp
$sleep
cat >>c.m4 <<\EOF
AC_DEFUN([FOO], [ANOTHER_MACRO])
EOF
$MAKE
# Because c.m4 has changed, aclocal.m4 must have been rebuilt.
test `ls -1t aclocal.m4 stamp | sed 1q` = aclocal.m4
# However, since FOO is not used, f.m4 should not be included
# and the contents of aclocal.m4 should remain the same
diff aclocal.m4 stamp
# If FOO where to be used, that would be another story, of course.
cat >>configure.ac <<EOF
FOO
EOF
cp aclocal.m4 stamp
$sleep
$MAKE
$FGREP defs/f.m4 aclocal.m4
$MAKE testdist2
# Make sure aclocal diagnose missing included files with correct 'file:line:'.
rm -f b.m4
$ACLOCAL 2>stderr && { cat stderr >&2; Exit 1; }
cat stderr >&2
grep 'a\.m4:1: .*b\.m4.*does not exist' stderr
: