kc3-lang/automake/t/ax/testsuite-summary-checks.sh

• Show log

  Commit

• Hash : ffd4ecc9
  Author :
  Date : 2013-05-20T11:23:01
  

  tests: better idiom to override make macro defs on the cmdline
  
  We now do so with a new wrapper shell function 'run_make()', which
  relies on the use of AM_MAKEFLAGS, avoiding the use of the '-e' make
  option.  The use of that option (that causes the environment variables
  to take precedence over the macro definitions in the Makefile) has
  proved to be quite brittle in the past, causing annoying and sometimes
  problematic spurious failures.  This has worsened in some still
  unpublished work going on in development branches.  It's time to solve
  the issue once and for all.
  
  Note that we do not convert all uses of $MAKE in the testsuite right
  away; we might do so in follow-up changes, with leisure, to avoid a
  "patch bomb" effect (this commit is already too much of a bomb itself).
  What we do in this commit is to get rid of all "$MAKE -e" invocations.
  
  We admit that the implementation and feature-set of 'run_make()' are
  far from perfect, but good enough for our current purposes.  We'll
  improve 'run_make()' if and when the need arises.
  
  * syntax-checks.mk (sc_tests_no_make_e): New syntax check, guard against
  the use of "$MAKE -e".
  (syntax_check_rules): Add it.
  (sc_tests_overriding_macros_on_cmdline): Adjust.
  (lint): New, alias for 'maintainer-check', for lazy typists.  Idea
  backported from the 'maint' branch (Automake 1.13a).
  * t/ax/am-test-lib.sh (run_make): New function.  Run $MAKE with the
  given command-line arguments, handling command-line override of variable
  definitions in a smart way (using AM_MAKEFLAGS if a non-GNU make
  implementation is detected to be in use).
  (useless_vpath_rebuild): Adjust to use 'run_make', to avoid a spurious
  maintainer check failure.
  (yl_distcheck): Use 'run_make' rather than bare '$MAKE'.
  (single_quote, append_single_quoted, is_valid_varname): New auxiliary
  function, used, directly or indirectly, by it.
  * Many tests: Adjust to avoid the use of "$MAKE -e", and prefer the
  use of 'run_make' in few other contexts as well, where it makes sense.
  Other minor fixlets while at it.
  
  Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
  

Download

• t/ax/testsuite-summary-checks.sh

• #! /bin/sh
  # Copyright (C) 2011-2013 Free Software Foundation, Inc.
  #
  # This program is free software; you can redistribute it and/or modify
  # it under the terms of the GNU General Public License as published by
  # the Free Software Foundation; either version 2, or (at your option)
  # any later version.
  #
  # This program is distributed in the hope that it will be useful,
  # but WITHOUT ANY WARRANTY; without even the implied warranty of
  # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  # GNU General Public License for more details.
  #
  # You should have received a copy of the GNU General Public License
  # along with this program.  If not, see <http://www.gnu.org/licenses/>.
  
  # Check the testsuite summary with the parallel test harness.  This
  # script is meant to be sourced by other test script, so that it can
  # be used to check different scenarios (colorized and non-colorized
  # testsuite output, packages with and without bug-report addresses,
  # testsuites in subdirectories, ...)
  
  . test-init.sh
  
  case $use_colors in
    yes)
      AM_COLOR_TESTS=always; export AM_COLOR_TESTS
      # Forced colorization should take place also with non-ANSI
      # terminals; hence this setting.
      TERM=dumb; export TERM
      ;;
    no)
      ;;
    *)
      fatal_ "invalid use_colors='$use_colors'";;
  esac
  
  cat > configure.ac <<END
  AC_INIT([GNU AutoFoo], [7.1], [bug-automake@gnu.org])
  AM_INIT_AUTOMAKE
  AC_CONFIG_FILES([Makefile])
  AC_OUTPUT
  END
  
  cat > Makefile.am <<'END'
  TEST_EXTENSIONS = .t
  T_LOG_COMPILER = $(SHELL) $(srcdir)/log-compiler
  ## Will be defined at runtime.
  TESTS =
  $(TESTS):
  END
  
  cat > log-compiler <<'END'
  #!/bin/sh
  case "$1" in
    pass*|*/pass*|xpass*|*/xpass*) exit 0;;
    fail*|*/fail*|xfail*|*/xfail*) exit 1;;
    skip*|*/skip*) exit 77;;
    error*|/error*) exit 99;;
    copy*|*/copy*) cat "$1";;
    *) exit 99;;
  esac
  END
  
  # Quite complexish, but allow the tests in client scripts to be written
  # in a "data-driven fashion".
  do_check ()
  {
    cat > summary.exp
    expect_failure=false
    xfail_tests=''
    tests="$*"
    for t in $*; do
      case $t in fail*|xpass*|error*) expect_failure=:;; esac
      case $t in xfail*|xpass*) xfail_tests="$xfail_tests $t";; esac
    done
    run_make -e IGNORE check TESTS="$tests" XFAIL_TESTS="$xfail_tests" >stdout
    cat stdout
    if $expect_failure; then
      test $am_make_rc_got -gt 0 || exit 1
    else
      test $am_make_rc_got -eq 0 || exit 1
    fi
    $PERL "$am_testaux_srcdir"/extract-testsuite-summary.pl stdout >summary.got \
     || fatal_ "cannot extract testsuite summary"
    cat summary.exp
    cat summary.got
    if test $use_colors = yes; then
      # Use cmp, not diff, because the files might contain binary data.
      compare=cmp
    else
      compare=diff
    fi
    $compare summary.exp summary.got || exit 1
  }
  
  br='============================================================================'
  
  $ACLOCAL
  $AUTOCONF
  $AUTOMAKE --add-missing
  
  :
  

Download