Hash :
b6c3ed5e
Author :
Date :
2012-01-26T18:00:40
warnings: more precise category and message for one warning If automake detected an usage like "AC_CONFIG_FILES([./Makefile])" in configure.ac, it warned that such an usage was unportable to non-GNU make implementations. But the truth is actually worse: that is actually *unportable to GNU make* itself, since it breaks the automatic remake rules in subtle ways. So we now reveal this breakage in a new test case, and enhance the warning by giving it a more precise and correct wording, and by moving it from the category 'portability' to the category 'unsupported'. * automake.in (scan_autoconf_config_files): Improve the warning. * tests/conffile-leading-dot.test: New test. * tests/list-of-tests.mk: Add it.
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62
#! /bin/sh
# Copyright (C) 2012 Free Software Foundation, Inc.
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 2, or (at your option)
# any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
# Automake must complain if AC_CONFIG_FILES is passed something starting
# with a dot (like "./Makefile"), since the remake rules might be subtly
# broken in that case.
required=GNUmake
. ./defs || Exit 1
set -e
cat > configure.in << END
AC_INIT([$me], [1.0])
AM_INIT_AUTOMAKE
AC_CONFIG_FILES([./Makefile])
AC_CONFIG_FILES([./foo:a.in:b.in:c.in])
AC_OUTPUT
END
echo foo = barbarbar > Makefile.am
touch a.in b.in c.in
$ACLOCAL
AUTOMAKE_fails -Wnone -Wunsupported
grep "^configure\.in:3:.*'\\./Makefile'" stderr
grep "^configure\.in:3:.* omit leading '\\./'" stderr
grep "^configure\.in:3:.*remake rules might be subtly broken" stderr
grep "^configure\.in:4:.*'\\./foo'" stderr
grep "^configure\.in:4:.* omit leading '\\./'" stderr
grep "^configure\.in:4:.*remake rules might be subtly broken" stderr
# Check that our warning was actually justified.
$AUTOCONF
$AUTOMAKE -Wall -Wno-unsupported
./configure
$MAKE
grep barbarbar Makefile
# No need to sleep here, configure did that for us already.
echo foo = bazbazbaz > Makefile.am
# Check that remake rules do truly break -- otherwise automake is
# giving a bogus warning.
$MAKE 2>stderr && { cat stderr >&2 Exit 1; }
cat stderr >&2
grep "config\\.status:.*invalid argument.*[\`\"']Makefile[\`\"']" stderr
: