Hash :
c2a52bf0
Author :
Date :
2012-06-24T10:36:15
tests: simpler workaround for shells losing the exit status in exit trap Now that we can assume our tests are run by a decent POSIX shell, we can simplify our workaround aimed at having the exit status propagated correctly to the code in the exit trap. Unfortunately, we cannot dispense with such a workaround altogether, because it's still required by some shells we need to support (at least Solaris 10 /bin/ksh and /usr/xpg4/bin/sh). For more information about the need of that workaround, see the entry about 'trap' in the section "Limitations of Shell Builtins" in the Autoconf manual: <http://www.gnu.org/software/autoconf/manual/autoconf.html#trap> The new workaround has been tested successfully with the following shells: - Bash 4.1 - Bash 3.2 - Bash 3.0 - Bash 2.05b - dash 0.5.5.1 - dash 0.5.2 - AT&T Ksh 93u (from official Debian package) - MirBSD Korn Shell 40.2 (from official Debian package) - Solaris 9, 10 and 11 /bin/ksh - Solaris 9, 10 and 11 /usr/xpg4/bin/sh - NetBSD 5.1 /bin/sh - NetBSD 5.1 /bin/ksh * t/ax/test-init.sh (Exit): Rename ... (_am_exit): ... like this. (exit): New alias for '_am_exit'. We cannot simply redefine 'exit' as a shell function, because some shells (dash 0.5.5.1, Solaris 10 /bin/ksh and /usr/xpg4/bin/sh) do not allow it. (_am_exit, trap): Add extra escaping for 'exit' calls, to ensure we really invoke the 'exit' builtin and not our alias with the same name. * configure.ac: Check that the shell selected to run our testsuite supports aliases named like shell builtins. * t/REAMDE: Adjust. * All tests: Adjust, by simply using 'exit' instead of 'Exit'. * t/self-check-explicit-skips.sh: Adjust: the first usage of 'exit' after it has been redefined as an alias must be on a new line w.r.t. that where the alias is defined, in order for the redefinition to be honored. * syntax-checks.mk (sc_tests_Exit_not_exit): Delete. (sc_tests_exit_not_Exit): New. (syntax_check_rules): Adjust. (sc_tests_automake_fails): Simplify the recipe a little. * Several tests: Remove now useless spurious quoting once required to placate the 'sc_tests_Exit_not_exit' maintainer check. * gen-testsuite-part: Likewise. Also, avoid uses of 'Exit' in the generated scripts. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82
#! /bin/sh
# Copyright (C) 2002-2012 Free Software Foundation, Inc.
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 2, or (at your option)
# any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
# Tests that Automake understands multiple suffix rules on the same line.
# PR/371 and PR/372: Reported by Duncan Gibson.
# We also check for suffixes containing '-'.
required=cc
. ./defs || exit 1
plan_ 10
cat >>configure.ac <<EOF
AC_PROG_CC
AC_OUTPUT
EOF
cat >Makefile.am << 'END'
bin_PROGRAMS = foo bar baz
foo_SOURCES = foo.x_
bar_SOURCES = bar.y-z
baz_SOURCES = baz1.x_ baz2.y-z
.y-z.c .x_.c:
## Account for VPATH issues on weaker make implementations (e.g. IRIX 6.5).
sed 's/INTEGER/int/g' `test -f '$<' || echo $(srcdir)/`$< >$@
CLEANFILES = foo.c bar.c baz1.c baz2.c
.PHONY: test-real test-fake
test-fake:
echo $(foo_OBJECTS) | grep '^foo\.foo$$'
echo $(bar_OBJECTS) | grep '^bar\.foo$$'
echo $(baz_OBJECTS) | grep '^baz1\.foo baz2\.foo$$'
test-real:
echo $(foo_OBJECTS) | grep '^foo\.$(OBJEXT)$$'
echo $(bar_OBJECTS) | grep '^bar\.$(OBJEXT)$$'
echo $(baz_OBJECTS) | grep '^baz1\.$(OBJEXT) baz2\.$(OBJEXT)$$'
check-local: test-real
END
echo 'INTEGER main(void) { return 0; }' > foo.x_
echo 'INTEGER main(void) { return 0; }' > bar.y-z
echo 'INTEGER main(void) { INTEGER baz(void); return baz(); }' > baz1.x_
echo 'INTEGER baz(void) { return 0; }' > baz2.y-z
command_ok_ "aclocal" $ACLOCAL
command_ok_ "autoconf" $AUTOCONF
# What we do is not portable. Automake should warn.
AUTOMAKE_fails -a
command_ok_ "warn about unportable make usage" \
grep '[iI]nference rules can have only one target before the colon' stderr
# But this should work anyway.
command_ok_ "automake" $AUTOMAKE -a -Wno-portability
command_ok_ "configure" ./configure
command_ok_ "make test-fake" env OBJEXT=foo $MAKE -e test-fake
command_ok_ "make test-real" $MAKE test-real
directive=''; make_can_chain_suffix_rules || directive=TODO
for target in '' distcheck; do
command_ok_ "make $target" \
-D "$directive" -r "suffix rules not chained" \
$MAKE $target
done
: