kc3-lang/automake/t/parallel-tests-recheck-pr11791.sh

• Show log

  Commit

• Hash : ffd4ecc9
  Author :
  Date : 2013-05-20T11:23:01
  

  tests: better idiom to override make macro defs on the cmdline
  
  We now do so with a new wrapper shell function 'run_make()', which
  relies on the use of AM_MAKEFLAGS, avoiding the use of the '-e' make
  option.  The use of that option (that causes the environment variables
  to take precedence over the macro definitions in the Makefile) has
  proved to be quite brittle in the past, causing annoying and sometimes
  problematic spurious failures.  This has worsened in some still
  unpublished work going on in development branches.  It's time to solve
  the issue once and for all.
  
  Note that we do not convert all uses of $MAKE in the testsuite right
  away; we might do so in follow-up changes, with leisure, to avoid a
  "patch bomb" effect (this commit is already too much of a bomb itself).
  What we do in this commit is to get rid of all "$MAKE -e" invocations.
  
  We admit that the implementation and feature-set of 'run_make()' are
  far from perfect, but good enough for our current purposes.  We'll
  improve 'run_make()' if and when the need arises.
  
  * syntax-checks.mk (sc_tests_no_make_e): New syntax check, guard against
  the use of "$MAKE -e".
  (syntax_check_rules): Add it.
  (sc_tests_overriding_macros_on_cmdline): Adjust.
  (lint): New, alias for 'maintainer-check', for lazy typists.  Idea
  backported from the 'maint' branch (Automake 1.13a).
  * t/ax/am-test-lib.sh (run_make): New function.  Run $MAKE with the
  given command-line arguments, handling command-line override of variable
  definitions in a smart way (using AM_MAKEFLAGS if a non-GNU make
  implementation is detected to be in use).
  (useless_vpath_rebuild): Adjust to use 'run_make', to avoid a spurious
  maintainer check failure.
  (yl_distcheck): Use 'run_make' rather than bare '$MAKE'.
  (single_quote, append_single_quoted, is_valid_varname): New auxiliary
  function, used, directly or indirectly, by it.
  * Many tests: Adjust to avoid the use of "$MAKE -e", and prefer the
  use of 'run_make' in few other contexts as well, where it makes sense.
  Other minor fixlets while at it.
  
  Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
  

Download

• t/parallel-tests-recheck-pr11791.sh

• #! /bin/sh
  # Copyright (C) 2012-2013 Free Software Foundation, Inc.
  #
  # This program is free software; you can redistribute it and/or modify
  # it under the terms of the GNU General Public License as published by
  # the Free Software Foundation; either version 2, or (at your option)
  # any later version.
  #
  # This program is distributed in the hope that it will be useful,
  # but WITHOUT ANY WARRANTY; without even the implied warranty of
  # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  # GNU General Public License for more details.
  #
  # You should have received a copy of the GNU General Public License
  # along with this program.  If not, see <http://www.gnu.org/licenses/>.
  
  # parallel-tests: "make recheck" and "make -k recheck" in the face of
  # build failures for the test cases.  See automake bug#11791.
  
  required='cc native'
  . test-init.sh
  
  cat >> configure.ac << 'END'
  AC_PROG_CC
  AC_OUTPUT
  END
  
  cat > Makefile.am << 'END'
  TESTS = $(EXTRA_PROGRAMS)
  EXTRA_PROGRAMS = foo
  END
  
  echo 'int main (void) { return 1; }' > foo.c
  
  $ACLOCAL
  $AUTOCONF
  $AUTOMAKE -a
  
  ./configure
  
  $MAKE check >stdout && { cat stdout; exit 1; }
  cat stdout
  count_test_results total=1 pass=0 fail=1 xpass=0 xfail=0 skip=0 error=0
  
  $sleep # Required to avoid a spurious failure with some FreeBSD makes.
  st=0; $MAKE -k recheck >stdout || st=$?
  cat stdout
  # Don't trust the exit status of "make -k" for non-GNU makes.
  if using_gmake && test $st -eq 0; then exit 1; fi
  count_test_results total=1 pass=0 fail=1 xpass=0 xfail=0 skip=0 error=0
  
  # Introduce an error in foo.c, that should cause a compilation failure.
  $sleep
  echo choke me >> foo.c
  
  $MAKE recheck >stdout && { cat stdout; exit 1; }
  cat stdout
  # We don't get a change to run the testsuite.
  $EGREP '(X?PASS|X?FAIL|SKIP|ERROR):' stdout && exit 1
  # These shouldn't be removed, otherwise the next make recheck will do
  # nothing.
  test -f foo.log
  test -f foo.trs
  
  $sleep # Required to avoid a spurious failure with some FreeBSD makes.
  st=0; $MAKE -k recheck >stdout || st=$?
  cat stdout
  # Don't trust the exit status of "make -k" for non-GNU makes.
  if using_gmake && test $st -eq 0; then exit 1; fi
  # We don't get a change to run the testsuite.
  $EGREP '(X?PASS|X?FAIL|SKIP|ERROR):' stdout && exit 1
  test -f foo.log
  test -f foo.trs
  
  # "Repair" foo.c, and expect everything to work.
  $sleep
  echo 'int main (void) { return 0; }' > foo.c
  
  $MAKE recheck >stdout || { cat stdout; exit 1; }
  cat stdout
  count_test_results total=1 pass=1 fail=0 xpass=0 xfail=0 skip=0 error=0
  test -f foo.log
  test -f foo.trs
  
  $MAKE recheck >stdout || { cat stdout; exit 1; }
  cat stdout
  count_test_results total=0 pass=0 fail=0 xpass=0 xfail=0 skip=0 error=0
  test -f foo.log
  test -f foo.trs
  
  :
  

Download