kc3-lang/automake/t/link_cond.sh

• Show log

  Commit

• Hash : ffd4ecc9
  Author :
  Date : 2013-05-20T11:23:01
  

  tests: better idiom to override make macro defs on the cmdline
  
  We now do so with a new wrapper shell function 'run_make()', which
  relies on the use of AM_MAKEFLAGS, avoiding the use of the '-e' make
  option.  The use of that option (that causes the environment variables
  to take precedence over the macro definitions in the Makefile) has
  proved to be quite brittle in the past, causing annoying and sometimes
  problematic spurious failures.  This has worsened in some still
  unpublished work going on in development branches.  It's time to solve
  the issue once and for all.
  
  Note that we do not convert all uses of $MAKE in the testsuite right
  away; we might do so in follow-up changes, with leisure, to avoid a
  "patch bomb" effect (this commit is already too much of a bomb itself).
  What we do in this commit is to get rid of all "$MAKE -e" invocations.
  
  We admit that the implementation and feature-set of 'run_make()' are
  far from perfect, but good enough for our current purposes.  We'll
  improve 'run_make()' if and when the need arises.
  
  * syntax-checks.mk (sc_tests_no_make_e): New syntax check, guard against
  the use of "$MAKE -e".
  (syntax_check_rules): Add it.
  (sc_tests_overriding_macros_on_cmdline): Adjust.
  (lint): New, alias for 'maintainer-check', for lazy typists.  Idea
  backported from the 'maint' branch (Automake 1.13a).
  * t/ax/am-test-lib.sh (run_make): New function.  Run $MAKE with the
  given command-line arguments, handling command-line override of variable
  definitions in a smart way (using AM_MAKEFLAGS if a non-GNU make
  implementation is detected to be in use).
  (useless_vpath_rebuild): Adjust to use 'run_make', to avoid a spurious
  maintainer check failure.
  (yl_distcheck): Use 'run_make' rather than bare '$MAKE'.
  (single_quote, append_single_quoted, is_valid_varname): New auxiliary
  function, used, directly or indirectly, by it.
  * Many tests: Adjust to avoid the use of "$MAKE -e", and prefer the
  use of 'run_make' in few other contexts as well, where it makes sense.
  Other minor fixlets while at it.
  
  Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
  

Download

• t/link_cond.sh

• #! /bin/sh
  # Copyright (C) 2012-2013 Free Software Foundation, Inc.
  #
  # This program is free software; you can redistribute it and/or modify
  # it under the terms of the GNU General Public License as published by
  # the Free Software Foundation; either version 2, or (at your option)
  # any later version.
  #
  # This program is distributed in the hope that it will be useful,
  # but WITHOUT ANY WARRANTY; without even the implied warranty of
  # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  # GNU General Public License for more details.
  #
  # You should have received a copy of the GNU General Public License
  # along with this program.  If not, see <http://www.gnu.org/licenses/>.
  
  # Test that automatic determination of the linker works well with
  # conditional use of languages in a single program.
  # This currently doesn't truly work, but we have an easy workaround
  # at least, that is tested here.
  # See automake bug#11089.
  
  required='cc c++'
  . test-init.sh
  
  cat >> configure.ac << 'END'
  AC_PROG_CC
  AC_PROG_CXX
  AM_CONDITIONAL([HAVE_CXX], [test $have_cxx = yes])
  AC_OUTPUT
  END
  
  cat > Makefile.am << 'END'
  bin_PROGRAMS = foo
  if HAVE_CXX
  foo_SOURCES = more.c++
  else
  foo_SOURCES = less.c
  endif
  ## FIXME: ideally, this workaround shouldn't be needed.
  if HAVE_CXX
  foo_LINK = $(CXXLINK)
  else
  foo_LINK = $(LINK)
  endif
  END
  
  $ACLOCAL
  $AUTOMAKE
  $AUTOCONF
  
  rm -f *.c++
  cat > less.c <<'END'
  /* Valid C but deliberately invalid C++ */
  main ()
  {
    int new = 0;
    return new;
  }
  END
  
  ./configure have_cxx=no
  run_make CXX=false
  
  # Sanity check.
  rm -f foo foo.exe
  run_make CC=false && exit 99
  
  $MAKE distclean
  
  rm -f *.c
  cat > more.c++ <<'END'
  /* Valid C++ but deliberately invalid C */
  using namespace std;
  int main (void)
  {
    return 0;
  }
  END
  
  ./configure have_cxx=yes
  run_make CC=false
  
  # Sanity check.
  rm -f foo foo.exe
  run_make CXX=false && exit 99
  
  :
  

Download