kc3-lang/automake/t/test-trs-basic.sh

• Show log

  Commit

• Hash : ffd4ecc9
  Author :
  Date : 2013-05-20T11:23:01
  

  tests: better idiom to override make macro defs on the cmdline
  
  We now do so with a new wrapper shell function 'run_make()', which
  relies on the use of AM_MAKEFLAGS, avoiding the use of the '-e' make
  option.  The use of that option (that causes the environment variables
  to take precedence over the macro definitions in the Makefile) has
  proved to be quite brittle in the past, causing annoying and sometimes
  problematic spurious failures.  This has worsened in some still
  unpublished work going on in development branches.  It's time to solve
  the issue once and for all.
  
  Note that we do not convert all uses of $MAKE in the testsuite right
  away; we might do so in follow-up changes, with leisure, to avoid a
  "patch bomb" effect (this commit is already too much of a bomb itself).
  What we do in this commit is to get rid of all "$MAKE -e" invocations.
  
  We admit that the implementation and feature-set of 'run_make()' are
  far from perfect, but good enough for our current purposes.  We'll
  improve 'run_make()' if and when the need arises.
  
  * syntax-checks.mk (sc_tests_no_make_e): New syntax check, guard against
  the use of "$MAKE -e".
  (syntax_check_rules): Add it.
  (sc_tests_overriding_macros_on_cmdline): Adjust.
  (lint): New, alias for 'maintainer-check', for lazy typists.  Idea
  backported from the 'maint' branch (Automake 1.13a).
  * t/ax/am-test-lib.sh (run_make): New function.  Run $MAKE with the
  given command-line arguments, handling command-line override of variable
  definitions in a smart way (using AM_MAKEFLAGS if a non-GNU make
  implementation is detected to be in use).
  (useless_vpath_rebuild): Adjust to use 'run_make', to avoid a spurious
  maintainer check failure.
  (yl_distcheck): Use 'run_make' rather than bare '$MAKE'.
  (single_quote, append_single_quoted, is_valid_varname): New auxiliary
  function, used, directly or indirectly, by it.
  * Many tests: Adjust to avoid the use of "$MAKE -e", and prefer the
  use of 'run_make' in few other contexts as well, where it makes sense.
  Other minor fixlets while at it.
  
  Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
  

Download

• t/test-trs-basic.sh

• #! /bin/sh
  # Copyright (C) 2011-2013 Free Software Foundation, Inc.
  #
  # This program is free software; you can redistribute it and/or modify
  # it under the terms of the GNU General Public License as published by
  # the Free Software Foundation; either version 2, or (at your option)
  # any later version.
  #
  # This program is distributed in the hope that it will be useful,
  # but WITHOUT ANY WARRANTY; without even the implied warranty of
  # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  # GNU General Public License for more details.
  #
  # You should have received a copy of the GNU General Public License
  # along with this program.  If not, see <http://www.gnu.org/licenses/>.
  
  # Check parallel harness features:
  #  - creation and removal of '.trs' auxiliary files
  #  - check some internals regarding the use of '.trs' files.
  
  . test-init.sh
  
  cat >> configure.ac <<END
  AC_OUTPUT
  END
  
  cat > Makefile.am << 'END'
  TEST_EXTENSIONS = .sh .test
  TESTS = foo.test bar.sh sub/zardoz.test
  TEST_LOG_COMPILER = $(SHELL)
  SH_LOG_COMPILER = $(SHELL)
  
  ## Used to check some internal details.  And yes, the quotes around
  ## '$bases' are deliberate: they check for whitespace normalization.
  tb:
  	$(am__set_TESTS_bases); echo "$$bases" > $@
  END
  
  cat > foo.test << 'END'
  #! /bin/sh
  exit $FOO_STATUS
  END
  : > bar.sh
  mkdir sub
  : > sub/zardoz.test
  
  FOO_STATUS=0; export FOO_STATUS
  
  $ACLOCAL
  $AUTOCONF
  $AUTOMAKE -a
  
  
  #
  # Check some internal details first.
  #
  
  for vpath in : false; do
  
    if $vpath; then
      srcdir=..
      mkdir build
      cd build
    else
      srcdir=.
    fi
  
    $srcdir/configure
  
    $MAKE tb
    test x"$(cat tb)" = x"foo bar sub/zardoz"
    rm -f tb
    # Please don't change the order of the stuff in TESTS, below.
    run_make TESTS='foo.test foo2.sh foo-log foolog.test a.log.b.sh 0.exe' tb
    test x"$(cat tb)" = x"foo foo2 foo-log foolog a.log.b 0.exe"
    rm -f tb
  
    cd $srcdir
  
  done
  
  #
  # The 'test-suite.stamp' file and the '.trs' files get created by
  # "make check" and removed by "make clean" and "make mostlyclean".
  #
  
  : > unrelated.trs
  : > sub/foo.trs
  
  $MAKE check
  test -f foo.trs
  test -f bar.trs
  test -f sub/zardoz.trs
  $MAKE clean
  test ! -e foo.trs
  test ! -e bar.trs
  test ! -e sub/zardoz.trs
  # Unrelated '.trs' files shouldn't be removed.
  test -f unrelated.trs
  test -f sub/foo.trs
  
  # The files should be properly created in case of testsuite failure too.
  FOO_STATUS=1 $MAKE check && exit 1
  test -f foo.trs
  test -f bar.trs
  test -f sub/zardoz.trs
  $MAKE mostlyclean
  test ! -e foo.trs
  test ! -e bar.trs
  test ! -e sub/zardoz.trs
  # Unrelated '.trs' files shouldn't be removed.
  test -f unrelated.trs
  test -f sub/foo.trs
  
  #
  # Try with a subset of TESTS.
  #
  
  run_make TESTS=foo.test check
  test -f foo.trs
  test ! -e bar.trs
  test ! -e sub/zardoz.trs
  $MAKE clean
  test ! -e foo.trs
  run_make TESTS='foo.test bar.sh' check
  test -f foo.trs
  test -f bar.trs
  test ! -e sub/zardoz.trs
  # "make clean" shouldn't remove '.trs' files for tests not in $(TESTS).
  run_make TESTS=bar.sh clean
  test -f foo.trs
  test ! -e bar.trs
  
  $MAKE clean
  
  #
  # Try with a subset of TEST_LOGS.
  #
  
  run_make TEST_LOGS=sub/zardoz.log check
  test ! -e foo.trs
  test ! -e bar.trs
  test -f sub/zardoz.trs
  $MAKE clean
  test ! -e sub/zardoz.trs
  run_make TEST_LOGS='foo.log bar.log' check
  test -f foo.trs
  test -f bar.trs
  test ! -e sub/zardoz.trs
  # "make clean" shouldn't remove '.trs' files for tests whose log
  # is not in $(TEST_LOGS).
  run_make TEST_LOGS=foo.log clean
  test ! -e foo.trs
  test -f bar.trs
  test ! -e sub/zardoz.trs
  
  :
  

Download