Edit

kc3-lang/brotli/python/Makefile

Branch :

  • Show log

    Commit

  • Author : Cosimo Lupo
    Date : 2017-08-23 19:45:13
    Hash : 4f455cac
    Message : disable buidling/deployment of python wheels (#583) * [appveyor] remove 'deploy' stage; only test python 2.7 and 3.6 all the other python versions are being built and tested on https://github.com/google/brotli-wheels/blob/d571d63/appveyor.yml * remove terrify submodule as not needed any more * [travis] just test py2.7 and 3.6 on linux; remove extra osx python builds All the other python versions for OSX are being built/tested on: https://github.com/google/brotli-wheels/blob/d571d63/.travis.yml Also, there's no need to build and deploy wheels here, as that's done in the separate repository. * [setup.py] only rebuild if dependency are newer; fix typo in list of 'depends' https://github.com/python/cpython/blob/v3.6.2/Lib/distutils/command/build_ext.py#L485-L500 * [ci] only run 'python setup.py test' if we run 'python setup.py built test', the setuptools 'test' command will forcibly re-run the build_ext subcommand because it wants to pass the --inplace option (it ignores whether it's up to date, just re-runs it all the time). with this we go from running built_ext twice, to running it only once per build * [Makefile] run 'build_ext --inplace' instead of 'develop' as default target The 'develop' command is like 'install' in the sense that it modifies the user's python environment. The default make target should be less intrusive, i.e. just building the extension module in-place without modify anything in the user's environment. We don't need to tell make about the dependency between 'test' and 'build' target as that is baked in the `python setup.py test` command. * [Makefile] add 'develop' target; remove unnecessary 'tests' target `make test` is good enough * [Makefile] `setup.py test` requires setuptools; run `python -m unittest` This will work even if setuptools is not installed, which is unlikely nowadays but still our `setup.py` works with plain distutils, so we may well have our tests work without setuptools. * [python/README.md] add ref to 'develop' target; remove 'tests', just 'make test' * [setup.py] import modules as per nicksay's comment https://github.com/google/brotli/pull/583#discussion_r131981049 * [Makefile] add 'develop' to .PHONY targets remove 'tests' from .PHONY * [appveyor] remove unused setup scripts We don't need to install custom python versions, we are using the pre-installed ones on Appveyor. * [appveyor] remove unneeded setup code

  • python/Makefile
  • # Copyright 2016 The Brotli Authors. All rights reserved.
    #
    # Distributed under MIT license.
    # See file LICENSE for detail or copy at https://opensource.org/licenses/MIT
    
    
    # Default (Build)
    .PHONY: all
    # Build
    .PHONY: build
    # Develop
    .PHONY: develop
    # Install
    .PHONY: install
    # Test
    .PHONY: test
    # Clean
    .PHONY: clean
    # Format
    .PHONY: fix
    
    
    PYTHON ?= python
    YAPF ?= yapf
    
    EXT_SUFFIX=$(shell $(PYTHON) -c 'import sysconfig; print(sysconfig.get_config_var("EXT_SUFFIX"))')
    EXT_SOURCES=$(shell find . -name '*.cc')
    EXTENSIONS=$(EXT_SOURCES:%.cc=%$(EXT_SUFFIX))
    
    
    all: build
    
    build: $(EXTENSIONS)
    
    $(EXTENSIONS): $(EXT_SOURCES)
    	@cd .. && $(PYTHON) setup.py build_ext --inplace
    
    develop:
    	@cd .. && $(PYTHON) setup.py develop
    
    install:
    	@cd .. && $(PYTHON) setup.py install
    
    test: build
    	@echo 'running tests'
    	@$(PYTHON) -m unittest discover -v -p '*_test.py'
    
    clean:
    	@cd .. && $(PYTHON) setup.py clean
    	@find .. -name '*.pyc' | xargs rm -v
    	@find .. -name '*.so' | xargs rm -v
    	@find .. -type d -name '__pycache__' | xargs rm -v -r
    	@find .. -type d -name '*.egg-info' | xargs rm -v -r
    
    fix:
    	@echo 'formatting code'
    	-@$(YAPF) --in-place --recursive --verify .