Commit 80b96f350c8ea73f7da0dd76fc5c075dcbfdfaa9

David Turner 2000-08-29T16:04:28

fixed some bugs in the caching sub-system and improved its API to enable many kinds of glyph images.. (note that the "ftview" program has been changed to use the caching sub-system, "ftmulti" and "ftstring" should come soon).

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
diff --git a/include/freetype/ftcache.h b/include/freetype/ftcache.h
index e4c1000..6f7d9e9 100644
--- a/include/freetype/ftcache.h
+++ b/include/freetype/ftcache.h
@@ -318,12 +318,26 @@
   /* <Note>                                                                */
   /*    Other types may be defined in the future.                          */
   /*                                                                       */
+  
+#define   FTC_IMAGE_FORMAT(x)  ((x) & 7)
+
   typedef enum  FTC_Image_Type_
   {
-    ftc_image_mono = 0,         /* monochrome bitmap   */
-    ftc_image_grays,            /* anti-aliased bitmap */
-    ftc_image_outline,          /* scaled outline      */
-    ftc_image_master_outline    /* original outline    */
+    ftc_image_format_bitmap   = 0,
+    ftc_image_format_outline  = 1,
+    
+    ftc_image_flag_monochrome = 16,
+    ftc_image_flag_unhinted   = 32,
+    ftc_image_flag_autohinted = 64,
+    ftc_image_flag_unscaled   = 128,
+    ftc_image_flag_no_sbits   = 256,
+    
+    ftc_image_mono             = ftc_image_format_bitmap |
+                                 ftc_image_flag_monochrome, /* monochrome bitmap   */
+                                
+    ftc_image_grays            = ftc_image_format_bitmap,   /* anti-aliased bitmap */
+                                
+    ftc_image_outline          = ftc_image_format_outline   /* scaled outline */
   
   } FTC_Image_Type;
 
diff --git a/src/cache/ftcimage.c b/src/cache/ftcimage.c
index 63d0a16..9439c96 100644
--- a/src/cache/ftcimage.c
+++ b/src/cache/ftcimage.c
@@ -20,6 +20,7 @@
 #include <freetype/fterrors.h>
 #include <freetype/internal/ftobjs.h>
 #include <freetype/internal/ftlist.h>
+#include <freetype/fterrors.h>
 
  /**************************************************************************/
  /**************************************************************************/
@@ -123,8 +124,8 @@
 
 
   static
-  FT_Error  ftc_init_mono_image( FTC_Image_Queue  queue,
-                                 FTC_ImageNode    node )
+  FT_Error  ftc_init_glyph_image( FTC_Image_Queue  queue,
+                                  FTC_ImageNode    node )
   {  
     FT_Face   face;
     FT_Size   size;
@@ -136,105 +137,40 @@
     if ( !error )
     {
       FT_UInt  glyph_index = FTC_IMAGENODE_GET_GINDEX( node );
-
+      FT_UInt  load_flags  = FT_LOAD_DEFAULT;
+      FT_UInt  image_type  = queue->descriptor.image_type;
       
-      error = FT_Load_Glyph( face, glyph_index,
-                             FT_LOAD_RENDER | FT_LOAD_MONOCHROME );
-      if ( !error )
-      {
-        if ( face->glyph->format            != ft_glyph_format_bitmap ||
-             face->glyph->bitmap.pixel_mode != ft_pixel_mode_mono     )
-        {
-          /* there is no monochrome glyph for this font! */
-          error = FT_Err_Invalid_Glyph_Index;
-        }
-        else
-        {
-          /* ok, copy it */
-          FT_Glyph  glyph;
+      if ( FTC_IMAGE_FORMAT(image_type) == ftc_image_format_bitmap )
+      {           
+        load_flags |= FT_LOAD_RENDER;           
+        if ( image_type & ftc_image_flag_monochrome )
+          load_flags |= FT_LOAD_MONOCHROME;
           
-          
-          error = FT_Get_Glyph( face->glyph, &glyph );
-          if ( !error )
-            FTC_IMAGENODE_SET_GLYPH( node, glyph );
-        }
+        /* disable embedded bitmaps loading if necessary */
+        if (load_flags & ftc_image_flag_no_sbits)
+          load_flags |= FT_LOAD_NO_BITMAP;
       }
-    }
-    return error;
-  }
-
-
-  static
-  FT_Error  ftc_init_gray_image( FTC_Image_Queue  queue,
-                                 FTC_ImageNode    node )
-  {  
-    FT_Face   face;
-    FT_Size   size;
-    FT_Error  error;
-    
-
-    error = FTC_Manager_Lookup_Size( queue->manager,
-                                     &queue->descriptor.size,
-                                     &face, &size );
-    if ( !error )
-    {
-      FT_UInt  glyph_index = FTC_IMAGENODE_GET_GINDEX( node );
-      
-
-      error = FT_Load_Glyph( face, glyph_index,
-                             FT_LOAD_RENDER );
-      if ( !error )
+      else if ( FTC_IMAGE_FORMAT(image_type) == ftc_image_format_outline )
       {
-        if ( face->glyph->format            != ft_glyph_format_bitmap ||
-             face->glyph->bitmap.pixel_mode != ft_pixel_mode_grays )
-        {
-          /* there is no anti-aliased glyph for this font! */
-          error = FT_Err_Invalid_Glyph_Index;
-        }
-        else
-        {
-          /* ok, copy it */
-          FT_Glyph  glyph;
+        /* disable embedded bitmaps loading */
+        load_flags |= FT_LOAD_NO_BITMAP;
+        
+        if (image_type & ftc_image_flag_unscaled)
+          load_flags |= FT_LOAD_NO_SCALE;
+      }
           
+      if (image_type & ftc_image_flag_unhinted)
+        load_flags |= FT_LOAD_NO_HINTING;
           
-          error = FT_Get_Glyph( face->glyph, &glyph );
-          if ( !error )
-            FTC_IMAGENODE_SET_GLYPH( node, glyph );
-        }
-      }
-    }
-    return error;
-  }
+      if (image_type & ftc_image_flag_autohinted)
+        load_flags |= FT_LOAD_FORCE_AUTOHINT;
 
-
-  static
-  FT_Error  ftc_init_outline_image( FTC_Image_Queue  queue,
-                                    FTC_ImageNode    node )
-  {  
-    FT_Face   face;
-    FT_Size   size;
-    FT_Error  error;
-    
-
-    error = FTC_Manager_Lookup_Size( queue->manager,
-                                     &queue->descriptor.size,
-                                     &face, &size );
-    if ( !error )
-    {
-      FT_UInt  glyph_index = FTC_IMAGENODE_GET_GINDEX( node );
-      
-
-      error = FT_Load_Glyph( face, glyph_index,
-                             FT_LOAD_NO_BITMAP );
+      error = FT_Load_Glyph( face, glyph_index, load_flags );
       if ( !error )
       {
-        if ( face->glyph->format != ft_glyph_format_outline )
-        {
-          /* there is no outline glyph for this font! */
-          error = FT_Err_Invalid_Glyph_Index;
-        }
-        else
-        {
+        if ( face->glyph->format == ft_glyph_format_bitmap  ||
+             face->glyph->format == ft_glyph_format_outline )
+        {             
           /* ok, copy it */
           FT_Glyph  glyph;
           
@@ -243,6 +179,8 @@
           if ( !error )
             FTC_IMAGENODE_SET_GLYPH( node, glyph );
         }
+        else
+          error = FT_Err_Invalid_Argument;
       }
     }
     return error;
@@ -250,60 +188,12 @@
 
 
 
-  static
-  FT_Error  ftc_init_master_outline_image( FTC_Image_Queue  queue,
-                                           FTC_ImageNode    node )
-  {  
-    FT_Face   face;
-    FT_Size   size;
-    FT_Error  error;
-    
-
-    error = FTC_Manager_Lookup_Size( queue->manager,
-                                     &queue->descriptor.size,
-                                     &face, &size );
-    if ( !error )
-    {
-      FT_UInt  glyph_index = FTC_IMAGENODE_GET_GINDEX( node );
-      
-
-      error = FT_Load_Glyph( face, glyph_index,
-                             FT_LOAD_NO_SCALE | FT_LOAD_NO_BITMAP );
-      if ( !error )
-      {
-        if ( face->glyph->format != ft_glyph_format_outline )
-        {
-          /* there is no outline glyph for this font! */
-          error = FT_Err_Invalid_Glyph_Index;
-        }
-        else
-        {
-          /* ok, copy it */
-          FT_Glyph  glyph;
-          
-          
-          error = FT_Get_Glyph( face->glyph, &glyph );
-          if ( !error )
-            FTC_IMAGENODE_SET_GLYPH( node, glyph );
-        }
-      }
-    }
-    return error;
-  }
 
 
   static
-  const FTC_Image_Class   ftc_mono_image_class =
-  {
-    ftc_init_mono_image,
-    ftc_done_glyph_image,
-    ftc_size_bitmap_image
-  };
-  
-  static
-  const FTC_Image_Class   ftc_gray_image_class =
+  const FTC_Image_Class   ftc_bitmap_image_class =
   {
-    ftc_init_gray_image,
+    ftc_init_glyph_image,
     ftc_done_glyph_image,
     ftc_size_bitmap_image
   };
@@ -311,19 +201,11 @@
   static
   const FTC_Image_Class   ftc_outline_image_class =
   {
-    ftc_init_outline_image,
+    ftc_init_glyph_image,
     ftc_done_glyph_image,
     ftc_size_outline_image
   };
   
-  static
-  const FTC_Image_Class   ftc_master_outline_image_class =
-  {
-    ftc_init_master_outline_image,
-    ftc_done_glyph_image,
-    ftc_size_outline_image
-  };
-
 
   static
   FT_Error  FTC_Image_Queue_New( FTC_Image_Cache   cache,
@@ -346,33 +228,25 @@
     queue->manager    = manager;
     queue->memory     = memory;
     queue->descriptor = *desc;
-    queue->hash_size  = 32;
+    queue->hash_size  = 64;
     
     if ( ALLOC_ARRAY( queue->buckets, queue->hash_size, FT_ListRec ) )
       goto Exit;
 
-    switch ( desc->image_type )
+    switch (FTC_IMAGE_FORMAT(desc->image_type))
     {
-    case ftc_image_mono:
-      clazz = &ftc_mono_image_class;
-      break;
-        
-    case ftc_image_grays:
-      clazz = &ftc_gray_image_class;
-      break;
-        
-    case ftc_image_outline:
-      clazz = &ftc_outline_image_class;
-      break;
+      case ftc_image_format_bitmap:
+        clazz = &ftc_bitmap_image_class;
+        break;
         
-    case ftc_image_master_outline:
-      clazz = &ftc_master_outline_image_class;
-      break;
+      case ftc_image_format_outline:
+        clazz = &ftc_outline_image_class;
+        break;
         
-    default:
-      /* invalid image type! */
-      error = FT_Err_Invalid_Argument;
-      goto Exit;
+      default:
+        /* invalid image type! */
+        error = FT_Err_Invalid_Argument;
+        goto Exit;
     }
 
     queue->clazz = (FTC_Image_Class*)clazz;
@@ -414,6 +288,9 @@
         queue->clazz->done_image( queue, inode );
         FT_List_Remove( glyphs_lru, lrunode );
         
+        cache->num_bytes -= queue->clazz->size_image(queue,inode) +
+                            sizeof(FTC_ImageNodeRec);
+        
         FTC_ImageNode_Done( cache, inode );
       }
       
@@ -433,25 +310,29 @@
     FTC_Image_Cache  cache      = queue->cache;
     FT_UInt          hash_index = glyph_index % queue->hash_size;
     FT_List          bucket     = queue->buckets + hash_index;
-    FT_ListNode      node, next = 0;
+    FT_ListNode      node;
     FT_Error         error;
     FTC_ImageNode    inode;
     
 
     *anode = 0;
-    for ( node = bucket->head; node; node = next )
+    for ( node = bucket->head; node; node = node->next )
     {
-      inode = (FTC_ImageNode)node;
+      FT_UInt  gindex;
       
-      if ( FTC_IMAGENODE_GET_GINDEX( inode ) == glyph_index )
+      inode  = (FTC_ImageNode)node;
+      gindex = FTC_IMAGENODE_GET_GINDEX(inode);
+      
+      if ( gindex == glyph_index )
       {
         /* we found it! -- move glyph to start of the list */
         FT_List_Up( bucket, node );
+        FT_List_Up( &cache->glyphs_lru, FTC_IMAGENODE_TO_LISTNODE( inode ) );
         *anode = inode;
         return 0;
       }
     }
-    
+
     /* we didn't found the glyph image, we will now create a new one */
     error = FTC_ImageNode_New( queue->cache, &inode );
     if ( error )
@@ -473,7 +354,8 @@
     /* insert the node at the start the global LRU glyph list */
     FT_List_Insert( &cache->glyphs_lru, FTC_IMAGENODE_TO_LISTNODE( inode ) );
     
-    cache->num_bytes += queue->clazz->size_image(queue,inode);
+    cache->num_bytes += queue->clazz->size_image(queue,inode) +
+                        sizeof(FTC_ImageNodeRec);
 
     *anode = inode;
 
@@ -570,7 +452,7 @@
   {
     while ( cache->num_bytes > cache->max_bytes )
     {
-      FT_ListNode      cur = cache->glyphs_lru.tail;
+      FT_ListNode      cur;
       FTC_Image_Queue  queue;
       FT_UInt          glyph_index;
       FT_UInt          hash_index;
@@ -583,6 +465,7 @@
       /* we reached the newly created node (which happens always at the */
       /* start of the list)                                             */
       
+      cur   = cache->glyphs_lru.tail;
       inode = FTC_LISTNODE_TO_IMAGENODE( cur );
       if ( !cur || inode == new_node )
         break;
@@ -592,7 +475,8 @@
       queue       = (FTC_Image_Queue)cache->queues_lru->
                       nodes[queue_index].root.data;
       hash_index  = glyph_index % queue->hash_size;
-      size        = queue->clazz->size_image( queue, inode );
+      size        = queue->clazz->size_image( queue, inode ) +
+                    sizeof(FTC_ImageNodeRec);
 
       FT_List_Remove( &cache->glyphs_lru, cur );
       FT_List_Remove( queue->buckets + hash_index, (FT_ListNode)inode );
@@ -601,8 +485,8 @@
       
       cache->num_bytes -= size;
     }
-  }                                    
-  
+  }
+
 
   FT_EXPORT_DEF( FT_Error )  FTC_Image_Cache_New( FTC_Manager       manager,
                                                   FT_ULong          max_bytes,
@@ -684,11 +568,11 @@
 
     *aglyph = 0;    
     queue   = cache->last_queue;
-    if ( !queue                                                     ||
-         queue->descriptor.size.face_id != desc->size.face_id       ||
-         queue->descriptor.size.pix_width != desc->size.pix_width   ||
-         queue->descriptor.size.pix_height != desc->size.pix_height ||
-         queue->descriptor.image_type != desc->image_type           )
+    if ( !queue                                                      ||
+          queue->descriptor.size.face_id    != desc->size.face_id    ||
+          queue->descriptor.size.pix_width  != desc->size.pix_width  ||
+          queue->descriptor.size.pix_height != desc->size.pix_height ||
+          queue->descriptor.image_type      != desc->image_type      )
     {
       error = FT_Lru_Lookup( cache->queues_lru,
                              (FT_LruKey)desc,
@@ -702,7 +586,9 @@
     if ( error )
       goto Exit;
 
-    FTC_Image_Cache_Compress( cache, inode );
+    if (cache->num_bytes > cache->max_bytes)
+      FTC_Image_Cache_Compress( cache, inode );
+
     *aglyph = FTC_IMAGENODE_GET_GLYPH( inode );
 
   Exit: