kmx git

Commit	Date	Message
63983c0a	2009-12-10T14:14:13	Add pty module for forkpty and openpty.
238a6434	2009-12-10T14:08:47	stdio: Avoid syntax error in C++ mode.
545c8ff9	2009-12-10T12:22:41	Use sed with option -e.
51d5e813	2009-12-10T12:17:19	mgetgroups: do not write bytes beyond end of malloc'd buffer * lib/mgetgroups.c: Fix an off-by-one error. When we have no username, we call getgroups with a one-element-shorter buffer, but still told it the length was original, max_n_groups.
b82fdd08	2009-12-09T17:14:12	cloexec: relax license cloexec is a thin wrapper around fcntl, which is a glibc function and therefore reasonable for LGPL. Jim Meyering and Bruno Haible agreed to the change. * modules/cloexec (Maintainer): Add myself. (License): Use LGPL, not GPL. Signed-off-by: Eric Blake <ebb9@byu.net>
a7f94464	2009-12-09T16:11:27	link-warning: optimize generation Avoid a useless use of cat. * modules/link-warning (Makefile.am): Reduce process usage. Signed-off-by: Eric Blake <ebb9@byu.net>
bd5a4d9f	2009-12-09T22:04:36	unsetenv: Document last workaround.
c0b67899	2009-12-09T17:34:02	link-warning: Allow extra lines at the top of build-aux/link-warning.h.
d49061eb	2009-12-09T14:13:08	mgetgroups: Avoid undefined behaviour when ng == 0.
237d7dcd	2009-12-09T12:41:19	link-warning: Add copyright notice.
a226e8ae	2009-12-09T12:11:36	fchdir: Optimize away rpl_fstat when possible.
e29e19dc	2009-12-09T11:49:30	fchdir: Update comment.
61808c7c	2009-12-09T11:37:17	Fix a recent ChangeLog entry.
645bcdec	2009-12-09T11:21:35	cloexec: Clarify code.
aeb9a8a8	2009-12-08T10:23:27	fchdir: avoid memory leak on re-registration. Some code paths (such as dup3) could overwrite one registered directory fd with another, and must not leak the old name. * lib/fchdir.c (ensure_dirs_slot): Avoid memory leak. Signed-off-by: Eric Blake <ebb9@byu.net>
5aad650f	2009-12-08T20:37:50	init.sh: avoid Solaris 10 /bin/sh portability problem Solaris 10's /bin/sh does not pass '.' arguments 2..N to the sourced script: $ printf 'echo "$@"\n' > f; /bin/sh -c '. ./f bar' $ printf 'echo "$@"\n' > f; bash -c '. ./f bar' bar tests/init.sh relied on that, accepting a --set-path=DIR argument, and two tests used that idiom. * tests/init.sh: Update suggested usage comments. (path_prepend_): New function, to be used in place of the --src-path=DIR option. Disallow empty strings and strings containing ":". (setup_): Move PATH-prepending code into path_prepend_. * tests/test-pread.sh: Adapt to new usage. * tests/test-xalloc-die.sh: Likewise.
20378b72	2009-12-08T17:44:19	Document pty.h functions.
2966d0d2	2009-12-08T06:13:05	fchdir: fix logic bugs Configuring with ac_cv_func_fchdir=no on a system that has fchdir and where open handles directories, just to test out the replacement capabilities, uncovered an m4 test bug and a link failure on rpl_fstat. * m4/fchdir.m4 (gl_FUNC_FCHDIR): Fix logic bug. * tests/test-fchdir.c (main): Enhance test. * lib/fchdir.c (rpl_fstat): Always provide if fchdir replacement is in use. Signed-off-by: Eric Blake <ebb9@byu.net>
21a0a9e3	2009-12-07T21:08:17	dup2: fix logic bugs If the platform has dup2, don't register with fchdir if the destination was -1. If the platform lacks dup2 (are there any these days?), then don't close the destination unless the source is valid, make sure errno is correct, and only register with fchdir on fcntl (since dup is already overridden to do a registration). * lib/dup2.c (dup2): Fix logic bugs. Use HAVE_DUP2 rather than REPLACE_DUP2 to decide when rpl_dup2 is needed. * m4/dup2.m4 (gl_REPLACE_DUP2): Only define REPLACE_DUP2 when dup2 exists. (gl_FUNC_DUP2): Drop unneeded AC_SUBST. Signed-off-by: Eric Blake <ebb9@byu.net>
67ac31ed	2009-12-07T17:15:07	unlink: fix m4 detection The m4 test failed under -Werror due to implicit declaration. * m4/unlink.m4 (gl_FUNC_UNLINK): Include correct header. Signed-off-by: Eric Blake <ebb9@byu.net>
a1afba1b	2009-12-07T10:17:07	unistd-safer: add unit test Add more unit tests. Meanwhile, fix compilation error on mingw when testing unistd-safer and fchdir together; and avoid gcc warning on platforms without setmode. * modules/unistd-safer-tests: New file. * tests/test-dup-safer.c: Likewise. * tests/test-cloexec.c (setmode): Avoid compiler warning. * tests/test-dup2.c (setmode): Likewise. * lib/cloexec.c (dup_cloexec): Fix mingw compile error. Signed-off-by: Eric Blake <ebb9@byu.net>
73da5fb7	2009-12-07T06:53:59	cloexec: preserve text vs. binary across dup_cloexec On mingw, dup_cloexec mistakenly converted a text fd into a binary fd. Cygwin copied the source mode. Most other platforms don't distinguish between modes. * lib/cloexec.c (dup_cloexec) [W32]: Query and use translation mode. * modules/dup2-tests (Depends-on): Add binary-io. * modules/cloexec-tests (Depends-on): Likewise. * tests/test-dup2.c (setmode, is_mode): New helpers. (main): Add tests that translation mode is preserved. * tests/test-cloexec.c (setmode, is_mode, main): Likewise. Reported by Bruno Haible. Signed-off-by: Eric Blake <ebb9@byu.net>
b1ab442e	2009-12-04T14:07:58	mgetgroups: reduce duplicate listings POSIX doesn't guarantee whether the effective gid is included in the list of supplementary groups returned by getgroups. On the other hand, some platforms include the effective gid twice in the list. Meanwhile, mgetgroups can independently add a duplicate. Rather than spend a full-blown O(n log n) cleanup, we just remove the most common forms of duplicate groups with an O(n) pass. * lib/mgetgroups.c (mgetgroups): Reduce duplicates from the resulting array. * tests/test-chown.h (test_chown): Simplify client. * tests/test-lchown.h (test_lchown): Likewise. Signed-off-by: Eric Blake <ebb9@byu.net>
68145a07	2009-12-07T01:02:50	cloexec: Fix possible compilation error.
3941f59c	2009-12-06T23:19:49	prognam: Add diagnostic.
6ed67a15	2009-12-05T06:39:09	pipe2-safer: new module pipe2 deserves a _safer variant. It also makes the code in pipe.c look simpler. modules/pipe2-safer: New file. * lib/unistd-safer.h (pipe2_safer): New prototype. * lib/unistd--.h (pipe2): New wrapper. * lib/pipe-safer.c (pipe2_safer): New function. * modules/pipe (Depends-on): Add pipe2-safer. * lib/pipe.c (create_pipe) [WIN32]: Let pipe2_safer do the work. Signed-off-by: Eric Blake <ebb9@byu.net>
f2fdd542	2009-11-16T16:09:42	stdlib-safer: preserve cloexec flag for mkostemp[s] mkostemp_safer(templ,O_CLOEXEC) did not always guarantee cloexec. * lib/mkstemp-safer.c (mkostemp_safer, mkostemps_safer): Use new fd_safer_flag. Signed-off-by: Eric Blake <ebb9@byu.net>
14449a1d	2009-12-05T06:36:33	unistd-safer: allow preservation of cloexec status via flag If cloexec is in use, allow the ability to preserve cloexec flag across _safer functions. lib/unistd-safer.h (dup_safer_flag, fd_safer_flag): New prototypes. * lib/dup-safer.c (dup_safer_flag): New function. * lib/fd-safer.c (fd_safer_flag): Likewise. * modules/cloexec (configure.ac): Set witness. Signed-off-by: Eric Blake <ebb9@byu.net>
173359db	2009-12-05T06:19:01	test-dup2: enhance test Ensure that dup2(cloexec_fd, target) returns an inheritable fd. * modules/dup2-tests (Depends-on): Add cloexec. * tests/test-dup2.c (main): Enhance test. Signed-off-by: Eric Blake <ebb9@byu.net>
d8ccc13b	2009-12-04T22:10:44	cloexec: add dup_cloexec This is needed to enforce correct semantics of mkostemp_safer. Meanwhile, it is one step closer to providing O_CLOEXEC support to open, as well as implementing portions of fcntl for mingw. * lib/cloexec.h (dup_cloexec): New prototype. Add copyright header and comments. * lib/cloexec.c (set_cloexec_flag): Add comments. (dup_cloexec): New function, with mingw implementation borrowed from... * lib/w32spawn.h (dup_noinherit): ...here. * modules/execute (Depends-on): Add cloexec. * modules/pipe (Depends-on): Likewise. * modules/cloexec (Depends-on): Add dup2. * modules/cloexec-tests (Files): New file. * tests/test-cloexec.c: Likewise. Signed-off-by: Eric Blake <ebb9@byu.net>
a4cfedb0	2009-12-05T09:24:54	test-xalloc-die: fix test for mingw When cross-compiling on mingw to target mingw, argv[0] still includes a .exe suffix. Rather than worry about ${EXEEXT}, just add a sed post-process. Also, simplify the script by using tests/init.sh. * modules/xalloc-die-tests (Files): Add tests/init.sh. * tests/test-xalloc-die.sh: Rewrite to use init.sh. Strip directory and .exe suffix off argv[0] output. Signed-off-by: Eric Blake <ebb9@byu.net>
e4488f18	2009-12-05T09:07:28	test-fseeko: fix test for mingw Undefining fseek made test-fseeko.sh fail when testing on pipes. * tests/test-fseeko.c (fseek): Redefine GL_LINK_WARNING, rather than undefining fseek, so test will pass on mingw. Signed-off-by: Eric Blake <ebb9@byu.net>
9a1388f4	2009-12-05T05:36:19	autoupdate
32928258	2009-12-05T12:14:04	progname: Clarify specification.
208edc20	2009-12-05T10:02:01	maint.mk: backslash-escape parens in default regexp * top/maint.mk (news-check-regexp): Now that we're using grep -E, backslash-escape the literal parentheses.
875fb2d6	2009-12-05T09:35:28	maint.mk: news-check: use grep -E * top/maint.mk (today): Define a Make variable, not a... (news-date-check): ...shell variable. (news-check-regexp): Use the Make variable. Use grep's -E option. Change the failing diagnostic to mention the variable, $(news-check-regexp). (news-check): Rename target from news-date-check. Update sole use.
9ecc3fc8	2009-12-04T21:27:40	maintainer-makefile: allow customization of NEWS entry format * top/maint.mk (news-date-regexp): New overridable variable. (news-date-check): Use it. Signed-off-by: Eric Blake <ebb9@byu.net>
3e035a5d	2009-12-04T08:26:23	mgetgroups: add xgetgroups, and avoid ENOSYS failures ENOSYS implies that there are no supplemental groups, so we can treat it the same as a return of 0 from getgroups rather than exposing failure to the user. This in turn fixes a crash in coreutils' id, which freed an uninitialized pointer. * lib/mgetgroups.h (xgetgroups): New prototype. * lib/mgetgroups.c (xgetgroups): New wrapper. (mgetgroups): Handle ENOSYS. * modules/mgetgroups (Depends-on): Add realloc. Reported by Scott Harrison <scott.gnu.2009@scottrix.co.uk>. Signed-off-by: Eric Blake <ebb9@byu.net>
3425a9dd	2009-12-04T14:37:32	mgetgroups: avoid argument promotion issues with -1 On platforms where gid_t is equivalent to uint16_t, argument promotion states that -1 != (gid_t) -1. * lib/mgetgroups.c (mgetgroups): A cast is required when checking for invalid gid_t. * tests/test-chown.h (getegid, test_chown): Likewise. * tests/test-lchown.h (getegid, test_lchown): Likewise. Signed-off-by: Eric Blake <ebb9@byu.net>
c5588be3	2009-12-03T18:39:47	exclude: Fix header file problems. * lib/exclude.h: Add multiple inclusion guards and include stdbool.h.
563c7796	2009-12-01T06:38:45	autoupdate
cdfe647f	2009-12-01T12:06:34	fts: fts_open: do not let an empty string cause immediate failure This is required in support of GNU rm, for which the command "rm A '' B" must process and remove both A and B, in spite of the empty string argument. * lib/fts.c (fts_open): Do not let the presence of an empty string cause fts_open to fail immediately. Most fts-using tools must be able to process all arguments, in order, and can be expected to diagnose such arguments themselves. Also, move declaration of local, "len", "down" to initialization.
52f2ca7c	2009-11-30T06:45:42	utimens: fix compilation error Fixes a regression from 2009-11-25. * lib/utimens.c (lutimens) [!HAVE_UTIMENSAT && HAVE_LUTIMES]: Declare variable at right scope. Signed-off-by: Eric Blake <ebb9@byu.net>
acf2fa81	2009-11-30T12:29:03	bootstrap: fix handling of various perl --version formats * build-aux/bootstrap (get_version): Don't use perl's $] special variable, as that requires updating all bootstrap.conf files to use perl's x.yyyzzz version format. Instead make the regular expression more general to support version formats from older perl-5.005_002 (5.5.2) and perl-5.11 which has other numbers in the version line.
f203a8f4	2009-11-29T13:57:05	bootstrap: handle perl-5.11's changed --version output * build-aux/bootstrap (get_version): Handle perl separately, since perl-5.11's --version output is different.
cf8ddf08	2009-11-28T09:28:40	userspec: depend on the inttostr module, too * modules/userspec (Depends-on): Add inttostr.
2ead6c09	2009-11-28T07:33:16	userspec: disallow an ID that maps to (uid_t)-1 or (gid_t)-1 * lib/userspec.c (parse_with_separator): Do not accept a user ID number of MAXUID when it evaluates to (uid_t) -1. Likewise for group ID. Reported by Matt McCutchen in <http://savannah.gnu.org/bugs/?28113>
42956c5d	2009-11-28T07:26:53	userspec: reformat to use spaces, not TABs * lib/userspec.c: Expand TABs to spaces. Add Emacs' "indent-tabs-mode: nil" hint.
c0c5acfb	2009-11-27T17:47:21	getopt-gnu: flush out another BSD bug POSIX requires 'echo foo > bar; m4 -Dfoo=1 bar -Dfoo=2 bar' to output '1' then '2'. To achieve this, m4 relies on the GNU getopt{,_long} extension of a leading '-'. However, BSD getopt fails to honor this extension when POSIXLY_CORRECT. Also, BSD getopt fails to reparse POSIXLY_CORRECT from the environment even when a reset is requested (whether by optreset=1 or by optind=0). * m4/getopt.m4 (gl_GETOPT_CHECK_HEADERS): Test for the bug. * tests/test-getopt.c (main): Check POSIXLY_CORRECT first, to flush out BSD bug. * tests/test-getopt.h (test_getopt): End lists with NULL. * tests/test-getopt_long.h (test_getopt_long): Likewise. (test_getopt_long_posix): Enhance test. * modules/getopt-posix-tests (Depends-on): Add stdbool. * doc/glibc-functions/getopt_long.texi (getopt_long): Mention getopt-gnu. * doc/glibc-functions/getopt_long_only.texi (getopt_long_only): Likewise. Signed-off-by: Eric Blake <ebb9@byu.net>
6184bd14	2009-11-27T16:13:37	modules/idpriv-droptemp-tests (Notice): Fix text.
fed81b33	2009-11-27T10:19:32	test-xalloc-die: avoid spurious failure due to libtool argv difference In a libtool-enabled project, this test would fail due to a difference in the emitted program name, e.g., -test-xalloc-die: memory exhausted +/tmp/.../tests/.libs/lt-test-xalloc-die: memory exhausted Use program to avoid that. * modules/xalloc-die-tests (Depends-on): Add progname. * tests/test-xalloc-die.c: Include progname.h". (program_name): Remove decl. (main): Call set_program_name. * tests/test-xalloc-die.sh (compare): Remove unnecessary ${EXE}.
dfd793fa	2009-11-26T20:29:16	w32sock: leave win32 error in place. * lib/w32sock.h (set_winsock_errno): Do not call WSASetLastError.
9bb0a7e5	2009-11-26T09:39:26	init.sh: suggest to use skip_ and fail_ functions in comments * tests/init.sh: Add a sentence.
0975a057	2009-11-26T09:24:51	init.sh: add documentation in comments * tests/init.sh: Add some developer and user documentation.
94a77054	2009-11-26T09:10:04	init.sh: accommodate even those who specify bogus srcdir manually * tests/init.sh: Normally, srcdir is guaranteed by automake and configure-time tests to be sanitized, so that there is no need to use "$srcdir" in Makefile rules and shell scripts. Using $srcdir (with no double quotes) suffices. However, since tests may be invoked manually, and since you may explicitly set srcdir to the name of a directory containing spaces, do quote its uses here. * tests/test-pread.sh: Likewise. Suggested by Bruno Haible.
2fbe7721	2009-11-26T08:51:11	test-pread.sh: avoid diagnostics for those who ignore SIGPIPE * tests/test-pread.sh: Write no data into the pipe, because test-pread actually reads none. This avoids a diagnostic, "bash: echo: write error: Broken pipe", that arises in the unusual event something is ignoring SIGPIPE, and might be interpreted as some sort of failure. Reported by Bruno Haible.
1baf5e2a	2009-11-25T18:26:35	test-pread: cover failure with ESPIPE and EINVAL * tests/test-pread.c (main): Test for failure, too. * tests/test-pread.sh: Invoke with stdin on a pipe. Suggested by Eric Blake.
23cd7413	2009-11-25T18:01:02	pread: improvement and fix * modules/pread (Depends-on): Depend on lseek, for portability to e.g., mingw. Suggested by Eric Blake. * lib/pread.c (__libc_read): Define. Reported by Richard W.M. Jones.
8def010e	2009-11-25T17:06:25	unistd.in.h: correct declaration of pread * lib/unistd.in.h: Correct type of "buf" parameter: void, not char Reported by Richard W.M. Jones.
dbf9a707	2009-11-25T16:59:15	test-pread.sh: distribute the test script * modules/pread-tests (Files): Include test-pread.sh.
9b1723bc	2009-11-25T16:52:47	test-pread.sh: clean up * tests/test-pread.sh: Don't refer to $builddir. Just use equivalent ".". * modules/pread-tests (TESTS_ENVIRONMENT): Don't export builddir. That is unnecessary, since it's always ".". Suggestion from Eric Blake.
e185811d	2009-11-25T16:37:42	test-pread.sh: make executable * tests/test-pread.sh: Set executable bit. Reported by Eric Blake.
a722f997	2009-11-25T16:14:19	correct typo in test-pread.sh * tests/test-pread.sh: Add #! line.
ebbfe985	2009-11-25T15:50:56	test pread * tests/test-pread.c: New file. * tests/test-pread.sh: Likewise. * modules/pread-tests: Likewise.
f84e1a91	2009-11-25T14:33:30	pread: new module * modules/pread: New file. * lib/pread.c (pread): New file. * m4/pread.m4: Likewise. * lib/unistd.in.h (pread): Define/declare. * m4/unistd_h.m4 (gl_UNISTD_H_DEFAULTS): Define defaults. * modules/unistd (Makefile.am): Substitute witnesses. * doc/posix-functions/pread.texi (pread): Update. * MODULES.html.sh: Add pread.
ef77cd53	2009-11-25T14:40:31	tests/init.sh: new file to be used via most .sh tests tests/init.sh: New file.
0457832f	2009-11-24T10:07:57	utimens: work around older Linux failure with symlinks Some Linux kernel versions support utimensat(,0) but not utimensat(,AT_SYMLINK_NOFOLLOW), even for non-symlinks. Had the fallback code for regular files been reached, it would have truncated timestamps. But since glibc lutimes just wraps utimensat, and we didn't expect ENOSYS from lutimes, the fallback wasn't even reached. * lib/utimens.c (lutimensat_works_really): New variable. (fdutimens, lutimens): Use it to manage kernels that support nanosecond times on files, but not on symlinks. Reported by Ondřej Vašík. Signed-off-by: Eric Blake <ebb9@byu.net>
63a3cbb6	2009-11-24T10:00:18	utimes: fix configure grammar 'Checking determine whether...' doesn't read well. * m4/utimes.m4 (gl_FUNC_UTIMES): Delete spurious word. Signed-off-by: Eric Blake <ebb9@byu.net>
2bc9cabc	2009-11-25T11:41:09	regex: Fix fastmap for multibyte character ranges. * lib/regcomp.c (re_compute_fastmap_iter): Add all multibyte lead characters when a multibyte character range is included.
29508f24	2009-11-22T09:47:12	version-etc: work also with AM_INIT_AUTOMAKE's no-define option * lib/version-etc.c [!defined PACKAGE]: Define to PACKAGE_TARNAME.
44834c9e	2009-11-25T01:53:37	doc: Most *_l functions exist in MacOS X 10.5.
def56200	2009-11-25T01:49:04	doc: Most *_l functions exist in MacOS X 10.5.
6575ab51	2009-11-24T10:44:40	duplocale: Fix logic bug.
0fe2cbf6	2009-11-23T11:28:00	test-update-copyright: don't hard-code /usr/bin/perl * tests/test-update-copyright.sh (YEAR): Use date +%Y, rather than perl to print the current year. Gilles Espinasse reported that the replaced use of perl was hard-coded as /usr/bin/perl.
a88cd6da	2009-11-23T11:05:42	duplocale: Add support for glibc 2.3.x.
0581dde5	2009-11-23T02:43:23	vasnprintf: Tiny optimization.
2430ab9f	2009-11-23T01:47:07	Tests for module 'duplocale'.
3f0d472e	2009-11-23T01:46:00	New module 'duplocale'.
15b8a934	2009-11-22T23:32:54	Check that <locale.h> defines locale_t and LC_GLOBAL_LOCALE.
17d63e84	2009-11-22T23:31:11	locale: Make locale_t available when possible.
c2f52a86	2009-11-23T01:03:24	Add comments.
84aee6d7	2009-11-22T19:33:24	Oops, move the include of unistd.h in the last commit.
c2af86ba	2009-11-22T19:30:39	error: account for the possibility of freopen (stdout).
4e765f32	2009-11-22T19:07:34	Add comment.
1398c0de	2009-11-22T17:11:14	c-stack: avoid defining an unused static function * lib/c-stack.c (find_stack_direction): Do not define this function when it will not be used.
32be9f34	2009-11-22T09:01:07	diffseq: avoid spurious gcc warnings * lib/diffseq.h (IF_LINT2): Define. (compareseq): Use it to initialize two members of "part". This avoids two used-uninitialized warnings.
df57f427	2009-11-21T17:52:54	c-stack: avoid "ignoring return value of `write'" warning * lib/c-stack.c: Include "ignore-value.h". (die): Explicitly ignore each write return value. * modules/c-stack (Depends-on): Add ignore-value.
e9b552cf	2009-11-21T07:12:27	autoupdate
833e6a3e	2009-11-21T14:37:46	diffseq: reduce scope of variable 'best'.
a823652c	2009-11-21T13:49:54	diffseq: remove useless assignment to "best" * lib/diffseq.h (diag) [USE_HEURISTIC]: Remove useless "best = 0" assignment. At that point "best" is already guaranteed to be zero.
481f709c	2009-11-20T06:23:42	build: mention ftp redirector in release announcements Now that http://ftpmirror.gnu.org/PACKAGE/ redirects to a nearby mirror, we should promote its use in release announcements. Meanwhile, mention the mirror list. * top/maint.mk (gnu_rel_host, url_dir_list): Provide defaults for values that used to come from cfg.mk; mention FTP redirect URL. * build-aux/announce-gen: Mention the mirror list. Suggested by Karl Berry. Signed-off-by: Eric Blake <ebb9@byu.net>
addbb8a8	2009-11-18T22:14:39	nanosleep: improve port to mingw test-nanosleep failed to link, and exposed a need for argument validation when nanosleep is missing. * lib/nanosleep.c (rpl_nanosleep): Reject invalid arguments. * m4/nanosleep.m4 (gl_FUNC_NANOSLEEP): Incorporate LIBSOCKET into LIB_NANOSLEEP, but only when needed. * modules/select (Link): Document LIBSOCKET. * m4/select.m4 (gl_FUNC_SELECT): Ensure LIBSOCKET is defined early enough.
a905b350	2009-11-18T20:10:42	nanosleep: work around cygwin bug Cygwin 1.5.x mistakenly failed with EINVAL for a duration longer than 49.7 days (2*32 milliseconds). Meanwhile, the existing code for HAVE_BUG_BIG_NANOSLEEP would infloop, instead of return failure, for invalid arguments. lib/nanosleep.c (rpl_nanosleep) [HAVE_BUG_BIG_NANOSLEEP]: Fix logic bug when nanosleep fails. Work around cygwin 1.5.x bug. (getnow): Delete, not needed. * m4/nanosleep.m4 (gl_FUNC_NANOSLEEP): No longer require LIB_CLOCK_GETTIME. * modules/nanosleep (Depends-on): Add intprops and verify. Drop clock-time, gettime. * doc/posix-functions/nanosleep.texi (nanosleep): Document the bug. * modules/nanosleep-tests: New test. * tests/test-nanosleep.c: New file. Signed-off-by: Eric Blake <ebb9@byu.net>
6baa4663	2009-11-18T20:07:44	sleep: work around cygwin bug On cygwin 1.5.x, sleep amounts larger than 49.7 days (2*32 milliseconds) failed instantly, but with a garbage return value from uninitialized memory. lib/sleep.c (rpl_sleep): Work around the bug. * m4/sleep.m4 (gl_FUNC_SLEEP): Detect the bug. (gl_PREREQ_SLEEP): Delete unused macro. * modules/sleep (Depends-on): Add verify. * m4/unistd_h.m4 (gl_UNISTD_H_DEFAULTS): Add default. * modules/unistd (Makefile.am): Substitute witness. * lib/unistd.in.h (sleep): Update prototype. * doc/posix-functions/sleep.texi (sleep): Document the bug. * tests/test-sleep.c (main) [HAVE_DECL_ALARM]: Test it. * modules/sleep-tests (Depends-on): Check for alarm. Signed-off-by: Eric Blake <ebb9@byu.net>
00b2f10b	2009-11-20T13:24:24	maint.mk: improve sc_prohibit_magic_number_exit * top/maint.mk (sc_prohibit_magic_number_exit): Tighten regexp so it does not match uses like System.exit(1). Add comments showing how to correct all offenders.
b5104eb4	2009-11-19T09:12:34	xalloc-die-tests: add missing library * modules/xalloc-die-tests (Makefile.am): Add LDADD line. Signed-off-by: Eric Blake <ebb9@byu.net>
21d7dbb8	2009-11-19T08:51:13	test-xvasprintf: silence compiler warnings * tests/test-xvasprintf.c (test_xvasprintf, test_xasprintf): Mask empty string from gcc. Signed-off-by: Eric Blake <ebb9@byu.net>
758f9126	2009-11-19T09:17:24	autoupdate
ba4000b0	2009-11-19T15:55:58	xfreopen: new module, from coreutils * modules/xfreopen: New module. * lib/xfreopen.c: New file. * lib/xfreopen.h: New file. * MODULES.html.sh (File stream based Input/Output"): Add it.
841ad196	2009-11-19T06:42:21	manywarnings: depend on warnings * modules/manywarnings (Depends-on): Add warnings. Signed-off-by: Eric Blake <ebb9@byu.net>

63983c0a

2009-12-10T14:14:13

Add pty module for forkpty and openpty.

238a6434

2009-12-10T14:08:47

stdio: Avoid syntax error in C++ mode.

545c8ff9

2009-12-10T12:22:41

Use sed with option -e.

51d5e813

2009-12-10T12:17:19

mgetgroups: do not write bytes beyond end of malloc'd buffer * lib/mgetgroups.c: Fix an off-by-one error. When we have no username, we call getgroups with a one-element-shorter buffer, but still told it the length was original, max_n_groups.

b82fdd08

2009-12-09T17:14:12

cloexec: relax license cloexec is a thin wrapper around fcntl, which is a glibc function and therefore reasonable for LGPL. Jim Meyering and Bruno Haible agreed to the change. * modules/cloexec (Maintainer): Add myself. (License): Use LGPL, not GPL. Signed-off-by: Eric Blake <ebb9@byu.net>

a7f94464

2009-12-09T16:11:27

link-warning: optimize generation Avoid a useless use of cat. * modules/link-warning (Makefile.am): Reduce process usage. Signed-off-by: Eric Blake <ebb9@byu.net>

bd5a4d9f

2009-12-09T22:04:36

unsetenv: Document last workaround.

c0b67899

2009-12-09T17:34:02

link-warning: Allow extra lines at the top of build-aux/link-warning.h.

d49061eb

2009-12-09T14:13:08

mgetgroups: Avoid undefined behaviour when ng == 0.

237d7dcd

2009-12-09T12:41:19

link-warning: Add copyright notice.

a226e8ae

2009-12-09T12:11:36

fchdir: Optimize away rpl_fstat when possible.

e29e19dc

2009-12-09T11:49:30

fchdir: Update comment.

61808c7c

2009-12-09T11:37:17

Fix a recent ChangeLog entry.

645bcdec

2009-12-09T11:21:35

cloexec: Clarify code.

aeb9a8a8

2009-12-08T10:23:27

fchdir: avoid memory leak on re-registration. Some code paths (such as dup3) could overwrite one registered directory fd with another, and must not leak the old name. * lib/fchdir.c (ensure_dirs_slot): Avoid memory leak. Signed-off-by: Eric Blake <ebb9@byu.net>

5aad650f

2009-12-08T20:37:50

init.sh: avoid Solaris 10 /bin/sh portability problem Solaris 10's /bin/sh does not pass '.' arguments 2..N to the sourced script: $ printf 'echo "$@"\n' > f; /bin/sh -c '. ./f bar' $ printf 'echo "$@"\n' > f; bash -c '. ./f bar' bar tests/init.sh relied on that, accepting a --set-path=DIR argument, and two tests used that idiom. * tests/init.sh: Update suggested usage comments. (path_prepend_): New function, to be used in place of the --src-path=DIR option. Disallow empty strings and strings containing ":". (setup_): Move PATH-prepending code into path_prepend_. * tests/test-pread.sh: Adapt to new usage. * tests/test-xalloc-die.sh: Likewise.

20378b72

2009-12-08T17:44:19

Document pty.h functions.

2966d0d2

2009-12-08T06:13:05

fchdir: fix logic bugs Configuring with ac_cv_func_fchdir=no on a system that has fchdir and where open handles directories, just to test out the replacement capabilities, uncovered an m4 test bug and a link failure on rpl_fstat. * m4/fchdir.m4 (gl_FUNC_FCHDIR): Fix logic bug. * tests/test-fchdir.c (main): Enhance test. * lib/fchdir.c (rpl_fstat): Always provide if fchdir replacement is in use. Signed-off-by: Eric Blake <ebb9@byu.net>

21a0a9e3

2009-12-07T21:08:17

dup2: fix logic bugs If the platform has dup2, don't register with fchdir if the destination was -1. If the platform lacks dup2 (are there any these days?), then don't close the destination unless the source is valid, make sure errno is correct, and only register with fchdir on fcntl (since dup is already overridden to do a registration). * lib/dup2.c (dup2): Fix logic bugs. Use HAVE_DUP2 rather than REPLACE_DUP2 to decide when rpl_dup2 is needed. * m4/dup2.m4 (gl_REPLACE_DUP2): Only define REPLACE_DUP2 when dup2 exists. (gl_FUNC_DUP2): Drop unneeded AC_SUBST. Signed-off-by: Eric Blake <ebb9@byu.net>

67ac31ed

2009-12-07T17:15:07

unlink: fix m4 detection The m4 test failed under -Werror due to implicit declaration. * m4/unlink.m4 (gl_FUNC_UNLINK): Include correct header. Signed-off-by: Eric Blake <ebb9@byu.net>

a1afba1b

2009-12-07T10:17:07

unistd-safer: add unit test Add more unit tests. Meanwhile, fix compilation error on mingw when testing unistd-safer and fchdir together; and avoid gcc warning on platforms without setmode. * modules/unistd-safer-tests: New file. * tests/test-dup-safer.c: Likewise. * tests/test-cloexec.c (setmode): Avoid compiler warning. * tests/test-dup2.c (setmode): Likewise. * lib/cloexec.c (dup_cloexec): Fix mingw compile error. Signed-off-by: Eric Blake <ebb9@byu.net>

73da5fb7

2009-12-07T06:53:59

cloexec: preserve text vs. binary across dup_cloexec On mingw, dup_cloexec mistakenly converted a text fd into a binary fd. Cygwin copied the source mode. Most other platforms don't distinguish between modes. * lib/cloexec.c (dup_cloexec) [W32]: Query and use translation mode. * modules/dup2-tests (Depends-on): Add binary-io. * modules/cloexec-tests (Depends-on): Likewise. * tests/test-dup2.c (setmode, is_mode): New helpers. (main): Add tests that translation mode is preserved. * tests/test-cloexec.c (setmode, is_mode, main): Likewise. Reported by Bruno Haible. Signed-off-by: Eric Blake <ebb9@byu.net>

b1ab442e

2009-12-04T14:07:58

mgetgroups: reduce duplicate listings POSIX doesn't guarantee whether the effective gid is included in the list of supplementary groups returned by getgroups. On the other hand, some platforms include the effective gid twice in the list. Meanwhile, mgetgroups can independently add a duplicate. Rather than spend a full-blown O(n log n) cleanup, we just remove the most common forms of duplicate groups with an O(n) pass. * lib/mgetgroups.c (mgetgroups): Reduce duplicates from the resulting array. * tests/test-chown.h (test_chown): Simplify client. * tests/test-lchown.h (test_lchown): Likewise. Signed-off-by: Eric Blake <ebb9@byu.net>

68145a07

2009-12-07T01:02:50

cloexec: Fix possible compilation error.

3941f59c

2009-12-06T23:19:49

prognam: Add diagnostic.

6ed67a15

2009-12-05T06:39:09

pipe2-safer: new module pipe2 deserves a *_safer variant. It also makes the code in pipe.c look simpler. * modules/pipe2-safer: New file. * lib/unistd-safer.h (pipe2_safer): New prototype. * lib/unistd--.h (pipe2): New wrapper. * lib/pipe-safer.c (pipe2_safer): New function. * modules/pipe (Depends-on): Add pipe2-safer. * lib/pipe.c (create_pipe) [WIN32]: Let pipe2_safer do the work. Signed-off-by: Eric Blake <ebb9@byu.net>

f2fdd542

2009-11-16T16:09:42

stdlib-safer: preserve cloexec flag for mkostemp[s] mkostemp_safer(templ,O_CLOEXEC) did not always guarantee cloexec. * lib/mkstemp-safer.c (mkostemp_safer, mkostemps_safer): Use new fd_safer_flag. Signed-off-by: Eric Blake <ebb9@byu.net>

14449a1d

2009-12-05T06:36:33

unistd-safer: allow preservation of cloexec status via flag If cloexec is in use, allow the ability to preserve cloexec flag across *_safer functions. * lib/unistd-safer.h (dup_safer_flag, fd_safer_flag): New prototypes. * lib/dup-safer.c (dup_safer_flag): New function. * lib/fd-safer.c (fd_safer_flag): Likewise. * modules/cloexec (configure.ac): Set witness. Signed-off-by: Eric Blake <ebb9@byu.net>

173359db

2009-12-05T06:19:01

test-dup2: enhance test Ensure that dup2(cloexec_fd, target) returns an inheritable fd. * modules/dup2-tests (Depends-on): Add cloexec. * tests/test-dup2.c (main): Enhance test. Signed-off-by: Eric Blake <ebb9@byu.net>

d8ccc13b

2009-12-04T22:10:44

cloexec: add dup_cloexec This is needed to enforce correct semantics of mkostemp_safer. Meanwhile, it is one step closer to providing O_CLOEXEC support to open, as well as implementing portions of fcntl for mingw. * lib/cloexec.h (dup_cloexec): New prototype. Add copyright header and comments. * lib/cloexec.c (set_cloexec_flag): Add comments. (dup_cloexec): New function, with mingw implementation borrowed from... * lib/w32spawn.h (dup_noinherit): ...here. * modules/execute (Depends-on): Add cloexec. * modules/pipe (Depends-on): Likewise. * modules/cloexec (Depends-on): Add dup2. * modules/cloexec-tests (Files): New file. * tests/test-cloexec.c: Likewise. Signed-off-by: Eric Blake <ebb9@byu.net>

a4cfedb0

2009-12-05T09:24:54

test-xalloc-die: fix test for mingw When cross-compiling on mingw to target mingw, argv[0] still includes a .exe suffix. Rather than worry about ${EXEEXT}, just add a sed post-process. Also, simplify the script by using tests/init.sh. * modules/xalloc-die-tests (Files): Add tests/init.sh. * tests/test-xalloc-die.sh: Rewrite to use init.sh. Strip directory and .exe suffix off argv[0] output. Signed-off-by: Eric Blake <ebb9@byu.net>

e4488f18

2009-12-05T09:07:28

test-fseeko: fix test for mingw Undefining fseek made test-fseeko.sh fail when testing on pipes. * tests/test-fseeko.c (fseek): Redefine GL_LINK_WARNING, rather than undefining fseek, so test will pass on mingw. Signed-off-by: Eric Blake <ebb9@byu.net>

9a1388f4

2009-12-05T05:36:19

autoupdate

32928258

2009-12-05T12:14:04

progname: Clarify specification.

208edc20

2009-12-05T10:02:01

maint.mk: backslash-escape parens in default regexp * top/maint.mk (news-check-regexp): Now that we're using grep -E, backslash-escape the literal parentheses.

875fb2d6

2009-12-05T09:35:28

maint.mk: news-check: use grep -E * top/maint.mk (today): Define a Make variable, not a... (news-date-check): ...shell variable. (news-check-regexp): Use the Make variable. Use grep's -E option. Change the failing diagnostic to mention the variable, $(news-check-regexp). (news-check): Rename target from news-date-check. Update sole use.

9ecc3fc8

2009-12-04T21:27:40

maintainer-makefile: allow customization of NEWS entry format * top/maint.mk (news-date-regexp): New overridable variable. (news-date-check): Use it. Signed-off-by: Eric Blake <ebb9@byu.net>

3e035a5d

2009-12-04T08:26:23

mgetgroups: add xgetgroups, and avoid ENOSYS failures ENOSYS implies that there are no supplemental groups, so we can treat it the same as a return of 0 from getgroups rather than exposing failure to the user. This in turn fixes a crash in coreutils' id, which freed an uninitialized pointer. * lib/mgetgroups.h (xgetgroups): New prototype. * lib/mgetgroups.c (xgetgroups): New wrapper. (mgetgroups): Handle ENOSYS. * modules/mgetgroups (Depends-on): Add realloc. Reported by Scott Harrison <scott.gnu.2009@scottrix.co.uk>. Signed-off-by: Eric Blake <ebb9@byu.net>

3425a9dd

2009-12-04T14:37:32

mgetgroups: avoid argument promotion issues with -1 On platforms where gid_t is equivalent to uint16_t, argument promotion states that -1 != (gid_t) -1. * lib/mgetgroups.c (mgetgroups): A cast is required when checking for invalid gid_t. * tests/test-chown.h (getegid, test_chown): Likewise. * tests/test-lchown.h (getegid, test_lchown): Likewise. Signed-off-by: Eric Blake <ebb9@byu.net>

c5588be3

2009-12-03T18:39:47

exclude: Fix header file problems. * lib/exclude.h: Add multiple inclusion guards and include stdbool.h.

563c7796

2009-12-01T06:38:45

autoupdate

cdfe647f

2009-12-01T12:06:34

fts: fts_open: do not let an empty string cause immediate failure This is required in support of GNU rm, for which the command "rm A '' B" must process and remove both A and B, in spite of the empty string argument. * lib/fts.c (fts_open): Do not let the presence of an empty string cause fts_open to fail immediately. Most fts-using tools must be able to process all arguments, in order, and can be expected to diagnose such arguments themselves. Also, move declaration of local, "len", "down" to initialization.

52f2ca7c

2009-11-30T06:45:42

utimens: fix compilation error Fixes a regression from 2009-11-25. * lib/utimens.c (lutimens) [!HAVE_UTIMENSAT && HAVE_LUTIMES]: Declare variable at right scope. Signed-off-by: Eric Blake <ebb9@byu.net>

acf2fa81

2009-11-30T12:29:03

bootstrap: fix handling of various perl --version formats * build-aux/bootstrap (get_version): Don't use perl's $] special variable, as that requires updating all bootstrap.conf files to use perl's x.yyyzzz version format. Instead make the regular expression more general to support version formats from older perl-5.005_002 (5.5.2) and perl-5.11 which has other numbers in the version line.

f203a8f4

2009-11-29T13:57:05

bootstrap: handle perl-5.11's changed --version output * build-aux/bootstrap (get_version): Handle perl separately, since perl-5.11's --version output is different.

cf8ddf08

2009-11-28T09:28:40

userspec: depend on the inttostr module, too * modules/userspec (Depends-on): Add inttostr.

2ead6c09

2009-11-28T07:33:16

userspec: disallow an ID that maps to (uid_t)-1 or (gid_t)-1 * lib/userspec.c (parse_with_separator): Do not accept a user ID number of MAXUID when it evaluates to (uid_t) -1. Likewise for group ID. Reported by Matt McCutchen in <http://savannah.gnu.org/bugs/?28113>

42956c5d

2009-11-28T07:26:53

userspec: reformat to use spaces, not TABs * lib/userspec.c: Expand TABs to spaces. Add Emacs' "indent-tabs-mode: nil" hint.

c0c5acfb

2009-11-27T17:47:21

getopt-gnu: flush out another BSD bug POSIX requires 'echo foo > bar; m4 -Dfoo=1 bar -Dfoo=2 bar' to output '1' then '2'. To achieve this, m4 relies on the GNU getopt{,_long} extension of a leading '-'. However, BSD getopt fails to honor this extension when POSIXLY_CORRECT. Also, BSD getopt fails to reparse POSIXLY_CORRECT from the environment even when a reset is requested (whether by optreset=1 or by optind=0). * m4/getopt.m4 (gl_GETOPT_CHECK_HEADERS): Test for the bug. * tests/test-getopt.c (main): Check POSIXLY_CORRECT first, to flush out BSD bug. * tests/test-getopt.h (test_getopt): End lists with NULL. * tests/test-getopt_long.h (test_getopt_long): Likewise. (test_getopt_long_posix): Enhance test. * modules/getopt-posix-tests (Depends-on): Add stdbool. * doc/glibc-functions/getopt_long.texi (getopt_long): Mention getopt-gnu. * doc/glibc-functions/getopt_long_only.texi (getopt_long_only): Likewise. Signed-off-by: Eric Blake <ebb9@byu.net>

6184bd14

2009-11-27T16:13:37

modules/idpriv-droptemp-tests (Notice): Fix text.

fed81b33

2009-11-27T10:19:32

test-xalloc-die: avoid spurious failure due to libtool argv difference In a libtool-enabled project, this test would fail due to a difference in the emitted program name, e.g., -test-xalloc-die: memory exhausted +/tmp/.../tests/.libs/lt-test-xalloc-die: memory exhausted Use program to avoid that. * modules/xalloc-die-tests (Depends-on): Add progname. * tests/test-xalloc-die.c: Include progname.h". (program_name): Remove decl. (main): Call set_program_name. * tests/test-xalloc-die.sh (compare): Remove unnecessary ${EXE}.

dfd793fa

2009-11-26T20:29:16

w32sock: leave win32 error in place. * lib/w32sock.h (set_winsock_errno): Do not call WSASetLastError.

9bb0a7e5

2009-11-26T09:39:26

init.sh: suggest to use skip_ and fail_ functions in comments * tests/init.sh: Add a sentence.

0975a057

2009-11-26T09:24:51

init.sh: add documentation in comments * tests/init.sh: Add some developer and user documentation.

94a77054

2009-11-26T09:10:04

init.sh: accommodate even those who specify bogus srcdir manually * tests/init.sh: Normally, srcdir is guaranteed by automake and configure-time tests to be sanitized, so that there is no need to use "$srcdir" in Makefile rules and shell scripts. Using $srcdir (with no double quotes) suffices. However, since tests may be invoked manually, and since you may explicitly set srcdir to the name of a directory containing spaces, do quote its uses here. * tests/test-pread.sh: Likewise. Suggested by Bruno Haible.

2fbe7721

2009-11-26T08:51:11

test-pread.sh: avoid diagnostics for those who ignore SIGPIPE * tests/test-pread.sh: Write no data into the pipe, because test-pread actually reads none. This avoids a diagnostic, "bash: echo: write error: Broken pipe", that arises in the unusual event something is ignoring SIGPIPE, and might be interpreted as some sort of failure. Reported by Bruno Haible.

1baf5e2a

2009-11-25T18:26:35

test-pread: cover failure with ESPIPE and EINVAL * tests/test-pread.c (main): Test for failure, too. * tests/test-pread.sh: Invoke with stdin on a pipe. Suggested by Eric Blake.

23cd7413

2009-11-25T18:01:02

pread: improvement and fix * modules/pread (Depends-on): Depend on lseek, for portability to e.g., mingw. Suggested by Eric Blake. * lib/pread.c (__libc_read): Define. Reported by Richard W.M. Jones.

8def010e

2009-11-25T17:06:25

unistd.in.h: correct declaration of pread * lib/unistd.in.h: Correct type of "buf" parameter: void*, not char* Reported by Richard W.M. Jones.

dbf9a707

2009-11-25T16:59:15

test-pread.sh: distribute the test script * modules/pread-tests (Files): Include test-pread.sh.

9b1723bc

2009-11-25T16:52:47

test-pread.sh: clean up * tests/test-pread.sh: Don't refer to $builddir. Just use equivalent ".". * modules/pread-tests (TESTS_ENVIRONMENT): Don't export builddir. That is unnecessary, since it's always ".". Suggestion from Eric Blake.

e185811d

2009-11-25T16:37:42

test-pread.sh: make executable * tests/test-pread.sh: Set executable bit. Reported by Eric Blake.

a722f997

2009-11-25T16:14:19

correct typo in test-pread.sh * tests/test-pread.sh: Add #! line.

ebbfe985

2009-11-25T15:50:56

test pread * tests/test-pread.c: New file. * tests/test-pread.sh: Likewise. * modules/pread-tests: Likewise.

f84e1a91

2009-11-25T14:33:30

pread: new module * modules/pread: New file. * lib/pread.c (pread): New file. * m4/pread.m4: Likewise. * lib/unistd.in.h (pread): Define/declare. * m4/unistd_h.m4 (gl_UNISTD_H_DEFAULTS): Define defaults. * modules/unistd (Makefile.am): Substitute witnesses. * doc/posix-functions/pread.texi (pread): Update. * MODULES.html.sh: Add pread.

ef77cd53

2009-11-25T14:40:31

tests/init.sh: new file to be used via most *.sh tests * tests/init.sh: New file.

0457832f

2009-11-24T10:07:57

utimens: work around older Linux failure with symlinks Some Linux kernel versions support utimensat(,0) but not utimensat(,AT_SYMLINK_NOFOLLOW), even for non-symlinks. Had the fallback code for regular files been reached, it would have truncated timestamps. But since glibc lutimes just wraps utimensat, and we didn't expect ENOSYS from lutimes, the fallback wasn't even reached. * lib/utimens.c (lutimensat_works_really): New variable. (fdutimens, lutimens): Use it to manage kernels that support nanosecond times on files, but not on symlinks. Reported by Ondřej Vašík. Signed-off-by: Eric Blake <ebb9@byu.net>

63a3cbb6

2009-11-24T10:00:18

utimes: fix configure grammar 'Checking determine whether...' doesn't read well. * m4/utimes.m4 (gl_FUNC_UTIMES): Delete spurious word. Signed-off-by: Eric Blake <ebb9@byu.net>

2bc9cabc

2009-11-25T11:41:09

regex: Fix fastmap for multibyte character ranges. * lib/regcomp.c (re_compute_fastmap_iter): Add all multibyte lead characters when a multibyte character range is included.

29508f24

2009-11-22T09:47:12

version-etc: work also with AM_INIT_AUTOMAKE's no-define option * lib/version-etc.c [!defined PACKAGE]: Define to PACKAGE_TARNAME.

44834c9e

2009-11-25T01:53:37

doc: Most *_l functions exist in MacOS X 10.5.

def56200

2009-11-25T01:49:04

doc: Most *_l functions exist in MacOS X 10.5.

6575ab51

2009-11-24T10:44:40

duplocale: Fix logic bug.

0fe2cbf6

2009-11-23T11:28:00

test-update-copyright: don't hard-code /usr/bin/perl * tests/test-update-copyright.sh (YEAR): Use date +%Y, rather than perl to print the current year. Gilles Espinasse reported that the replaced use of perl was hard-coded as /usr/bin/perl.

a88cd6da

2009-11-23T11:05:42

duplocale: Add support for glibc 2.3.x.

0581dde5

2009-11-23T02:43:23

vasnprintf: Tiny optimization.

2430ab9f

2009-11-23T01:47:07

Tests for module 'duplocale'.

3f0d472e

2009-11-23T01:46:00

New module 'duplocale'.

15b8a934

2009-11-22T23:32:54

Check that <locale.h> defines locale_t and LC_GLOBAL_LOCALE.

17d63e84

2009-11-22T23:31:11

locale: Make locale_t available when possible.

c2f52a86

2009-11-23T01:03:24

Add comments.

84aee6d7

2009-11-22T19:33:24

Oops, move the include of unistd.h in the last commit.

c2af86ba

2009-11-22T19:30:39

error: account for the possibility of freopen (stdout).

4e765f32

2009-11-22T19:07:34

Add comment.

1398c0de

2009-11-22T17:11:14

c-stack: avoid defining an unused static function * lib/c-stack.c (find_stack_direction): Do not define this function when it will not be used.

32be9f34

2009-11-22T09:01:07

diffseq: avoid spurious gcc warnings * lib/diffseq.h (IF_LINT2): Define. (compareseq): Use it to initialize two members of "part". This avoids two used-uninitialized warnings.

df57f427

2009-11-21T17:52:54

c-stack: avoid "ignoring return value of `write'" warning * lib/c-stack.c: Include "ignore-value.h". (die): Explicitly ignore each write return value. * modules/c-stack (Depends-on): Add ignore-value.

e9b552cf

2009-11-21T07:12:27

autoupdate

833e6a3e

2009-11-21T14:37:46

diffseq: reduce scope of variable 'best'.

a823652c

2009-11-21T13:49:54

diffseq: remove useless assignment to "best" * lib/diffseq.h (diag) [USE_HEURISTIC]: Remove useless "best = 0" assignment. At that point "best" is already guaranteed to be zero.

481f709c

2009-11-20T06:23:42

build: mention ftp redirector in release announcements Now that http://ftpmirror.gnu.org/PACKAGE/ redirects to a nearby mirror, we should promote its use in release announcements. Meanwhile, mention the mirror list. * top/maint.mk (gnu_rel_host, url_dir_list): Provide defaults for values that used to come from cfg.mk; mention FTP redirect URL. * build-aux/announce-gen: Mention the mirror list. Suggested by Karl Berry. Signed-off-by: Eric Blake <ebb9@byu.net>

addbb8a8

2009-11-18T22:14:39

nanosleep: improve port to mingw test-nanosleep failed to link, and exposed a need for argument validation when nanosleep is missing. * lib/nanosleep.c (rpl_nanosleep): Reject invalid arguments. * m4/nanosleep.m4 (gl_FUNC_NANOSLEEP): Incorporate LIBSOCKET into LIB_NANOSLEEP, but only when needed. * modules/select (Link): Document LIBSOCKET. * m4/select.m4 (gl_FUNC_SELECT): Ensure LIBSOCKET is defined early enough.

a905b350

2009-11-18T20:10:42

nanosleep: work around cygwin bug Cygwin 1.5.x mistakenly failed with EINVAL for a duration longer than 49.7 days (2**32 milliseconds). Meanwhile, the existing code for HAVE_BUG_BIG_NANOSLEEP would infloop, instead of return failure, for invalid arguments. * lib/nanosleep.c (rpl_nanosleep) [HAVE_BUG_BIG_NANOSLEEP]: Fix logic bug when nanosleep fails. Work around cygwin 1.5.x bug. (getnow): Delete, not needed. * m4/nanosleep.m4 (gl_FUNC_NANOSLEEP): No longer require LIB_CLOCK_GETTIME. * modules/nanosleep (Depends-on): Add intprops and verify. Drop clock-time, gettime. * doc/posix-functions/nanosleep.texi (nanosleep): Document the bug. * modules/nanosleep-tests: New test. * tests/test-nanosleep.c: New file. Signed-off-by: Eric Blake <ebb9@byu.net>

6baa4663

2009-11-18T20:07:44

sleep: work around cygwin bug On cygwin 1.5.x, sleep amounts larger than 49.7 days (2**32 milliseconds) failed instantly, but with a garbage return value from uninitialized memory. * lib/sleep.c (rpl_sleep): Work around the bug. * m4/sleep.m4 (gl_FUNC_SLEEP): Detect the bug. (gl_PREREQ_SLEEP): Delete unused macro. * modules/sleep (Depends-on): Add verify. * m4/unistd_h.m4 (gl_UNISTD_H_DEFAULTS): Add default. * modules/unistd (Makefile.am): Substitute witness. * lib/unistd.in.h (sleep): Update prototype. * doc/posix-functions/sleep.texi (sleep): Document the bug. * tests/test-sleep.c (main) [HAVE_DECL_ALARM]: Test it. * modules/sleep-tests (Depends-on): Check for alarm. Signed-off-by: Eric Blake <ebb9@byu.net>

00b2f10b

2009-11-20T13:24:24

maint.mk: improve sc_prohibit_magic_number_exit * top/maint.mk (sc_prohibit_magic_number_exit): Tighten regexp so it does not match uses like System.exit(1). Add comments showing how to correct all offenders.

b5104eb4

2009-11-19T09:12:34

xalloc-die-tests: add missing library * modules/xalloc-die-tests (Makefile.am): Add LDADD line. Signed-off-by: Eric Blake <ebb9@byu.net>

21d7dbb8

2009-11-19T08:51:13

test-xvasprintf: silence compiler warnings * tests/test-xvasprintf.c (test_xvasprintf, test_xasprintf): Mask empty string from gcc. Signed-off-by: Eric Blake <ebb9@byu.net>

758f9126

2009-11-19T09:17:24

autoupdate

ba4000b0

2009-11-19T15:55:58

xfreopen: new module, from coreutils * modules/xfreopen: New module. * lib/xfreopen.c: New file. * lib/xfreopen.h: New file. * MODULES.html.sh (File stream based Input/Output"): Add it.

841ad196

2009-11-19T06:42:21

manywarnings: depend on warnings * modules/manywarnings (Depends-on): Add warnings. Signed-off-by: Eric Blake <ebb9@byu.net>

kc3-lang/gnulib

Log