Hash :
1e642be9
Author :
Date :
2009-11-13T12:53:17
getgroups: work around FreeBSD bug FreeBSD 7.2 mistakenly succeeds on getgroups(-1,ptr) (POSIX requires EINVAL failure since -1 is less than the proper result). * lib/getgroups.c (rpl_getgroups): Work around the bug. * m4/getgroups.m4 (gl_FUNC_GETGROUPS): Detect the bug. * doc/posix-functions/getgroups.texi (getgroups): Document it. * tests/test-getgroups.c (main): Fix buffer overrun. Signed-off-by: Eric Blake <ebb9@byu.net>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85
/* Tests of getgroups.
Copyright (C) 2009 Free Software Foundation, Inc.
This program is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 3 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>. */
/* Written by Eric Blake <ebb9@byu.net>, 2009. */
#include <config.h>
#include <unistd.h>
#include <errno.h>
#include <stdio.h>
#include <stdlib.h>
#include <stdint.h>
#define ASSERT(expr) \
do \
{ \
if (!(expr)) \
{ \
fprintf (stderr, "%s:%d: assertion failed\n", __FILE__, __LINE__); \
fflush (stderr); \
abort (); \
} \
} \
while (0)
int
main (int argc, char **argv _UNUSED_PARAMETER_)
{
int result;
gid_t *groups;
errno = 0;
result = getgroups (0, NULL);
if (result == -1 && errno == ENOSYS)
{
fputs ("skipping test: no support for groups\n", stderr);
return 77;
}
ASSERT (0 <= result);
ASSERT (result + 1 < SIZE_MAX / sizeof *groups);
groups = malloc ((result + 1) * sizeof *groups);
ASSERT (groups);
groups[result] = -1;
/* Check for EINVAL handling. Not all processes have supplemental
groups, and getgroups does not have to return the effective gid,
so a result of 0 is reasonable. Also, we can't test for EINVAL
if result is 1, because of how getgroups treats 0. */
if (1 < result)
{
errno = 0;
ASSERT (getgroups (result - 1, groups) == -1);
ASSERT (errno == EINVAL);
}
ASSERT (getgroups (result, groups) == result);
ASSERT (getgroups (result + 1, groups) == result);
ASSERT (groups[result] == -1);
errno = 0;
ASSERT (getgroups (-1, NULL) == -1);
ASSERT (errno == EINVAL);
/* The automated unit test, with no arguments, ends here. However,
for debugging purposes, you can pass a command-line argument to
list the returned groups. */
if (1 < argc)
{
int i;
for (i = 0; i < result; i++)
printf ("%d\n", (int) groups[i]);
}
return 0;
}