Hash :
8c871c07
Author :
Date :
2009-10-20T16:47:36
utimensat: work around Solaris 9 bug
utimes("file/",times) mistakenly succeeds. This commit doesn't fix
utimes, but does make utimensat be careful before calling utimes.
The test is now enhanced to test trailing slashes and directories.
Meanwhile, cygwin 1.5 stat() on a directory changes atime (it does
a readdir under the hood to populate st_nlink), so only mtime of
a directory is reliable enough for testing. Cygwin 1.7 no longer
has this problem, because it no longer wastes time on st_nlink.
* lib/utimens.c (fdutimens, lutimens): Force a stat if platform
has trailing slash bugs.
* tests/test-lutimens.h (test_lutimens): Enhance test.
* tests/test-utimens.h (test_utimens): Likewise.
* doc/posix-functions/utime.texi (utime): Document the bug.
* doc/posix-functions/utimes.texi (utimes): Likewise.
* doc/posix-functions/utimensat.texi (utimensat): Likewise.
* doc/glibc-functions/futimesat.texi (futimesat): Likewise.
* doc/glibc-functions/lutimes.texi (lutimes): Mention utimens.
* doc/posix-functions/futimens.texi (futimens): Mention
limitation.
Signed-off-by: Eric Blake <ebb9@byu.net>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179
/* Test of file timestamp modification functions.
Copyright (C) 2009 Free Software Foundation, Inc.
This program is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 2 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>. */
#include "test-utimens-common.h"
/* This file is designed to test both lutimens(a,b) and
utimensat(AT_FDCWD,a,b,AT_SYMLINK_NOFOLLOW). FUNC is the function
to test. Assumes that BASE and ASSERT are already defined. If
PRINT, warn before skipping tests with status 77. */
static int
test_lutimens (int (*func) (char const *, struct timespec const *), bool print)
{
int result;
int saved_errno;
struct stat st1;
struct stat st2;
bool atime_supported = true;
/* Non-symlinks should be handled just like utimens. */
errno = 0;
ASSERT (func ("no_such", NULL) == -1);
ASSERT (errno == ENOENT);
errno = 0;
ASSERT (func ("no_such/", NULL) == -1);
ASSERT (errno == ENOENT || errno == ENOTDIR);
errno = 0;
ASSERT (func ("", NULL) == -1);
ASSERT (errno == ENOENT);
ASSERT (close (creat (BASE "file", 0600)) == 0);
ASSERT (stat (BASE "file", &st1) == 0);
ASSERT (st1.st_atime != Y2K);
ASSERT (st1.st_mtime != Y2K);
{
struct timespec ts[2] = { { Y2K, 0 }, { Y2K, 0 } };
errno = 0;
ASSERT (func (BASE "file/", ts) == -1);
ASSERT (errno == ENOTDIR);
ASSERT (stat (BASE "file", &st2) == 0);
ASSERT (st1.st_atime == st2.st_atime);
ASSERT (st1.st_mtime == st2.st_mtime);
}
{
struct timespec ts[2] = { { Y2K, 0 }, { Y2K, 0 } };
ASSERT (func (BASE "file", ts) == 0);
}
ASSERT (stat (BASE "file", &st1) == 0);
ASSERT (st1.st_atime == Y2K);
ASSERT (st1.st_mtime == Y2K);
/* Play with symlink timestamps. */
if (symlink (BASE "file", BASE "link"))
{
ASSERT (unlink (BASE "file") == 0);
if (print)
fputs ("skipping test: symlinks not supported on this file system\n",
stderr);
return 77;
}
errno = 0;
result = func (BASE "link", NULL);
saved_errno = errno;
/* Make sure we did not reference through link by accident. */
ASSERT (stat (BASE "file", &st1) == 0);
ASSERT (st1.st_atime == Y2K);
ASSERT (st1.st_mtime == Y2K);
ASSERT (lstat (BASE "link", &st1) == 0);
ASSERT (st1.st_atime != Y2K);
ASSERT (st1.st_mtime != Y2K);
ASSERT (unlink (BASE "file") == 0);
if (result == -1 && saved_errno == ENOSYS)
{
ASSERT (unlink (BASE "link") == 0);
if (print)
fputs ("skipping test: "
"setting symlink time not supported on this file system\n",
stderr);
return 77;
}
ASSERT (!result);
ASSERT (lstat (BASE "link", &st1) == 0);
/* On cygwin, lstat() changes atime of symlinks, so that lutimens
can only effectively modify mtime. */
nap ();
ASSERT (lstat (BASE "link", &st2) == 0);
if (st1.st_atime != st2.st_atime
|| get_stat_atime_ns (&st1) != get_stat_atime_ns (&st2))
atime_supported = false;
/* Invalid arguments. */
{
struct timespec ts[2] = { { Y2K, UTIME_BOGUS_POS }, { Y2K, 0 } };
errno = 0;
ASSERT (func (BASE "link", ts) == -1);
ASSERT (errno == EINVAL);
}
{
struct timespec ts[2] = { { Y2K, 0 }, { Y2K, UTIME_BOGUS_NEG } };
errno = 0;
ASSERT (func (BASE "link", ts) == -1);
ASSERT (errno == EINVAL);
}
ASSERT (lstat (BASE "link", &st2) == 0);
if (atime_supported)
{
ASSERT (st1.st_atime == st2.st_atime);
ASSERT (get_stat_atime_ns (&st1) == get_stat_atime_ns (&st2));
}
ASSERT (utimecmp (BASE "link", &st1, &st2, 0) == 0);
/* Set both times. */
{
struct timespec ts[2] = { { Y2K, BILLION / 2 - 1 }, { Y2K, BILLION - 1 } };
ASSERT (func (BASE "link", ts) == 0);
ASSERT (lstat (BASE "link", &st2) == 0);
if (atime_supported)
{
ASSERT (st2.st_atime == Y2K);
ASSERT (0 <= get_stat_atime_ns (&st2));
ASSERT (get_stat_atime_ns (&st2) < BILLION / 2);
}
ASSERT (st2.st_mtime == Y2K);
ASSERT (0 <= get_stat_mtime_ns (&st2));
ASSERT (get_stat_mtime_ns (&st2) < BILLION);
}
/* Play with UTIME_OMIT, UTIME_NOW. */
{
struct timespec ts[2] = { { BILLION, UTIME_OMIT }, { 0, UTIME_NOW } };
ASSERT (func (BASE "link", ts) == 0);
ASSERT (lstat (BASE "link", &st2) == 0);
if (atime_supported)
{
ASSERT (st2.st_atime == Y2K);
ASSERT (0 <= get_stat_atime_ns (&st2));
ASSERT (get_stat_atime_ns (&st2) < BILLION / 2);
}
ASSERT (utimecmp (BASE "link", &st1, &st2, 0) <= 0);
}
/* Symlink to directory. */
ASSERT (unlink (BASE "link") == 0);
ASSERT (symlink (BASE "dir", BASE "link") == 0);
ASSERT (mkdir (BASE "dir", 0700) == 0);
{
struct timespec ts[2] = { { Y2K, 0 }, { Y2K, 0 } };
ASSERT (func (BASE "link/", ts) == 0);
}
/* On cygwin 1.5, stat() changes atime of directories, so only check
mtime. */
ASSERT (stat (BASE "dir", &st1) == 0);
ASSERT (st1.st_mtime == Y2K);
ASSERT (lstat (BASE "link", &st1) == 0);
ASSERT (st1.st_atime != Y2K);
ASSERT (st1.st_mtime != Y2K);
ASSERT (func (BASE "link", NULL) == 0);
ASSERT (stat (BASE "dir", &st1) == 0);
ASSERT (st1.st_mtime == Y2K);
ASSERT (lstat (BASE "link", &st1) == 0);
ASSERT (st1.st_atime != Y2K);
ASSERT (st1.st_mtime != Y2K);
/* Cleanup. */
ASSERT (rmdir (BASE "dir") == 0);
ASSERT (unlink (BASE "link") == 0);
return 0;
}