kc3-lang/gnulib/tests/test-openat-safer.c

• Show log

  Commit

• Hash : 82381b9e
  Author :
  Date : 2009-10-22T07:59:46
  

  tests: avoid several compiler warnings
  
  * tests/test-getcwd.c (main): Avoid buffer underflow.
  * tests/test-getdate.c (main): String literals are not safe with
  putenv, so use setenv.  Declare unused argument.
  * modules/getdate-tests (Depends-on): Add setenv.
  * tests/test-argv-iter.c (main): Declare unused argument.  Avoid
  problems with string literals in char *.
  * tests/test-hash.c (main): Avoid shadowing declaration.
  (insert_new): Treat string literals as char const *.
  * tests/test-getopt.h (test_getopt): Likewise.
  (getopt_loop): Alter types to minimize casting elsewhere.
  * tests/test-getopt_long.h (test_getopt_long, getopt_long_loop)
  (test_getopt_long_posix): Likewise.
  (do_getopt_long): Add wrapper to minimize casting.
  * tests/test-atexit.c (clear_temp_file): Use void.
  * tests/test-areadlink-with-size.c (main): Declare unused
  arguments.
  * tests/test-areadlink.c (main): Likewise.
  * tests/test-areadlinkat-with-size.c (main): Likewise.
  * tests/test-areadlinkat.c (main): Likewise.
  * tests/test-canonicalize-lgpl.c (main): Likewise.
  * tests/test-canonicalize.c (main): Likewise.
  * tests/test-dirent-safer.c (main): Likewise.
  * tests/test-dirname.c (main): Likewise.
  * tests/test-dup2.c (main): Likewise.
  * tests/test-fchdir.c (main): Likewise.
  * tests/test-fcntl-h.c (main): Likewise.
  * tests/test-fcntl-safer.c (main): Likewise.
  * tests/test-fdopendir.c (main): Likewise.
  * tests/test-fdutimensat.c (main): Likewise.
  * tests/test-fflush.c (main): Likewise.
  * tests/test-filenamecat.c (main): Likewise.
  * tests/test-filevercmp.c (main): Likewise.
  * tests/test-fopen-safer.c (main): Likewise.
  * tests/test-fopen.c (main): Likewise.
  * tests/test-fpending.c (main): Likewise.
  * tests/test-fpurge.c (main): Likewise.
  * tests/test-freading.c (main): Likewise.
  * tests/test-fstatat.c (main): Likewise.
  * tests/test-fsync.c (main): Likewise.
  * tests/test-futimens.c (main): Likewise.
  * tests/test-getndelim2.c (main): Likewise.
  * tests/test-gettimeofday.c (main): Likewise.
  * tests/test-getopt.c (main): Likewise.
  * tests/test-i-ring.c (main): Likewise.
  * tests/test-inttypes.c (main): Likewise.
  * tests/test-link.c (main): Likewise.
  * tests/test-lstat.c (main): Likewise.
  * tests/test-math.c (main): Likewise.
  * tests/test-md5.c (main): Likewise.
  * tests/test-memchr2.c (main): Likewise.
  * tests/test-memrchr.c (main): Likewise.
  * tests/test-mkdir.c (main): Likewise.
  * tests/test-mkdirat.c (main): Likewise.
  * tests/test-mkfifoat.c (main): Likewise.
  * tests/test-open.c (main): Likewise.
  * tests/test-openat-safer.c (main): Likewise.
  * tests/test-openat.c (main): Likewise.
  * tests/test-quotearg.c (main): Likewise.
  * tests/test-rawmemchr.c (main): Likewise.
  * tests/test-readlink.c (main): Likewise.
  * tests/test-remove.c (main): Likewise.
  * tests/test-rename.c (main): Likewise.
  * tests/test-renameat.c (main): Likewise.
  * tests/test-rmdir.c (main): Likewise.
  * tests/test-sha1.c (main): Likewise.
  * tests/test-signal.c (main): Likewise.
  * tests/test-sigaction.c (main): Likewise.
  * tests/test-stat.c (main): Likewise.
  * tests/test-stat-time.c (main): Likewise.
  * tests/test-stddef.c (main): Likewise.
  * tests/test-stdint.c (main): Likewise.
  * tests/test-stdio.c (main): Likewise.
  * tests/test-stdlib.c (main): Likewise.
  * tests/test-strchrnul.c (main): Likewise.
  * tests/test-strerror.c (main): Likewise.
  * tests/test-string.c (main): Likewise.
  * tests/test-strtod.c (main): Likewise.
  * tests/test-strverscmp.c (main): Likewise.
  * tests/test-symlink.c (main): Likewise.
  * tests/test-symlinkat.c (main): Likewise.
  * tests/test-sys_stat.c (main): Likewise.
  * tests/test-sys_time.c (main): Likewise.
  * tests/test-time.c (main): Likewise.
  * tests/test-unistd.c (main): Likewise.
  * tests/test-unlink.c (main): Likewise.
  * tests/test-unlinkat.c (main): Likewise.
  * tests/test-utimens.c (main): Likewise.
  * tests/test-utimensat.c (main): Likewise.
  * tests/test-version-etc.c (main): Likewise.
  * tests/test-wchar.c (main): Likewise.
  * tests/test-wctype.c (main): Likewise.
  * tests/test-xprintf-posix.c (main): Likewise.
  * tests/test-posixtm.c (main): Likewise.
  (STREQ): Delete unused macro.
  * tests/test-linkat.c (main): Declare unused arguments.  Avoid
  shadowed variables.
  * tests/test-memchr.c (main): Likewise.
  
  Signed-off-by: Eric Blake <ebb9@byu.net>
  

Download

• tests/test-openat-safer.c

• /* Test that openat_safer leave standard fds alone.
     Copyright (C) 2009 Free Software Foundation, Inc.
  
     This program is free software: you can redistribute it and/or modify
     it under the terms of the GNU General Public License as published by
     the Free Software Foundation; either version 3 of the License, or
     (at your option) any later version.
  
     This program is distributed in the hope that it will be useful,
     but WITHOUT ANY WARRANTY; without even the implied warranty of
     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
     GNU General Public License for more details.
  
     You should have received a copy of the GNU General Public License
     along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
  
  /* Written by Eric Blake <ebb9@byu.net>, 2009.  */
  
  #include <config.h>
  
  #include "fcntl--.h"
  
  #include <errno.h>
  #include <stdio.h>
  #include <stdlib.h>
  #include <sys/stat.h>
  #include <unistd.h>
  
  /* This test intentionally closes stderr.  So, we arrange to have fd 10
     (outside the range of interesting fd's during the test) set up to
     duplicate the original stderr.  */
  
  #define BACKUP_STDERR_FILENO 10
  static FILE *myerr;
  
  #define ASSERT(expr) \
    do                                                                         \
      {                                                                        \
        if (!(expr))                                                           \
  	{                                                                    \
  	  fprintf (myerr, "%s:%d: assertion failed\n", __FILE__, __LINE__);  \
  	  fflush (myerr);                                                    \
  	  abort ();                                                          \
  	}                                                                    \
      }                                                                        \
    while (0)
  
  #define witness "test-openat-safer.txt"
  
  int
  main (void)
  {
    int i;
    int j;
    int dfd;
    int fd;
    char buf[2];
  
    /* We close fd 2 later, so save it in fd 10.  */
    if (dup2 (STDERR_FILENO, BACKUP_STDERR_FILENO) != BACKUP_STDERR_FILENO
        || (myerr = fdopen (BACKUP_STDERR_FILENO, "w")) == NULL)
      return 2;
  
    /* Create handle for future use.  */
    dfd = openat (AT_FDCWD, ".", O_RDONLY);
    ASSERT (STDERR_FILENO < dfd);
  
    /* Create file for later checks.  */
    remove (witness);
    fd = openat (dfd, witness, O_WRONLY | O_CREAT | O_EXCL, 0600);
    ASSERT (STDERR_FILENO < fd);
    ASSERT (write (fd, "hi", 2) == 2);
    ASSERT (close (fd) == 0);
  
    /* Four iterations, with progressively more standard descriptors
       closed.  */
    for (i = -1; i <= STDERR_FILENO; i++)
      {
        ASSERT (fchdir (dfd) == 0);
        if (0 <= i)
  	ASSERT (close (i) == 0);
  
        /* Execute once in ".", once in "..".  */
        for (j = 0; j <= 1; j++)
  	{
  	  if (j)
  	    ASSERT (chdir ("..") == 0);
  
  	  /* Check for error detection.  */
  	  errno = 0;
  	  ASSERT (openat (AT_FDCWD, "", O_RDONLY) == -1);
  	  ASSERT (errno == ENOENT);
  	  errno = 0;
  	  ASSERT (openat (dfd, "", O_RDONLY) == -1);
  	  ASSERT (errno == ENOENT);
  	  errno = 0;
  	  ASSERT (openat (-1, ".", O_RDONLY) == -1);
  	  ASSERT (errno == EBADF);
  
  	  /* Check for trailing slash and /dev/null handling.  */
  	  errno = 0;
  	  ASSERT (openat (dfd, "nonexist.ent/", O_CREAT | O_RDONLY,
  			  S_IRUSR | S_IWUSR) == -1);
  	  ASSERT (errno == ENOTDIR || errno == EISDIR || errno == ENOENT
  		  || errno == EINVAL);
  	  errno = 0;
  	  ASSERT (openat (dfd, witness "/", O_RDONLY) == -1);
  	  ASSERT (errno == ENOTDIR || errno == EISDIR || errno == EINVAL);
  	  /* Using a bad directory is okay for absolute paths.  */
  	  fd = openat (-1, "/dev/null", O_WRONLY);
  	  ASSERT (STDERR_FILENO < fd);
  	  /* Using a non-directory is wrong for relative paths.  */
  	  errno = 0;
  	  ASSERT (openat (fd, ".", O_RDONLY) == -1);
  	  ASSERT (errno == EBADF || errno == ENOTDIR);
  	  ASSERT (close (fd) == 0);
  
  	  /* Check for our witness file.  */
  	  fd = openat (dfd, witness, O_RDONLY | O_NOFOLLOW);
  	  ASSERT (STDERR_FILENO < fd);
  	  ASSERT (read (fd, buf, 2) == 2);
  	  ASSERT (buf[0] == 'h' && buf[1] == 'i');
  	  ASSERT (close (fd) == 0);
  	}
      }
    ASSERT (fchdir (dfd) == 0);
    ASSERT (unlink (witness) == 0);
    ASSERT (close (dfd) == 0);
  
    return 0;
  }
  

Download