Hash :
24208770
Author :
Date :
2009-11-09T10:44:08
unlink, remove: detect FreeBSD bug
unlink("link-to-file/") mistakenly removed "file".
* m4/unlink.m4 (gl_FUNC_UNLINK): Also detect FreeBSD bug with
slash on symlink.
* doc/posix-functions/unlink.texi (unlink): Document the bug.
* doc/posix-functions/remove.texi (remove): Likewise.
* tests/test-unlink.h (test_unlink): Enhance test.
* tests/test-remove.c (main): Likewise.
Signed-off-by: Eric Blake <ebb9@byu.net>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131
/* Tests of remove.
Copyright (C) 2009 Free Software Foundation, Inc.
This program is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 3 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>. */
/* Written by Eric Blake <ebb9@byu.net>, 2009. */
#include <config.h>
#include <stdio.h>
#include <fcntl.h>
#include <errno.h>
#include <stdlib.h>
#include <string.h>
#include <sys/stat.h>
#include <unistd.h>
#define ASSERT(expr) \
do \
{ \
if (!(expr)) \
{ \
fprintf (stderr, "%s:%d: assertion failed\n", __FILE__, __LINE__); \
fflush (stderr); \
abort (); \
} \
} \
while (0)
#define BASE "test-remove.t"
int
main (void)
{
/* Remove any leftovers from a previous partial run. */
ASSERT (system ("rm -rf " BASE "*") == 0);
/* Setup. */
ASSERT (mkdir (BASE "dir", 0700) == 0);
ASSERT (close (creat (BASE "dir/file", 0600)) == 0);
/* Basic error conditions. */
errno = 0;
ASSERT (remove ("") == -1);
ASSERT (errno == ENOENT);
errno = 0;
ASSERT (remove ("nosuch") == -1);
ASSERT (errno == ENOENT);
errno = 0;
ASSERT (remove ("nosuch/") == -1);
ASSERT (errno == ENOENT);
errno = 0;
ASSERT (remove (".") == -1);
ASSERT (errno == EINVAL || errno == EBUSY);
/* Resulting errno after ".." or "/" is too varied to test; it is
reasonable to see any of EINVAL, EEXIST, ENOTEMPTY, EACCES. */
ASSERT (remove ("..") == -1);
ASSERT (remove ("/") == -1);
ASSERT (remove ("///") == -1);
errno = 0;
ASSERT (remove (BASE "dir/file/") == -1);
ASSERT (errno == ENOTDIR);
/* Non-empty directory. */
errno = 0;
ASSERT (remove (BASE "dir") == -1);
ASSERT (errno == EEXIST || errno == ENOTEMPTY);
/* Non-directory. */
ASSERT (remove (BASE "dir/file") == 0);
/* Empty directory. */
errno = 0;
ASSERT (remove (BASE "dir/.//") == -1);
ASSERT (errno == EINVAL || errno == EBUSY);
ASSERT (remove (BASE "dir") == 0);
/* Test symlink behavior. Specifying trailing slash should remove
referent directory, or cause ENOTDIR failure, but not touch
symlink. */
if (symlink (BASE "dir", BASE "link") != 0)
{
fputs ("skipping test: symlinks not supported on this file system\n",
stderr);
return 77;
}
ASSERT (mkdir (BASE "dir", 0700) == 0);
errno = 0;
if (remove (BASE "link/") == 0)
{
struct stat st;
errno = 0;
ASSERT (stat (BASE "link", &st) == -1);
ASSERT (errno == ENOENT);
}
else
ASSERT (remove (BASE "dir") == 0);
{
struct stat st;
ASSERT (lstat (BASE "link", &st) == 0);
ASSERT (S_ISLNK (st.st_mode));
}
ASSERT (remove (BASE "link") == 0);
/* Trailing slash on symlink to non-directory is an error. */
ASSERT (symlink (BASE "loop", BASE "loop") == 0);
errno = 0;
ASSERT (remove (BASE "loop/") == -1);
ASSERT (errno == ELOOP || errno == ENOTDIR);
ASSERT (remove (BASE "loop") == 0);
ASSERT (close (creat (BASE "file", 0600)) == 0);
ASSERT (symlink (BASE "file", BASE "link") == 0);
errno = 0;
ASSERT (remove (BASE "link/") == -1);
ASSERT (errno == ENOTDIR);
ASSERT (remove (BASE "link") == 0);
ASSERT (remove (BASE "file") == 0);
return 0;
}