kc3-lang/gnulib/lib/strerror.c

• Show log

  Commit

• Hash : 79d4e75d
  Author :
  Date : 2011-06-07T20:49:04
  

  strerror_r-posix: fix on MacOS
  
  MacOS X 10.5 strerror(0) is "Unknown error: 0", which is not distinguished
  from "Unknown error: -1" for out-of-range.  Worse, strerror_r(0,,)
  is "Undefined error: 0", although strerror_r for all other out-of-range
  values matches strerror.
  
  * m4/strerror.m4 (gl_FUNC_STRERROR): Flush out MacOS bug.
  * m4/strerror_r.m4 (gl_FUNC_STRERROR_R_WORKS): Likewise, and fix
  logic bug.
  * lib/strerror_r.c (strerror_r): Fix the bug.
  * lib/strerror.c (strerror): Likewise.
  * doc/posix-functions/strerror_r.texi (strerror_r): Document the
  problem.
  * doc/posix-functions/strerror.texi (strerror): Likewise.
  * doc/posix-functions/perror.texi (perror): Likewise.
  * tests/test-strerror.c (main): Enhance test.
  * tests/test-strerror_r.c (main): Likewise.
  
  Signed-off-by: Eric Blake <eblake@redhat.com>
  

Download

• lib/strerror.c

• /* strerror.c --- POSIX compatible system error routine
  
     Copyright (C) 2007-2011 Free Software Foundation, Inc.
  
     This program is free software: you can redistribute it and/or modify
     it under the terms of the GNU General Public License as published by
     the Free Software Foundation; either version 3 of the License, or
     (at your option) any later version.
  
     This program is distributed in the hope that it will be useful,
     but WITHOUT ANY WARRANTY; without even the implied warranty of
     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
     GNU General Public License for more details.
  
     You should have received a copy of the GNU General Public License
     along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
  
  #include <config.h>
  
  /* Specification.  */
  #include <string.h>
  
  #include <errno.h>
  #include <stdio.h>
  #include <stdlib.h>
  #include <string.h>
  
  #include "intprops.h"
  #include "strerror-override.h"
  #include "verify.h"
  
  /* Use the system functions, not the gnulib overrides in this file.  */
  #undef sprintf
  
  char *
  strerror (int n)
  #undef strerror
  {
    static char buf[STACKBUF_LEN];
    size_t len;
  
    /* Cast away const, due to the historical signature of strerror;
       callers should not be modifying the string.  */
    const char *msg = strerror_override (n);
    if (msg)
      return (char *) msg;
  
    /* FreeBSD rejects 0; see http://austingroupbugs.net/view.php?id=382.
       MacOS X 10.5 does not distinguish 0 from -1.  */
    if (n)
      msg = strerror (n);
    else
      {
        int saved_errno = errno;
        errno = 0;
        msg = strerror (n);
        if (errno || (msg &&
                      (strstr (msg, "nknown") || strstr (msg, "ndefined"))))
          msg = "Success";
        errno = saved_errno;
      }
  
    /* Our strerror_r implementation might use the system's strerror
       buffer, so all other clients of strerror have to see the error
       copied into a buffer that we manage.  This is not thread-safe,
       even if the system strerror is, but portable programs shouldn't
       be using strerror if they care about thread-safety.  */
    if (!msg || !*msg)
      {
        static char const fmt[] = "Unknown error %d";
        verify (sizeof buf >= sizeof (fmt) + INT_STRLEN_BOUND (n));
        sprintf (buf, fmt, n);
        errno = EINVAL;
        return buf;
      }
  
    /* Fix STACKBUF_LEN if this ever aborts.  */
    len = strlen (msg);
    if (sizeof buf <= len)
      abort ();
  
    return memcpy (buf, msg, len + 1);
  }
  

Download