Branch
Hash :
9ea3eece
Author :
Date :
2025-05-16T16:37:03
asyncsafe-spin: Fix race condition on native Windows. * lib/asyncsafe-spin.h (asyncsafe_spin_lock, asyncsafe_spin_unlock): Add from_signal_handler parameter. * lib/asyncsafe-spin.c (asyncsafe_spin_lock, asyncsafe_spin_unlock): Likewise. * modules/asyncsafe-spin (Depends-on): Add bool. * tests/test-asyncsafe-spin1.c (main): Update. * tests/test-asyncsafe-spin2.c (lock_mutator_thread, lock_checker_thread): Update. * lib/clean-temp-simple.c (clean_temp_asyncsafe_close): Update. * lib/clean-temp.c (asyncsafe_fclose_variant): Update.
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67
/* Spin locks for communication between threads and signal handlers.
Copyright (C) 2020-2025 Free Software Foundation, Inc.
This file is free software: you can redistribute it and/or modify
it under the terms of the GNU Lesser General Public License as
published by the Free Software Foundation; either version 2.1 of the
License, or (at your option) any later version.
This file is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU Lesser General Public License for more details.
You should have received a copy of the GNU Lesser General Public License
along with this program. If not, see <https://www.gnu.org/licenses/>. */
/* Written by Bruno Haible <bruno@clisp.org>, 2020. */
#ifndef _ASYNCSAFE_SPIN_H
#define _ASYNCSAFE_SPIN_H
/* Usual spin locks are not allowed for communication between threads and signal
handlers, because the pthread_spin_* functions are not async-safe; see
<https://pubs.opengroup.org/onlinepubs/9699919799/functions/V2_chap02.html>
section 2.4.3 Signal Actions.
This module provides spin locks with a similar API. It can be used like this,
both in regular multithreaded code and in signal handlers:
sigset_t saved_mask;
asyncsafe_spin_lock (&lock, from_signal_handler, &mask, &saved_mask);
do_something_contentious ();
asyncsafe_spin_unlock (&lock, from_signal_handler, &saved_mask);
The mask you specify here is the set of signals whose handlers might want to
take the same lock.
asyncsafe_spin_lock/unlock use pthread_sigmask, to ensure that while a thread
is executing such code, no signal handler will start such code for the same
lock *in the same thread* (because if this happened, the signal handler would
hang!). */
#include <signal.h>
#include "glthread/spin.h"
typedef gl_spinlock_t asyncsafe_spinlock_t;
#define ASYNCSAFE_SPIN_INIT gl_spinlock_initializer
#ifdef __cplusplus
extern "C" {
#endif
extern void asyncsafe_spin_init (asyncsafe_spinlock_t *lock);
extern void asyncsafe_spin_lock (asyncsafe_spinlock_t *lock,
bool from_signal_handler,
const sigset_t *mask, sigset_t *saved_mask);
extern void asyncsafe_spin_unlock (asyncsafe_spinlock_t *lock,
bool from_signal_handler,
const sigset_t *saved_mask);
extern void asyncsafe_spin_destroy (asyncsafe_spinlock_t *lock);
#ifdef __cplusplus
}
#endif
#endif /* _ASYNCSAFE_SPIN_H */