Branch
Hash :
9ea3eece
Author :
Date :
2025-05-16T16:37:03
asyncsafe-spin: Fix race condition on native Windows. * lib/asyncsafe-spin.h (asyncsafe_spin_lock, asyncsafe_spin_unlock): Add from_signal_handler parameter. * lib/asyncsafe-spin.c (asyncsafe_spin_lock, asyncsafe_spin_unlock): Likewise. * modules/asyncsafe-spin (Depends-on): Add bool. * tests/test-asyncsafe-spin1.c (main): Update. * tests/test-asyncsafe-spin2.c (lock_mutator_thread, lock_checker_thread): Update. * lib/clean-temp-simple.c (clean_temp_asyncsafe_close): Update. * lib/clean-temp.c (asyncsafe_fclose_variant): Update.
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246
/* Test of spin locks for communication between threads and signal handlers.
Copyright (C) 2005, 2008-2025 Free Software Foundation, Inc.
This program is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation, either version 3 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program. If not, see <https://www.gnu.org/licenses/>. */
/* Written by Bruno Haible <bruno@clisp.org>, 2005. */
#include <config.h>
#if USE_ISOC_THREADS || USE_POSIX_THREADS || USE_ISOC_AND_POSIX_THREADS || USE_WINDOWS_THREADS
/* Whether to enable locking.
Uncomment this to get a test program without locking, to verify that
it crashes. */
#define ENABLE_LOCKING 1
/* Whether to help the scheduler through explicit yield().
Uncomment this to see if the operating system has a fair scheduler. */
#define EXPLICIT_YIELD 1
/* Whether to print debugging messages. */
#define ENABLE_DEBUGGING 0
/* Number of simultaneous threads. */
#define THREAD_COUNT 10
/* Number of operations performed in each thread. */
#if !(defined _WIN32 && ! defined __CYGWIN__) && HAVE_PTHREAD_H && (__GNUC__ > 4 || (__GNUC__ == 4 && __GNUC_MINOR__ >= 1) || __clang_major__ >= 3) && !defined __ibmxl__
/* The GCC built-ins are known to work fine. */
# define REPEAT_COUNT 5000
#else
/* This is quite high, because with a smaller count, say 50000, we often get
an "OK" result even with the racy implementation that we pick on Fedora 13
Linux/x86_64 (gcc 4.4). */
# define REPEAT_COUNT 100000
#endif
#include <signal.h>
#include <stdint.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include "asyncsafe-spin.h"
#if !ENABLE_LOCKING
# define asyncsafe_spin_init(lock) (void)(lock)
# define asyncsafe_spin_lock(lock, from, mask, saved_mask) \
((void)(lock), (void)(from), (void)(mask), (void)(saved_mask))
# define asyncsafe_spin_unlock(lock, from, saved_mask) \
((void)(lock), (void)(from), (void)(saved_mask))
# define asyncsafe_spin_destroy(lock) (void)(lock)
#endif
#include "glthread/lock.h"
#include "glthread/thread.h"
#include "glthread/yield.h"
#if HAVE_DECL_ALARM
# include <signal.h>
# include <unistd.h>
#endif
#include "atomic-int-gnulib.h"
#if ENABLE_DEBUGGING
# define dbgprintf printf
#else
# define dbgprintf if (0) printf
#endif
#if EXPLICIT_YIELD
# define yield() gl_thread_yield ()
#else
# define yield()
#endif
static sigset_t signals_to_block;
#define ACCOUNT_COUNT 4
static int account[ACCOUNT_COUNT];
static int
random_account (void)
{
return ((unsigned long) random () >> 3) % ACCOUNT_COUNT;
}
static void
check_accounts (void)
{
int i, sum;
sum = 0;
for (i = 0; i < ACCOUNT_COUNT; i++)
sum += account[i];
if (sum != ACCOUNT_COUNT * 1000)
abort ();
}
/* ------------------- Test use like normal locks ------------------- */
/* Test normal locks by having several bank accounts and several threads
which shuffle around money between the accounts and another thread
checking that all the money is still there. */
static asyncsafe_spinlock_t my_lock;
static void *
lock_mutator_thread (void *arg)
{
int repeat;
for (repeat = REPEAT_COUNT; repeat > 0; repeat--)
{
sigset_t saved_signals;
int i1, i2, value;
dbgprintf ("Mutator %p before lock\n", gl_thread_self_pointer ());
asyncsafe_spin_lock (&my_lock, false, &signals_to_block, &saved_signals);
dbgprintf ("Mutator %p after lock\n", gl_thread_self_pointer ());
i1 = random_account ();
i2 = random_account ();
value = ((unsigned long) random () >> 3) % 10;
account[i1] += value;
account[i2] -= value;
dbgprintf ("Mutator %p before unlock\n", gl_thread_self_pointer ());
asyncsafe_spin_unlock (&my_lock, false, &saved_signals);
dbgprintf ("Mutator %p after unlock\n", gl_thread_self_pointer ());
dbgprintf ("Mutator %p before check lock\n", gl_thread_self_pointer ());
asyncsafe_spin_lock (&my_lock, false, &signals_to_block, &saved_signals);
check_accounts ();
asyncsafe_spin_unlock (&my_lock, false, &saved_signals);
dbgprintf ("Mutator %p after check unlock\n", gl_thread_self_pointer ());
yield ();
}
dbgprintf ("Mutator %p dying.\n", gl_thread_self_pointer ());
return NULL;
}
static struct atomic_int lock_checker_done;
static void *
lock_checker_thread (void *arg)
{
while (get_atomic_int_value (&lock_checker_done) == 0)
{
sigset_t saved_signals;
dbgprintf ("Checker %p before check lock\n", gl_thread_self_pointer ());
asyncsafe_spin_lock (&my_lock, false, &signals_to_block, &saved_signals);
check_accounts ();
asyncsafe_spin_unlock (&my_lock, false, &saved_signals);
dbgprintf ("Checker %p after check unlock\n", gl_thread_self_pointer ());
yield ();
}
dbgprintf ("Checker %p dying.\n", gl_thread_self_pointer ());
return NULL;
}
static void
test_asyncsafe_spin (void)
{
int i;
gl_thread_t checkerthread;
gl_thread_t threads[THREAD_COUNT];
/* Initialization. */
for (i = 0; i < ACCOUNT_COUNT; i++)
account[i] = 1000;
init_atomic_int (&lock_checker_done);
set_atomic_int_value (&lock_checker_done, 0);
/* Spawn the threads. */
checkerthread = gl_thread_create (lock_checker_thread, NULL);
for (i = 0; i < THREAD_COUNT; i++)
threads[i] = gl_thread_create (lock_mutator_thread, NULL);
/* Wait for the threads to terminate. */
for (i = 0; i < THREAD_COUNT; i++)
gl_thread_join (threads[i], NULL);
set_atomic_int_value (&lock_checker_done, 1);
gl_thread_join (checkerthread, NULL);
check_accounts ();
}
/* -------------------------------------------------------------------------- */
int
main ()
{
#if HAVE_DECL_ALARM
/* Declare failure if test takes too long, by using default abort
caused by SIGALRM. */
int alarm_value = 600;
signal (SIGALRM, SIG_DFL);
alarm (alarm_value);
#endif
sigemptyset (&signals_to_block);
sigaddset (&signals_to_block, SIGINT);
asyncsafe_spin_init (&my_lock);
printf ("Starting test_asyncsafe_spin ..."); fflush (stdout);
test_asyncsafe_spin ();
printf (" OK\n"); fflush (stdout);
return 0;
}
#else
/* No multithreading available. */
#include <stdio.h>
int
main ()
{
fputs ("Skipping test: multithreading not enabled\n", stderr);
return 77;
}
#endif