Branch
Hash :
2b426863
Author :
Date :
2025-07-17T11:33:39
Fix sb_dupfree(), sbr_dupfree() on an empty buffer. Reported by Marc Nieper-Wißkirchen <marc.nieper+gnu@gmail.com> at <https://lists.gnu.org/archive/html/bug-gnulib/2025-07/msg00119.html>. * lib/string-desc.c (_sd_new_addr, _rwsd_new_addr): Don't canonicalize (0, non-NULL) to (0, NULL). * lib/string-buffer.h (sb_dupfree): Fix description. * lib/string-buffer-reversed.h (sbr_dupfree): Likewise. * tests/test-string-buffer.c (main): Test sb_dupfree on an empty buffer. * tests/test-string-buffer-reversed.c (main): Test sbr_dupfree on an empty buffer.
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193
/* Test of buffer that accumulates a string by piecewise concatenation.
Copyright (C) 2021-2025 Free Software Foundation, Inc.
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 2, or (at your option)
any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program; if not, see <https://www.gnu.org/licenses/>. */
/* Written by Bruno Haible <bruno@clisp.org>, 2021. */
#include <config.h>
#include "string-buffer-reversed.h"
#include <errno.h>
#include <string.h>
#include <wchar.h>
#include "macros.h"
static int
my_prependf (struct string_buffer_reversed *buffer, const char *formatstring,
...)
{
va_list args;
va_start (args, formatstring);
int ret = sbr_prependvf (buffer, formatstring, args);
va_end (args);
return ret;
}
char invalid_format_string_1[] = "%&";
char invalid_format_string_2[] = "%^";
int
main ()
{
/* Test accumulation. */
{
struct string_buffer_reversed buffer;
sbr_init (&buffer);
rw_string_desc_t contents = sbr_dupfree (&buffer);
ASSERT (sd_is_empty (contents));
/* Here it is important to distinguish (0, NULL), which stands for an error,
from (0, non-NULL), which is a successful result. */
ASSERT (sd_data (contents) != NULL);
sd_free (contents);
}
{
struct string_buffer_reversed buffer;
sbr_init (&buffer);
sbr_prepend1 (&buffer, '\377');
sbr_prepend1 (&buffer, 'x');
char *s = sbr_dupfree_c (&buffer);
ASSERT (s != NULL && strcmp (s, "x\377") == 0);
free (s);
}
{
struct string_buffer_reversed buffer;
sbr_init (&buffer);
sbr_prepend1 (&buffer, '\377');
sbr_prepend1 (&buffer, 'x');
{
string_desc_t sd = sbr_contents (&buffer);
ASSERT (sd_length (sd) == 2);
ASSERT (sd_char_at (sd, 0) == 'x');
ASSERT (sd_char_at (sd, 1) == '\377');
}
sbr_prepend1 (&buffer, '\0');
sbr_prepend1 (&buffer, 'z');
{
string_desc_t sd = sbr_contents (&buffer);
ASSERT (sd_length (sd) == 4);
ASSERT (sd_char_at (sd, 0) == 'z');
ASSERT (sd_char_at (sd, 1) == '\0');
ASSERT (sd_char_at (sd, 2) == 'x');
ASSERT (sd_char_at (sd, 3) == '\377');
}
char *s = sbr_dupfree_c (&buffer);
ASSERT (s != NULL && memcmp (s, "z\0x\377\0", 5) == 0);
free (s);
}
/* Test simple string concatenation. */
{
struct string_buffer_reversed buffer;
sbr_init (&buffer);
char *s = sbr_dupfree_c (&buffer);
ASSERT (s != NULL && strcmp (s, "") == 0);
free (s);
}
{
struct string_buffer_reversed buffer;
sbr_init (&buffer);
sbr_prepend_c (&buffer, "efg");
sbr_prepend_c (&buffer, "");
sbr_prepend_c (&buffer, "abcd");
char *s = sbr_dupfree_c (&buffer);
ASSERT (s != NULL && strcmp (s, "abcdefg") == 0);
free (s);
}
{
struct string_buffer_reversed buffer;
sbr_init (&buffer);
sbr_prepend_c (&buffer, "hij");
sbr_prepend_desc (&buffer, sd_new_addr (5, "de\0fg"));
sbr_prepend_c (&buffer, "abc");
char *s = sbr_dupfree_c (&buffer);
ASSERT (s != NULL && memcmp (s, "abcde\0fghij", 12) == 0);
free (s);
}
/* Test printf-like formatting. */
{
struct string_buffer_reversed buffer;
sbr_init (&buffer);
sbr_prepend_c (&buffer, ">");
sbr_prependf (&buffer, "%x", 3735928559U);
sbr_prepend_c (&buffer, "<");
char *s = sbr_dupfree_c (&buffer);
ASSERT (s != NULL && strcmp (s, "<deadbeef>") == 0);
free (s);
}
/* Test vprintf-like formatting. */
{
struct string_buffer_reversed buffer;
sbr_init (&buffer);
sbr_prepend_c (&buffer, ">");
my_prependf (&buffer, "%x", 3735928559U);
sbr_prepend_c (&buffer, "<");
char *s = sbr_dupfree_c (&buffer);
ASSERT (s != NULL && strcmp (s, "<deadbeef>") == 0);
free (s);
}
/* Test printf-like formatting failure.
On all systems except AIX, trying to convert the wide-character 0x76543210
to a multibyte string (in the "C" locale) fails.
On all systems, invalid format directives make the vsnzprintf() call
fail. */
{
struct string_buffer_reversed buffer;
int ret;
sbr_init (&buffer);
sbr_prepend_c (&buffer, ">");
ret = sbr_prependf (&buffer, "%lc", (wint_t) 0x76543210);
#if !(defined _AIX || (defined _WIN32 && !defined __CYGWIN__))
ASSERT (ret < 0);
ASSERT (errno == EILSEQ);
#endif
sbr_prepend_c (&buffer, "|");
ret = sbr_prependf (&buffer, invalid_format_string_1, 1);
ASSERT (ret < 0);
ASSERT (errno == EINVAL);
sbr_prepend_c (&buffer, "|");
ret = sbr_prependf (&buffer, invalid_format_string_2, 2);
ASSERT (ret < 0);
ASSERT (errno == EINVAL);
sbr_prepend_c (&buffer, "<");
char *s = sbr_dupfree_c (&buffer);
ASSERT (s == NULL);
}
return test_exit_status;
}