Log

Author Commit Date CI Message
Ebrahim Byagowi 35ce8f31 2018-06-25T22:23:43 Unify our pipe reader with the fallback reader (#1068) And assign one bot to use the path always using NOMMAPFILEREADER token. It's limited to 200mb so no more fun with using /dev/zero on hb-view!
Ebrahim Byagowi f57804a8 2018-06-25T18:45:49 Resolve ttx absolute path before use (#1075)
Ebrahim Byagowi 159ddb87 2018-06-24T23:09:16 Treat - just as /dev/stdin and remove one extra file reader (#1065)
Behdad Esfahbod b2a18791 2018-06-23T10:32:28 In Coverage iterator, bail out if table smells In particular, if CoverageFormat2 has unsorted ranges, bail out. Otherwise, 64k ranges of each 64k glyphs can DoS closure() method. We can do the same for CoverageFormat1, but that one does not expose the quadratic behavior, so, fine.
Ebrahim Byagowi 941f2b85 2018-06-18T20:35:40 Support pipe and friends on hb_blob_create_from_file (#1061) With this hb-view/hb-shape support pipes and possibly socket and named pipe also, anything fails just on mmap. We can later do the same for Windows also. This however reveals two issues, the fact most of our bots don't have HAVE_MMAP and using this instead the other fread/fopen reader can make failure on CI. I should look at them separately this change however is very low risk I believe.
Ebrahim Byagowi d0c2889d 2018-06-18T19:59:33 Revert file blob sanitization and index checking (#1062) As https://github.com/harfbuzz/harfbuzz/pull/1059#issuecomment-397912812 we like to still work with blobs that harfbuzz itself can't handle directly that are failing sanitization currently apparently.
Ebrahim Byagowi c53697d3 2018-06-17T17:04:55 Verbose fail when something is wrong with hb-shape/hb-view input font file (#1059) This checks if the blob isn't empty and uses `hb_face_count` to see if the font file passes the simple font file sanitization so can detect if the input is actually a font and checks also whether input font-index is out of range.
Ebrahim Byagowi aa0c5df4 2018-06-17T16:49:34 Fix reading fonts from stdin (#1060) We were passing the font path directly to freetype so rendering was broken when we are getting the font from stdin. This fixes it by using FT_New_Memory_Face instead. This fixes: * build/util/hb-view /dev/stdin text < font.ttf * build/util/hb-view - text < font.ttf * cat font.ttf | build/util/hb-view - text but doesn't work on * cat font.ttf | build/util/hb-view /dev/stdin text which I will try to fix separately.
Behdad Esfahbod 3654d9be 2018-06-12T19:38:04 1.8.1
Behdad Esfahbod f3e58ab8 2018-06-12T19:32:04 [docs] Enlist misc new symbols
Behdad Esfahbod f6893ef8 2018-06-12T19:20:20 Move hb-version.h generation to Makefile Fixes https://github.com/harfbuzz/harfbuzz/issues/864 Unfortunately 1.7.7 and 1.8.0 went out with the wrong hb-version.h contents.
Behdad Esfahbod cc0b04f4 2018-06-12T18:24:54 [subset] Remove HB_SUBSET_BUILTIN Just include hb-static.cc in libharfbuzz-subset.so source list as well. Those building it built-in will include hb-static.cc once already. No need for any gymnastics.
Behdad Esfahbod a7e1b4a3 2018-06-11T22:05:08 Fix compiler warning re reordering of initializations
Behdad Esfahbod f56cd9df 2018-06-11T22:02:38 Style
Behdad Esfahbod ba0ea56e 2018-06-11T23:24:41 [substitute-closure] Rename function for clarity
Behdad Esfahbod 7b5ce416 2018-06-11T23:23:40 Whitespace
Behdad Esfahbod c4d0d11c 2018-06-11T22:11:45 [vector] Always 0-fill new items
Jonathan Kew a95cde15 2018-06-11T18:09:35 [hb-set] Additional testcase for hb-set-intersect.
Jonathan Kew 82484b05 2018-06-11T20:55:14 [hb-set] Don't shrink vectors until after processing their contents. Fixes #1054.
Ebrahim Byagowi eb585033 2018-06-11T03:47:43 Fetch the updated dwrite_1.h header from a better place Following to https://ci.appveyor.com/project/harfbuzz/harfbuzz/build/1.0.1693/job/mfkjdhcdykjuqdfc
Behdad Esfahbod b8e406f0 2018-06-10T17:22:38 More fixes for SunStudio 12.6 build Followup to https://github.com/harfbuzz/harfbuzz/pull/1053
prrace 498e4373 2018-06-09T16:04:28 Fix SunStudio 12.6 build (#1053)
Garret Rieger 46f7e776 2018-06-07T15:55:45 [subset] Use REPLACEME instead of version.
Garret Rieger fc246ec9 2018-06-07T15:54:19 [subset] Move variable declaration out of loop.
Garret Rieger 197cb18b 2018-06-07T15:32:52 [subset] Add test cases for gsub closure in subsetting.
Garret Rieger 37eab27b 2018-06-07T14:39:03 [subset] Add fuzzing of gsub closure to hb-subset-fuzzer.
Garret Rieger feb23892 2018-06-07T14:32:34 [subset] Use gsub closure if ot layout is not being dropped.
Garret Rieger a5673da9 2018-06-07T14:23:03 [subset] Add drop_ot_layout setting to subset input.
Garret Rieger 57badadb 2018-06-06T16:02:51 [subset] add a new closure call to hb-ot-layout that can compute the closure over multiple lookups.
Behdad Esfahbod 11f1f413 2018-06-06T16:46:50 [set] Add is_subset New API: +hb_set_is_subset()
Garret Rieger 45186b9b 2018-06-05T17:14:42 [subset] Add memoization of GSUB lookup closures.
Behdad Esfahbod 78d92e0f 2018-06-06T15:24:43 Minorish
Behdad Esfahbod 676b19f0 2018-06-06T15:23:35 Compiler gymnastics Part of https://github.com/harfbuzz/harfbuzz/issues/630
Behdad Esfahbod 0a5952e8 2018-06-06T14:55:30 Move prime_for back into map This was causing problem on systems without visibility when map was used from both libharfbuzz and libharfbuzz-subset. Sigh. https://ci.appveyor.com/project/harfbuzz/harfbuzz/build/1.0.1669/job/dey47nmff0770vp3
David Corbett a2a1484e 2018-06-06T12:57:28 Convert Consonant_Initial_Postfixed to CONS_FINAL Consonant_Initial_Postfixed was split off of Consonant_Succeeding_Repha, so it should correspond to the same USE class, CONS_FINAL.
Behdad Esfahbod 37986aa9 2018-06-05T18:04:40 1.8.0
Behdad Esfahbod 9d3cd13c 2018-06-05T17:59:31 [ucdn] Update to Unicode 11 https://github.com/grigorig/ucdn/issues/19
Behdad Esfahbod 060e6b4a 2018-06-05T17:31:46 Update to Unicode 11.0.0 UCDN is not updated yet.
Behdad Esfahbod 105a3b5e 2018-06-05T15:31:04 Minor
Behdad Esfahbod 60c51678 2018-06-05T15:20:23 [RELEASING] Update
Behdad Esfahbod df01f3e5 2018-06-05T15:17:39 1.7.7
Behdad Esfahbod ba3b6d6c 2018-06-04T16:47:45 [khmer] Fix Coeng vs Halant confusion Test suite results are unchanged (34).
Ebrahim Byagowi 8220ef8a 2018-06-05T22:50:53 Fix hb_face_count build issue I should've rebased #1002 before the merge, my bad
Ebrahim Byagowi 32da0c6b 2018-06-05T18:56:26 Add hb_face_count, a new API (#1002) Simply, it returns the number of faces on a font blob. To be used on hb-sanitizer tool but other clients also can benefit from it.
Behdad Esfahbod 4a115fe7 2018-06-04T15:40:43 [sinhala] Move reph to after post-consonants Apparently this changed between Win 7 and Win 10. Fixes https://github.com/harfbuzz/harfbuzz/issues/967 To be continued in https://github.com/harfbuzz/harfbuzz/issues/1044
Behdad Esfahbod 3e494caa 2018-06-04T15:38:05 [test] Fix record-test to use gids not glyph-names as those might not match what FontTools think of the glyphs if font does NOT have glyph names.
Behdad Esfahbod 58400a2a 2018-06-02T20:30:09 Remove DISALLOW_* from vector, set, and map Some of the build bots, still fail on this. I suppose mine pass because I enable C++11... Anyway, remove these again.
Behdad Esfahbod f9abbf83 2018-06-02T15:30:59 Fix fallout from 975bdd5ef562e37655067b703b2b9ca7481f4985 Ouch!
Behdad Esfahbod f7515769 2018-06-01T17:48:37 [vector] Use Crap pool in push() as well
Behdad Esfahbod 975bdd5e 2018-06-01T17:37:13 [vector] Keep success status
Behdad Esfahbod 1ab3c3ed 2018-06-01T17:34:24 [vector] Whitespace
Behdad Esfahbod fb07d1a3 2018-06-01T17:32:07 Another attempt at making every compiler happy... Sigh.
Behdad Esfahbod 4f76f956 2018-06-01T17:28:47 [map] Move prime_for to hb-static
Behdad Esfahbod 33d6f46b 2018-06-01T17:25:35 [set] Shrink page-map size again
Behdad Esfahbod 4ca211bc 2018-06-01T17:18:57 Fix hb_vector_size_t
Garret Rieger a070dfd3 2018-05-31T16:47:39 [subset] Have the subset fuzzer pull the text string to subset to from the end of the fuzzer provided data.
Behdad Esfahbod bb6f4ada 2018-06-01T16:30:38 Add Codacy badge
Behdad Esfahbod a7dd90f5 2018-06-01T16:07:55 Revert "Remove HB_DISALLOW_COPY_AND_ASSIGN" This reverts commit ff92de766bf775bfdd3a01bda94de699180ff86a. Revert that and remove ASSERT_POD. Let's see which bots are unhappy with this configuration...
Behdad Esfahbod 7b50bf52 2018-05-31T20:20:17 Use NullPool for _hb_set_nil and _hb_map_nil
Behdad Esfahbod f040ca40 2018-05-31T20:15:21 [set] Minor
Behdad Esfahbod 7185b273 2018-05-31T20:03:00 Rename in_error to !successful Towards possibly using Null pool for some nil objects.
Behdad Esfahbod 353f4d2e 2018-05-31T19:52:16 Fix a whitespace inconsistency Null() and Crap() are only places that there's no space before '('...
Behdad Esfahbod e36cd1df 2018-05-31T19:31:39 Remove trivial HB_ATOMIC_INT_INIT()
Behdad Esfahbod 550a70f8 2018-05-31T19:28:04 Use 0 as inert object reference value instead of -1 Towards using Null object for nil objects.
Behdad Esfahbod dcd1b07e 2018-05-31T17:58:40 Add const OffsetTo<> dereference Unused, but now that we have CrapPool, implement it.
Ebrahim Byagowi 2baa357a 2018-05-31T12:27:31 Fix symbol export issue of prime_mod on Alpine bot Apparently our gcc-6.4.0 on Alpine Linux distribution doesn't like defining static const inside a method, lets put that on outside the classes.
Behdad Esfahbod 54800f83 2018-05-30T16:26:50 [map] Mark prime_for HB_INTERNAL Trying to see if it fixes gcc-4.2 bots.
Behdad Esfahbod d600e844 2018-05-30T16:25:46 Add CrapOrNull
Garret Rieger 251cc977 2018-05-30T12:23:51 [subset] Switch to using hb_map_t inside of hb_subset_plan_t.
Behdad Esfahbod b3d45de6 2018-05-30T14:02:49 [map] Fix size calculation Don't know why I thought I should subtract one there...
Behdad Esfahbod ff92de76 2018-05-29T18:48:45 Remove HB_DISALLOW_COPY_AND_ASSIGN llvm-gcc-4.2 bot had this problem: hb-private.hh:812: error: initializer specified for non-virtual method 'void hb_vector_t<Type, StaticSize>::operator=(const hb_vector_t<Type, StaticSize>&) [with Type = hb_user_data_array_t::hb_user_data_item_t, unsigned int StaticSize = 1u]' Removing the delete didn't work with a constructor. So, remove constructor. Just disallow assignment. Still better than nothing.
Behdad Esfahbod a2444346 2018-05-29T18:32:57 [map] Fix resize
Behdad Esfahbod efbab6ba 2018-05-29T18:21:55 Disable use of thread_local Clang build was failing with: /usr/bin/ld: .libs/libharfbuzz_la-hb-blob.o: relocation R_X86_64_PC32 against undefined hidden symbol `_ZTH12_hb_CrapPool' can not be used when making a shared object Instead of fighting it, just disable use of it.
Behdad Esfahbod 8c2c5d45 2018-05-29T18:15:52 [map] Not going to implement is_equal which is complicated
Behdad Esfahbod ccd01c65 2018-05-29T18:13:13 [map] Move prime_mod to header to avoid linkage issues in subset.so
Behdad Esfahbod 6baebc5d 2018-05-29T17:58:46 [map] Fix copyright year
Behdad Esfahbod b0158129 2018-05-29T17:52:37 [map] Minor
Behdad Esfahbod 4099c66f 2018-05-29T17:52:07 [map] Don't return INVALID from get() just because in_error
Behdad Esfahbod 25783907 2018-05-29T17:34:35 [map] Fix bool use in C API
Behdad Esfahbod a9fa39dc 2018-05-29T17:31:01 [map] More minor
Behdad Esfahbod f76c4a77 2018-05-29T17:27:25 [map] Make initial resize actually work
Behdad Esfahbod 661e9ae4 2018-05-29T17:09:17 [map] Add clear(), is_empty(), and get_population()
Behdad Esfahbod b6959c33 2018-05-29T17:02:22 [map] Minor
Behdad Esfahbod 686476a8 2018-05-29T17:00:02 [map] Track population and occupancy separately
Behdad Esfahbod 8a978790 2018-05-29T16:45:20 [map] Minor
Behdad Esfahbod 6f12ce47 2018-05-29T16:45:06 Revert "[map] Return bool from set()" This reverts commit face7cf55d4895ffca314c8448c0a749a26cc182.
Behdad Esfahbod fc51c450 2018-05-29T16:44:55 Revert "[map] Make hb_map_set() return bool" This reverts commit 7bf1980146cfc081b06264ac367b23ae9397adf1.
Behdad Esfahbod 7bf19801 2018-05-29T16:42:44 [map] Make hb_map_set() return bool
Behdad Esfahbod face7cf5 2018-05-29T16:39:03 [map] Return bool from set()
Behdad Esfahbod e94be200 2018-05-29T16:37:44 [map] Implement operator[] for get()ting
Behdad Esfahbod 743fdd9c 2018-05-29T16:28:48 [map] First try at implementing an integer-to-integer hashmap Fully untested.
Ebrahim Byagowi 65c82179 2018-05-26T23:50:10 [blob] Use MAP_NORESERVE if available (#1039) MAP_NORESERVE is not available on macOS for example so set the flag to zero if not defined on the headers.
Behdad Esfahbod 1ce40d90 2018-05-25T16:34:08 [set] Remove stale comment
Behdad Esfahbod 6c222764 2018-05-25T16:21:27 Add HB_DISALLOW_COPY_AND_ASSIGN
Behdad Esfahbod fd3d0042 2018-05-24T15:58:26 Move pool definitions to hb-static.cc
Behdad Esfahbod 7f7b1370 2018-05-24T14:09:04 Fix Uniscribe build If a pointer type was passed to Null(), reinterpret_cast<> was complaining about qualifiers being removed. Turns out I need the const on the other side of "Type" to fix that. Also remove unused const from NullPool type.
Behdad Esfahbod 31c4236d 2018-05-24T13:38:46 Underflow protection in hb_vector_t
Behdad Esfahbod f83e992c 2018-05-24T11:46:57 Mark CrapPool thread_local Not sure if I like to keep it. For now, aim for correctness.
Behdad Esfahbod 5d801298 2018-05-24T11:33:15 Add CrapPool Common Regoin for Access Protection. Like the NullPool, but writable.
Behdad Esfahbod 673b764d 2018-05-23T20:12:23 Move code around